Eclipse Community Forums: EMF » Resource.getDefaultSaveOptions()

Help

Home

Home » Modeling » EMF » Resource.getDefaultSaveOptions()

Show: Today's Messages :: Show Polls :: Message Navigator

Resource.getDefaultSaveOptions() [message #1790338]

Fri, 08 June 2018 12:17

Ed Willink

Messages: 7670
Registered: July 2009

Senior Member

Hi

While debugging an unexpected PUT failure when saving a not-changed referenced http:/... resource within the EcoreEditor, I noticed that ResourceImpl.save(options) accesses defaultSaveOptions directly without first invoking getDefaultSaveOptions(). Consequently the XXXResource-specific defaultSaveOptions were ignored and since it differs whitespace-wise from the EcoreEditor default, the unchanged referenced Resource was deemed in need of a save.

Is this an ResourceImpl.save(options) bug, or is it a derived ResourceImpl responsibilty to call getDefaultSaveOptions() proactively?

Regards

Ed Willink

Report message to a moderator

Re: Resource.getDefaultSaveOptions() [message #1790369 is a reply to message #1790338]

Fri, 08 June 2018 17:04

Ed Merks

Messages: 33216
Registered: July 2009

Senior Member

There is no ResourceImpl.getDefaultSaveOptions so the general expectation has always been that that derived classes set the map into the variable, and populate that map, if there is a need for that.

Ed Merks
Professional Support: https://www.macromodeling.com/

Report message to a moderator

Previous Topic:	Cycle in EMF SDK p2
Next Topic:	genmodel code generation removes extensions in plugin.xml

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Fri Sep 20 04:18:31 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter