Eclipse Community Forums: Eclipse Titan » Patch submission procedure for repositories on git.eclipse.org

Help

Home

Home » Eclipse Projects » Eclipse Titan » Patch submission procedure for repositories on git.eclipse.org

Show: Today's Messages :: Show Polls :: Message Navigator

Patch submission procedure for repositories on git.eclipse.org [message #1783804]

Sun, 18 March 2018 10:46

Harald Welte

Messages: 140
Registered: July 2017
Location: Berlin, Germany

Senior Member

Hi!

I'm wondering what is the procedure to submit patches against the git.eclipse.org repositories. For the github repositories it's clear and I've successfully sent some pull requests.

But what about those on git.eclipse.org? Should I use git send-email? To where? Or are you using a gerrit instance somewhere?

Currently I have two actual bug fixes for titan.ProtocolEmulations.SCCP, see
https://github.com/osmocom/titan.ProtocolEmulations.SCCP/commit/5f926d43f224f15f9b3ca77a1ea379906cef9354
and https://github.com/osmocom/titan.ProtocolEmulations.SCCP/commit/6189ffb5325f79ebd0830e53211255816234ce54

If there's some public information about this (I suppose it should be the 1+1 of every FOSS project), my apologies, and thanks for pointing me in the right direction.

Regards,
Harald

Report message to a moderator

Re: Patch submission procedure for repositories on git.eclipse.org [message #1783805 is a reply to message #1783804]

Sun, 18 March 2018 11:20

Harald Welte

Messages: 140
Registered: July 2017
Location: Berlin, Germany

Senior Member

Ok, even in absence of any documentation that I could find I found gerrit.eclipse.org, signed the ECA, added signed-off-by and pushed the changes. see https://git.eclipse.org/r/119627 https://git.eclipse.org/r/119628

I think it's still a good suggestion to have a page somewhere summarizing the steps on how to contribute to TITAN, indicating the differences on github and eclipse hosted repositories.

And btw, I'm curious to hear why that dualism exists in the first place. Thanks!

Report message to a moderator

Re: Patch submission procedure for repositories on git.eclipse.org [message #1783810 is a reply to message #1783805]

Sun, 18 March 2018 12:05

Elemer Lelik

Messages: 1120
Registered: January 2015

Senior Member

Hi Harald,

please see:
https://docs.google.com/presentation/d/15zA7HjTlvEOshSb5W9qFQ7e4zIAU6Blk3_EV8ewYy_Y/edit#slide=id.p

as linked from https://github.com/eclipse/titan.core

The reason for splitting the project between github and Eclipse git is apparently that creating/maintaining etc. repos on github was too much work for
the admins so we've been given space on Eclipse git.
In honesty, as Titan has now over one hundred repos in total, I sort of understand this approach...

BR

Elemer

Report message to a moderator

Re: Patch submission procedure for repositories on git.eclipse.org [message #1804945 is a reply to message #1783810]

Wed, 03 April 2019 14:30

Harald Welte

Messages: 140
Registered: July 2017
Location: Berlin, Germany

Senior Member

From what I can tell the instructions are missing the step where you 'scp' the commit-msg hook from the gerrit server to your local repo, i.e. in general terms

scp -P $PORT $USER@$HOST:hooks/commit-msg .git/hooks

Without that, the "Change-Id" line is not added to the commit, and without that gerrit will refuse to accept the push.

Report message to a moderator

Re: Patch submission procedure for repositories on git.eclipse.org [message #1804946 is a reply to message #1804945]

Wed, 03 April 2019 14:43

Harald Welte

Messages: 140
Registered: July 2017
Location: Berlin, Germany

Senior Member

Another difference compared to other projects (I know) is that the submitter manually has to add reviewers to the patch. That's rather cumbersome. The submitter typically knows none of the people nor their responsibilities. This is much better solved by having gerrit add "default reviewers" for the titan.* projects.

This is possible using the "reviewers" plugin of gerrit, see https://gerrit.googlesource.com/plugins/reviewers/

If that plugin is not available on the eclipse.org gerrit instance, it may be possible to request its installation. It allows to define a set of reviewers for each "project", which then get added automatically for each new changeset on that project. This way the burden of adding them manually as per the google document is removed from the contributor.

Report message to a moderator

Re: Patch submission procedure for repositories on git.eclipse.org [message #1805063 is a reply to message #1804946]

Fri, 05 April 2019 06:52

Elemer Lelik

Messages: 1120
Registered: January 2015

Senior Member

Hi Harald,

we have added the scp command to the workflow, thanks for the hint.
I will look into adding default reviewers, this may take some time though as I will need to go through maybe 50 repositories .

Best regards
Elemer

Report message to a moderator

Previous Topic:	how to get previous version titan core and eclipse plugin
Next Topic:	Message segmentation in the IPL4 test port used in TCP mode

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Tue May 14 03:17:44 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter