Eclipse Community Forums: Sirius » Depth-first traversal problem in large-scale model

Help

Home

Home » Eclipse Projects » Sirius » Depth-first traversal problem in large-scale model

Show: Today's Messages :: Show Polls :: Message Navigator

Depth-first traversal problem in large-scale model [message #1773064]

Thu, 21 September 2017 03:04

mind calm

Messages: 57
Registered: July 2017

Member

Hi
I'm testing a large-scale model in Sirius. I met a StackOverflowError problem.
It's because the function AutoSizeAndRegionAwareGraphLayout.recursiveHandleVirtualNode(NodeList, EdgeList, VirtualNodesToNodes, Set, Set) uses depth-first traversal algorithm.
Is there any alternative solutions use breadth-first?

Best regards!

by Keep Mind Calm

Report message to a moderator

Re: Depth-first traversal problem in large-scale model [message #1773075 is a reply to message #1773064]

Thu, 21 September 2017 07:24

Ed Willink

Messages: 7655
Registered: July 2009

Senior Member

Hi

Breadth-first can be dreadful too but in differently large models.

The real solution is probably to change from stack recursion with 1000's possibly 10000's of bytes per recursion to a worklist/set recursion with 8/60 bytes per element; just an 8 byte index if an existing list is already available, or a bit more if a lazy Iterable is used.

Regards

Ed Willink

Report message to a moderator

Re: Depth-first traversal problem in large-scale model [message #1773095 is a reply to message #1773075]

Thu, 21 September 2017 12:46

Pierre-Charles David

Messages: 703
Registered: July 2009

Senior Member

Agreed with Ed. The code in question is in Sirius, but was originally lifted from GMF Runtime (CompositeDirectedGraphLayout) to add some customizations, so the stack usage issue is probably present there.

"mind calm", can you open a bugzilla for this? If possible with more details about what you mean by "large-scale model", or even better, a sample project with which we can reproduce the issue.

Regards,
Pierre-Charles

Pierre-Charles David - Obeo

Need training or professional services for Sirius?
http://www.obeodesigner.com/sirius

Report message to a moderator