Eclipse Community Forums: Graphiti » Custom Undo and Redo Behaviour for CreateConnectionFeature

Help

Home

Home » Modeling » Graphiti » Custom Undo and Redo Behaviour for CreateConnectionFeature

Show: Today's Messages :: Show Polls :: Message Navigator

Custom Undo and Redo Behaviour for CreateConnectionFeature [message #1753050]

Wed, 01 February 2017 13:02

Thomas Thonhofer

Messages: 25
Registered: July 2013

Junior Member

Hi everyone

For my diagram editor I have some features which implement ICustomUndoRedoFeature for custom undo and redo behaviour. When the feature is executed I need to remember some used objects which are required in the case of an undo. Currently I do this by putting some properties into the context of the execute(IContext context) method and retrieve them from the context of preUndo(IContext context) method. My assumption was that the context passed to the execute is the same instance as the one passed to preUndo. For most cases it works like that and everything is fine.

For my CreateConnectionFeature however, the context passed to execute(IContext context) is a different instance then the context passed to preUndo(IContext context). This means that the properties I put in during execution are not available in undo.

What is the expected behaviour? Is my assumption that the context instance should always be the same for one execution wrong? If so, what would be the proper way of remembering some objects for a feature execution, which are later available for undo and redo? If not then this is either a bug or something else is going wrong in my implementation. Any ideas?

Thanks,
Thomas

Report message to a moderator

Re: Custom Undo and Redo Behaviour for CreateConnectionFeature [message #1753055 is a reply to message #1753050]

Wed, 01 February 2017 13:24

Michael Wenz

Messages: 1931
Registered: July 2009
Location: Walldorf, Germany

Senior Member

Thomas,

this sounds pretty much like https://bugs.eclipse.org/bugs/show_bug.cgi?id=509764 .

Michael

Report message to a moderator

Re: Custom Undo and Redo Behaviour for CreateConnectionFeature [message #1753065 is a reply to message #1753055]

Wed, 01 February 2017 14:13

Thomas Thonhofer

Messages: 25
Registered: July 2013

Junior Member

Dear Michael

Thank you for the reply. Yes it looks like this is the cause of my problem. I didn't find this bug when searching for a solution, sorry for that.

I will try to find a workaround until it is resolved.

Thanks,
Thomas

Report message to a moderator

Previous Topic:	Traverse diagram elements based on underlying EObject Properties
Next Topic:	Custom Editor

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Fri Apr 26 02:51:32 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter