Linefeed in RawDataComLayer of FORTE [message #1736149] |
Mon, 27 June 2016 07:26 |
|
Hi,
I noticed in the FORTE sources, that the RawDataComLayer class appends a linefeed character to the data it sends. This behaviour is in conflict with openHAB MQTT bindings, which do not expect any control characters and we need to use openHAB to create an easy home automation interface (at least it seems to be the best choice for now).
In my opinion a raw data comm class should not append any additional characters, this would be the Job of classes derived from RawDataComLayer, which need to handle some special communication requirements.
Please advice, how I can change this, without a big Impact on the rest of the FORTE communication layer classes (e.g. create a new derived class from RawDataComLayer and override the send method). It's an easy Job to change the existing code, but i want to do it in the right way, without creating too much havoc
Thanks and kind regards
Herwig
|
|
|
Re: Linefeed in RawDataComLayer of FORTE [message #1736253 is a reply to message #1736149] |
Mon, 27 June 2016 21:09 |
|
Hi,
I think this comes from the origin of the raw layer: it originally was developed to allow simple strings to be sent over serial line and there you need the termination character for terminating the sequence. I think this should not be done here. It either should be done in the serial layer or in the FB generating the string. This would make the raw layer much more usable.
@Martin: what do you think. Did I miss anything.
Alois
|
|
|
|
Re: Linefeed in RawDataComLayer of FORTE [message #1737176 is a reply to message #1737038] |
Wed, 06 July 2016 08:50 |
|
In this case I would say we remove it. It would make the raw layer smaller and easier. I would not turn the termination as parameter for the raw layer. How about introducing a terminated raw layer which could even inherit from the raw layer?
Alois
|
|
|
|
|
Re: Linefeed in RawDataComLayer of FORTE [message #1737714 is a reply to message #1737194] |
Tue, 12 July 2016 08:17 |
|
Hi,
is it possible that the device manager is also using the RawDataComLayer?
I just commented the "linefeed" out and it seems that with this change, we experience download problems from the IDE. Even the "clean device" does not help much. I still need to do some detailled Investigation of this issue and i will try to reproduce it.
Kind regards
Herwig
|
|
|
|
|
|
|
|
Powered by
FUDForum. Page generated in 0.04713 seconds