Skip to main content



      Home
Home » Eclipse Projects » Eclipse Platform » What exactly has changed with ActionSets in 3.2
What exactly has changed with ActionSets in 3.2 [message #310301] Tue, 28 November 2006 10:11 Go to next message
Eclipse UserFriend
Hello,

I am stuck migrating my RCP application from 3.1 codebase to 3.2 codebase.

After few quite trivial fixes I got my application to build and launch
(from eclipse launcher at least), only to find that all my toolbar
buttons have disappeared!

To be exact - not all did disappear - the ones that sticked were the
ones I had put to toolbar manually in ApplicationActionBarAdvisor.

All the others that were contributed by plugins just disappeared
mysteriously.

And there is no clue whatsoever to why I can't get them back.
According to doc, it should all work as before.

Can anybody help me out
--
Roland Tepp
Re: What exactly has changed with ActionSets in 3.2 [message #310303 is a reply to message #310301] Tue, 28 November 2006 10:18 Go to previous messageGo to next message
Eclipse UserFriend
Hello Again,

After googling around to find some clue to what is going on, I stumbled
upon bug #136847: https://bugs.eclipse.org/bugs/show_bug.cgi?id=136847
(Declarative toolbar contributions are not shown in 3.2M6)

I replaced the ToolBarManager in my ActionBarAdvisor with
(eclipse internal) ToolBarManager2 instance and the buttons re-appeared
again...

(Going to Vote this bug Down!)

Roland Tepp kirjutas mulle midagi seesugust:
> Hello,
>
> I am stuck migrating my RCP application from 3.1 codebase to 3.2 codebase.
>
> After few quite trivial fixes I got my application to build and launch
> (from eclipse launcher at least), only to find that all my toolbar
> buttons have disappeared!
>
> To be exact - not all did disappear - the ones that sticked were the
> ones I had put to toolbar manually in ApplicationActionBarAdvisor.
>
> All the others that were contributed by plugins just disappeared
> mysteriously.
>
> And there is no clue whatsoever to why I can't get them back.
> According to doc, it should all work as before.
>
> Can anybody help me out

--
Roland Tepp
Re: What exactly has changed with ActionSets in 3.2 [message #310305 is a reply to message #310301] Tue, 28 November 2006 10:17 Go to previous messageGo to next message
Eclipse UserFriend
Do your actionSets have their default visibility set to true? If you
have Window>Customize Perpsctive in your RCP app, can you see the state
of your actionSets?

Are there any errors in your <runtime-workspace>/.metadata/.log file?

Later,
PW
Re: What exactly has changed with ActionSets in 3.2 [message #310351 is a reply to message #310305] Wed, 29 November 2006 08:04 Go to previous messageGo to next message
Eclipse UserFriend
No - as my RCP app uses multiple perspectives, I don't have my actionSet
default visibility set in any way.

Instead I use perspectiveExtensions extension point to direct the
visibility of my actionSets

Also - I don't have "Customize Perspective" available for my RCP app, so
I can't tell if the state of the actionSets right off the bat, based on
debugging of the code I had to do, all the enablement things seemed to
work as expected.

The hack that solved my problem involved changing one line of code in my
ApplicationActionBarAdvisor.fillCoolBar(ICoolBarManager) that added my
tb from:
coolBar.add(new ToolBarContributionItem(mainToolbar, "main"));

to use (internally packaged) another tb contribution item implementation
like this:
coolBar.add(new ToolBarContributionItem2(mainToolbar, "main"));

Seems like a bug somewhere in actionSet management code...
Although I can't tell what it is exactly without analyzing the issue
much more deeply...

Paul Webster kirjutas mulle midagi seesugust:
> Do your actionSets have their default visibility set to true? If you
> have Window>Customize Perpsctive in your RCP app, can you see the state
> of your actionSets?
>
> Are there any errors in your <runtime-workspace>/.metadata/.log file?
>
> Later,
> PW

--
Roland Tepp
Re: What exactly has changed with ActionSets in 3.2 [message #310370 is a reply to message #310351] Wed, 29 November 2006 13:28 Go to previous message
Eclipse UserFriend
Roland Tepp wrote:
>
> The hack that solved my problem involved changing one line of code in my
> ApplicationActionBarAdvisor.fillCoolBar(ICoolBarManager) that added my
> tb from:
> coolBar.add(new ToolBarContributionItem(mainToolbar, "main"));
>
> to use (internally packaged) another tb contribution item implementation
> like this:
> coolBar.add(new ToolBarContributionItem2(mainToolbar, "main"));
>
> Seems like a bug somewhere in actionSet management code...
> Although I can't tell what it is exactly without analyzing the issue
> much more deeply...

It was probably introduced by the code that added:
IActionBarConfigurer2 and createToolBarContributionItem(*),

Although it's not clear how ... the TBCI2 doesn't exactly add much to
the ToolBarContributionItem. Some interaction must make the action set
contributions not be filled.

As you found, it's bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=136847

Later,
PW
Previous Topic:Mirroring update site
Next Topic:IJobManager
Goto Forum:
  


Current Time: Mon Nov 10 10:47:45 EST 2025

Powered by FUDForum. Page generated in 0.02675 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top