Hi

XExpression has not only the subclasses XFeatureCall and XBlockExpression but XIfExpression too

def dispatch CharSequence print(XFeatureCall e)

Please share all Print methods

--
Need training, onsite consulting or any other kind of help for Xtext?
Go visit http://xtext.itemis.com or send a mail to xtext at itemis dot de

I told you to add a print method for XIfExpression too

--
Need training, onsite consulting or any other kind of help for Xtext?
Go visit http://xtext.itemis.com or send a mail to xtext at itemis dot de

Hi there should be content assist. In doubt switch to a java util

--
Need training, onsite consulting or any other kind of help for Xtext?
Go visit http://xtext.itemis.com or send a mail to xtext at itemis dot de

Hi,

i dont know if this working mode leads to anything.
what the generator does: it basically traverses the ast
if there is a todo generated you have something todo (captain obvious)

def dispatch CharSequence print(XExpression e) '''
//TODO + «e.eClass»
'''

might help

and of course a else can be null so you may have to handle this

this might help

def dispatch CharSequence print(Void e) '''

'''

and of course you might have to change the startuml enduml thing since if(){} is a xblockexpression too

Hi,

you have the ast and travere it already ?!?
Or do you mean the concrete syntax tree aka node model? NodeModelUtil is your friend

Hi,

having a look at the class could have given you

org.eclipse.xtext.nodemodel.util.NodeModelUtils.findActualNodeFor(EObject)
which gives org.eclipse.xtext.nodemodel.INode.getAsTreeIterable()

Hi,

having a look at the class could have given you

org.eclipse.xtext.nodemodel.util.NodeModelUtils.findActualNodeFor(EObject)
which gives org.eclipse.xtext.nodemodel.INode.getAsTreeIterable()

Hi,

the nodes are the text, so instanceof will never work

so do you want to traverse the AST (EObjects) or the CST (Nodes) or both?

for the CST two hints:
- node.getText() gives you the text in the file
- node.getGrammarElement() gives you an EObject that describes what xtext actually did
this may be: Assignment, RuleCall, CrossReference etc. (by downcasting you get more infos)

Hi,

i the only thing i can recommend is: use the debugger. see what is there.

Yes debug the print method. start the runtime in debug mode.

Hi,

sorry i do not have the time do your work since it is NOT trivial. so it may be very hard for you as a beginner.
xbase is a gpl so the expressions to handle may be very very complex. too complex for an acitivity diagram.
this is why i am not sure if xbase is at all the right tool for your purpose.

never the less i still dont get the point why you dont use the ast traversal
as we started.

you would have implemented XIfExpression and everything would be fine.

(of course you have to structure the template so that it creates a plantuml valid output)

~Christian

Have a look at the print method? its everything there.
you may have e.g. move the -->
to the for loop and remove it from xfeaturecall.

if you have problems with xtend:
build the platuml string with plain java.

~Christian

@startuml
(*) --> if "getUp" then
-->[true] "haveBreakfast"
--> "workAtHome"
else
->[false] "Sleep"
--> "workAtHome"
endif
--> "haveLunch"
--> (*)
@enduml

That is the logic you are looking for, just to clarify?
I guess you'd just have to put the first expression outside an if-else-block at the end of either block, so some sort of look-ahead.
That's just off the top of my head, though.

I see - but doesn't that operation describe something different from what you actually want?
Unless I'm missing something, like this you'd only have an option between having breakfast or sleeping, after that working at home and having lunch happen anyway, due to them not being outside of the selection.

op activityInOneDay(): void {
  if (getUp()) {
    haveBreakfast();
    workAtHome();
    haveLunch();
  } else {
    Sleep();
  }
}

Shouldn't that be what you want? Again, I could be missing something here.

Well, to cover those cases, you'll have to change the editor accordingly, easy as that.
What you would want to do, I think, would be firstly checking if there is a return statement in any of the branches, and if there is, terminate that activity with --> (*). If there's not, you could look at the next statement outside the if/else and add it to the end of either branch.
That's just a spontaneous idea of how to get a proper diagram going, as for the concrete generator implementation, that's your task.

Yes, this is my task. Thank you very much for your idea!
Claudio Heeg wrote on Thu, 18 April 2013 06:54

Well, to cover those cases, you'll have to change the editor accordingly, easy as that.
What you would want to do, I think, would be firstly checking if there is a return statement in any of the branches, and if there is, terminate that activity with --> (*). If there's not, you could look at the next statement outside the if/else and add it to the end of either branch.
That's just a spontaneous idea of how to get a proper diagram going, as for the concrete generator implementation, that's your task.

Hi,

Your generator doesnt know anything about the semantics of return.
this is one reason why what you want to achieve is very hard with xbase.
cause you have to do control flow analysis. this is a huge field

Everything is possible. same as before: if you dont feel comfortable with xtend do the traveral in java

Sorry i dont believe what we are doing here leads to anything.
it is an algorithmic thing that has nothing todo with xtext.

one problem is that plantuml syntax sucks at this point

the flollowing might be a starting point it might be a dead end too.
and you will ask again and i will not have the time to do the job!

class MySuperGen extends JvmModelGenerator {
	
	@Inject extension IQualifiedNameProvider
	
	def dispatch internalDoGenerate(DomainModel m, IFileSystemAccess fsa
	) {
		for (e : m.eAllContents.toIterable.filter(typeof(Entity))) {
			for (op : e.features.filter(typeof(Operation))) {
				val content = '''
				@startuml
(*) --> «op.body.print(newArrayList(),"")»
«««	 --> (*)
@enduml
			'''.toString
				
					fsa.generateFile(op.fullyQualifiedName.toString+".txt",content)
				if (fsa instanceof IFileSystemAccessExtension3) {
					val out = new ByteArrayOutputStream()
				new SourceStringReader(content).generateImage(out)
					(fsa as IFileSystemAccessExtension3).generateFile(op.fullyQualifiedName.toString+".png",new ByteArrayInputStream(out.toByteArray))
				} else {
				}	
			}
		}
	}
	
	

def dispatch CharSequence print(XIfExpression e, List<XExpression> queue, String iffi) 
//	'''if «IF e.^if instanceof XFeatureCall» "«(e.^if as XFeatureCall).feature.simpleName»"	«ENDIF» then 
'''if TODO then 
«e.then.print(queue,"[true]")»
else
«e.^else.print(queue, "[false]")»	
endif'''

def dispatch CharSequence print(XExpression e, List<XExpression> queue, String iffi) '''
//TODO + «e.eClass»
«handleQueue(queue,"")»
'''

def dispatch CharSequence print(Void e, List<XExpression> queue, String iffi) '''
--> «iffi» "null"
«handleQueue(queue,"")»
'''

def dispatch print(XBlockExpression e, List<XExpression> queue, String iffi)
{
	val newQueue = newArrayList()
	newQueue.addAll(e.expressions)
	newQueue.addAll(queue)
	handleQueue(newQueue, iffi)
}

def handleQueue(List<XExpression> queue, String iffi) {
	if (queue.size > 0) {
		print(queue.head, queue.tail.toList, iffi)
	} else {
		''''''
	}	
}

def dispatch CharSequence print(XFeatureCall e, List<XExpression> queue, String iffi) 
'''--> «iffi» "«e.feature.simpleName»"
«handleQueue(queue, "")»'''

def dispatch CharSequence print(XMemberFeatureCall e, List<XExpression> queue, String iffi) 
//	'''"«e.feature.simpleName»"'''
'''--> «iffi» "«e.feature.identifier»"
«handleQueue(queue,"")»'''


def dispatch CharSequence print(XReturnExpression e, List<XExpression> queue, String iffi) 
'''--> (*)'''
	
}

Sorry i dont believe what we are doing here leads to anything.
it is an algorithmic thing that has nothing todo with xtext.

one problem is that plantuml syntax sucks at this point

the flollowing might be a starting point it might be a dead end too.
and you will ask again and i will not have the time to do the job!

class MySuperGen extends JvmModelGenerator {
	
	@Inject extension IQualifiedNameProvider
	
	def dispatch internalDoGenerate(DomainModel m, IFileSystemAccess fsa
	) {
		for (e : m.eAllContents.toIterable.filter(typeof(Entity))) {
			for (op : e.features.filter(typeof(Operation))) {
				val content = '''
				@startuml
(*) --> «op.body.print(newArrayList(),"")»
«««	 --> (*)
@enduml
			'''.toString
				
					fsa.generateFile(op.fullyQualifiedName.toString+".txt",content)
				if (fsa instanceof IFileSystemAccessExtension3) {
					val out = new ByteArrayOutputStream()
				new SourceStringReader(content).generateImage(out)
					(fsa as IFileSystemAccessExtension3).generateFile(op.fullyQualifiedName.toString+".png",new ByteArrayInputStream(out.toByteArray))
				} else {
				}	
			}
		}
	}
	
	

def dispatch CharSequence print(XIfExpression e, List<XExpression> queue, String iffi) 
//	'''if «IF e.^if instanceof XFeatureCall» "«(e.^if as XFeatureCall).feature.simpleName»"	«ENDIF» then 
'''if TODO then 
«e.then.print(queue,"[true]")»
else
«e.^else.print(queue, "[false]")»	
endif'''

def dispatch CharSequence print(XExpression e, List<XExpression> queue, String iffi) '''
//TODO + «e.eClass»
«handleQueue(queue,"")»
'''

def dispatch CharSequence print(Void e, List<XExpression> queue, String iffi) '''
--> «iffi» "null"
«handleQueue(queue,"")»
'''

def dispatch print(XBlockExpression e, List<XExpression> queue, String iffi)
{
	val newQueue = newArrayList()
	newQueue.addAll(e.expressions)
	newQueue.addAll(queue)
	handleQueue(newQueue, iffi)
}

def handleQueue(List<XExpression> queue, String iffi) {
	if (queue.size > 0) {
		print(queue.head, queue.tail.toList, iffi)
	} else {
		''''''
	}	
}

def dispatch CharSequence print(XFeatureCall e, List<XExpression> queue, String iffi) 
'''--> «iffi» "«e.feature.simpleName»"
«handleQueue(queue, "")»'''

def dispatch CharSequence print(XMemberFeatureCall e, List<XExpression> queue, String iffi) 
//	'''"«e.feature.simpleName»"'''
'''--> «iffi» "«e.feature.identifier»"
«handleQueue(queue,"")»'''


def dispatch CharSequence print(XReturnExpression e, List<XExpression> queue, String iffi) 
'''--> (*)'''
	
}