Eclipse Community Forums: GMF (Graphical Modeling Framework) » Performance: calculateEnabled called twice in refresh method of some DiagramAction

Home » Modeling » GMF (Graphical Modeling Framework) » Performance: calculateEnabled called twice in refresh method of some DiagramAction

Performance: calculateEnabled called twice in refresh method of some DiagramAction [message #986252]

Mon, 19 November 2012 11:10

Eclipse User

Hi,

For example in AutoSizeAction the method refresh is like this :

public void refresh() {
super.refresh();
setEnabled(calculateEnabled());
}

and the code of the super class DiagramAction is like this :

public void refresh() {
_operationSet = null; // invalidate the cached set
updateTargetRequest();
setEnabled(calculateEnabled());
}

As result, the "setEnabled(calculateEnabled());" is called twice. I do
not think there was a valid reason. Is that correct?

Regards,

Laurent

Attachment: laurent_redor.vcf
(Size: 0.21KB, Downloaded 187 times)

Re: Performance: calculateEnabled called twice in refresh method of some DiagramAction [message #986352 is a reply to message #986252]

Tue, 20 November 2012 03:25

Eclipse User

Hi Laurent,

you should open a bug on this with runtime as component. https://bugs.eclipse.org/bugs/enter_bug.cgi?product=GMP

Ralph

Re: Performance: calculateEnabled called twice in refresh method of some DiagramAction [message #986378 is a reply to message #986352]

Tue, 20 November 2012 04:48

Eclipse User

Hi Ralph,

I create https://bugs.eclipse.org/bugs/show_bug.cgi?id=394627 for this
problem.

Laurent

On 20/11/2012 09:25, Ralph Gerbig wrote:
> Hi Laurent,
>
> you should open a bug on this with runtime as component.
> https://bugs.eclipse.org/bugs/enter_bug.cgi?product=GMP
>
> Ralph

Attachment: laurent_redor.vcf
(Size: 0.21KB, Downloaded 185 times)

Previous Topic:	Change fill color on Text doesn't change it
Next Topic:	how to center align the label name in gmfgraph?

Goto Forum:

-=] Back to Top [=-

Current Time: Fri Jul 25 23:48:00 EDT 2025

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter