| key bindings conflct with Java development [message #689888] |
Tue, 28 June 2011 10:43  |
Eclipse User |
|
|
|
Three of the egit bindings are in conflict with Java refactoring bindings. Since they conflict, neither works. And since key bindings are workspace-specific, every new workspace has to have its Key preferences adjusted. It's getting to be a nuisance.
The conflicts are:
Inline (Java) v Ignore (egit)
Change Method Signature (Java) v Commit (egit)
Extract Method (Java) v Merge (egit)
Like most serious Java developers, I use the Java refactoring keys every day and have done for many years. So I would recommend changing the egit bindings.
Or they could be dropped altogether. Personally I very rarely need Ignore and only occasionally need Merge. The right-click menu seems fine for these (or add a toolbar item for Merge). Of course I use Commit frequently. But Commit is already available through a toolbar mouse-click. And in any case my sense is that most developers want to review changes before committing, which the key binding, like the toolbar item, doesn't support. The Git Staging view handles commit reviewing very nicely.
|
|
|
|
|
|
| Re: key bindings conflct with Java development [message #692894 is a reply to message #692607] |
Tue, 05 July 2011 08:30  |
| Eclipse User |
|
|
|
Keybindings look good with last night's build.
One last question. The checkin message for your fix says "The merge command is also available in the Git toolbar." Was that change supposed to be part of this commit? If so, it doesn't seem to have made it. Not a big deal either way, it's easy enough to pick 'merge' from the right-click menu, I just wanted to mention it
|
|
|
Powered by
FUDForum. Page generated in 0.04178 seconds
Home