Eclipse Community Forums: Java Development Tools (JDT) » Could someone help me create a commit?

Home » Language IDEs » Java Development Tools (JDT) » Could someone help me create a commit?

Could someone help me create a commit? [message #1794613]

Mon, 03 September 2018 17:54

Eclipse User

I've encountered an annoying bug (#537873), and it seems rather simple, so I would like to fix it myself.

This is my first time contributing to an open source project, and I am not super advanced at Java, so I would really appreciate it if someone could take some time to walk me through fixing this bug.

If someone could help me this time, I would be happy to use the experience to fix some other simple bugs to pay back the community.

I would really appreciate your time. Thanks.

Re: Could someone help me create a commit? [message #1794673 is a reply to message #1794613]

Tue, 04 September 2018 14:02

Eclipse User

First question: have you tried / succeeded to create a workspace with the relevant JDT sources?
If not, your first steps could be along the lines of https://wiki.eclipse.org/JDT_Code_Setup_Using_Oomph

OTOH, before diving deep into the code please outline your proposed solution in the bug, to ensure it doesn't conflict with other interests.

Re: Could someone help me create a commit? [message #1794686 is a reply to message #1794673]

Tue, 04 September 2018 20:13

Eclipse User

My proposed solution is to add an option under preferences -> Java -> Editor -> Content assist. The option would be a checkbox, and it would say "Only insert suggestions when enter key is pressed". I have not yet created a workspace with the sources, because I am not entirely sure which ones I need. I think that I need eclipse.platform.text, but I am not sure which others, if any. Do I only need eclipse.platform.text, or are there any others I am missing?

Re: Could someone help me create a commit? [message #1794700 is a reply to message #1794686]

Wed, 05 September 2018 01:51

Eclipse User

There's also a tutorial for provisioning a workspace with the source code for the entire Eclipse Platform SDK using Oomph:

https://wiki.eclipse.org/Eclipse_Platform_SDK_Provisioning

This will of course be way more than you actually need, but the point is that all of the platform's projects have Oomph setups.

What you describe would of course be implemented in JDT's source, i.e., it's a preference on the one of JDT's preference pages. But you might also need to change something in the APIs JDT uses for content assist.

You can start with JDT's setup, as Stephan suggested, and you can later use "File -> Import... -> Oomph -> Projects into Workspace" to add "Eclipse Projects -> Platform -> Text" to your workspace if you need that. As I said, all of the Platform SDK has associated Oomph setups so you can add any of the ones you find out later that you need.

Re: Could someone help me create a commit? [message #1794747 is a reply to message #1794700]

Wed, 05 September 2018 21:03

Eclipse User

I am still a little unclear on exactly which packages will need changing. Where would I add an option the preferences menu?

Re: Could someone help me create a commit? [message #1794758 is a reply to message #1794747]

Thu, 06 September 2018 03:34

Eclipse User

The PDE Spy is quite useful for answering questions such as this, try Alt-Shift-F1 and Alt-Shift-F2. If you install the source, you can also search for classes with likely names, e.g, *Preference*. If you debug launch, you can set breakpoints to see what's going on. Or you might stop the process when a dialog is showing and then on the main thread you can see how the dialog is launched. I work a lot on unfamiliar code and such these types approaches to figure out where things are implemented, because generally no one will answer those questions for me and even if they would, it would take longer to wait that figuring it out for myself.

Re: Could someone help me create a commit? [message #1794786 is a reply to message #1794758]

Thu, 06 September 2018 09:11

Eclipse User

Quote:

My proposed solution is to add an option under preferences -> Java -> Editor -> Content assist. The option would be a checkbox, and it would say "Only insert suggestions when enter key is pressed".

Let's please transfer such discussion into the bug, so we have it all in one place, and no-one is surprised when a proposed fix appears and what exactly it implements. TIA.

Re: Could someone help me create a commit? [message #1794913 is a reply to message #1794786]

Mon, 10 September 2018 19:53

Eclipse User

I will continue this discussion in bug #348857. Please see the new comments.

[Updated on: Mon, 10 September 2018 19:56] by Moderator

Re: Could someone help me create a commit? [message #1794931 is a reply to message #1794913]

Tue, 11 September 2018 05:41

Eclipse User

Ethan Freeman wrote on Tue, 11 September 2018 01:53