Eclipse Community Forums: Eclipse Layout Kernel » Issue with Sirius Custom Layout and ELK Layout

Home » Modeling » Eclipse Layout Kernel » Issue with Sirius Custom Layout and ELK Layout

Issue with Sirius Custom Layout and ELK Layout [message #1792793]

Tue, 24 July 2018 03:43

Eclipse User

Hello ,

When using Sirius with our custom layouts, we encountered an issue due to the presence of ELK plugins.

ELK Defines a generic laout provider which is contributed using the extension : org.eclipse.gmf.runtime.diagram.ui.layoutProviders
Plugin : org.eclipse.elk.conn.gmf

Problem 1 : The ELK Layout provider has a very general "provides" method :
/**
* {@inheritDoc}
*/
public boolean provides(final IOperation operation) {
return operation instanceof ILayoutNodeOperation;
}

Due to this, the layout provider is applicable for almost all use cases.
This is not an issue on its own, since a generic layout provider is expected to work this way.

However,

Problem 2 : The ELK Layout Provider is also contributed with the highest possible priority.
In the extension specification, the provider is assigned with the priority "Highest".

Due to the above two points, it is impossible to have a custom layout contributed when ELK Layout is included in the list of plugins.

Proposal :
Change the priority of the ELK Layout contribution to a lower value.
This will ensure that other custom layouts can be integrated along with ELK Layouts.

Regards,
Rakesh

[Updated on: Tue, 24 July 2018 03:44] by Moderator

Re: Issue with Sirius Custom Layout and ELK Layout [message #1792803 is a reply to message #1792793]

Tue, 24 July 2018 05:29

Eclipse User

Please write a GitHub issue for this.

Re: Issue with Sirius Custom Layout and ELK Layout [message #1792809 is a reply to message #1792803]

Tue, 24 July 2018 05:53

Eclipse User

Hello ,

We have created a new issue.

https://github.com/eclipse/elk/issues/356

Regards,
Rakesh

Previous Topic:	[ELK] NPE exception in ELK 0.4.0
Next Topic:	Deactivate ELK

Goto Forum:

-=] Back to Top [=-

Current Time: Sat May 10 04:03:50 EDT 2025

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter