Eclipse Community Forums: Epsilon » problem with adding element to ordered set

Home » Modeling » Epsilon » problem with adding element to ordered set(problem with adding element to ordered set)

problem with adding element to ordered set [message #1758636]

Thu, 30 March 2017 17:50

Eclipse User

Hi ,
I am trying to add a child type activity to taskactivities(parent)
and when i run the code it keeps adding the child to the root .

I have attached a minimal example to reproduce the problem please :

1- run testCode.eol launch
2-open NewLqnFeb.model (you can see that New OpaqueAction activity added to the root not not taskactivities.
3.lqnmodel is the metamodel

Thanks,
Taghreed

Attachment: MinimalExample2.zip
(Size: 5.08KB, Downloaded 167 times)

Re: problem with adding element to ordered set [message #1758650 is a reply to message #1758636]

Fri, 31 March 2017 03:46

Eclipse User

Hi Taghreed,

"taskactivity" is a collection so "taskactivity.activity" returns a collection of collections, which you're then adding "activity" to. This is the expected behaviour; it appears that you're adding "activity" to the wrong collection.

Thanks a lot for the additional effort you've put into preparing your minimal example. A couple more things if I may:
- In Ecore there's a strong convention for class names to start with an upper-case letter and to be in singular (i.e. "class TaskActivity" instead of "class taskactivities")
- It's usually a good idea for variable names to be consistent with the values they hold. For example, in "var taskactivity = t.taskactivities;" your variable should be called "taskactivities" instead of "taskactivity" as you're expecting its value to be assigned to a collection. This can help make your code more readable and maintainable.
- I would recommend using "var tasks = Lqn!task.all;" in the first statement of your program. The current syntax works as "tasks" is then consumed in a for loop but "tasks.size()" for example wouldn't work as expected because the value of "tasks" in your version of the program is a model element type; not a collection of all its instances.

Cheers,
Dimitris

[Updated on: Fri, 31 March 2017 03:57] by Moderator

Re: problem with adding element to ordered set [message #1758681 is a reply to message #1758650]

Fri, 31 March 2017 11:41

Eclipse User

Hi Dimitris,
Thanks for your comments.I checked the metamodel and activity is a child for taskactivities according to the metamodel .Is there any trick to add the activity to its parent not to the root.

Cheers,
Taghreed

Re: problem with adding element to ordered set [message #1758687 is a reply to message #1758681]

Fri, 31 March 2017 12:16

Eclipse User

Hi Taghreed,

You just need to add your "activity" under the "activity" containment reference of a "taskactivities" model element.

One more piece of advice that I forgot to mention in my previous message:
- It is also very useful for the names of attributes/references to reflect their multiplicities e.g. "val activity[1..*] activity;" should read "val Activity[1..*] activities;" instead

If you can try to refactor your metamodel according to these principles I will be able to help more effectively.

Cheers,
Dimitris

[Updated on: Sat, 01 April 2017 03:29] by Moderator

Re: problem with adding element to ordered set [message #1758690 is a reply to message #1758687]

Fri, 31 March 2017 12:44

Eclipse User

Hi Dimitris,
Refactoring the metamodel will affect the transformation and other codes that depend on it so i don't think it is going to be easy at this point:)
i am using this code taskactivities.activity.add(activity2); to add my "activity" under the "activity" containment reference but it didn't work .
Please can you give me any trick to do that .

Thanks,
Taghreed

Re: problem with adding element to ordered set [message #1758696 is a reply to message #1758690]

Fri, 31 March 2017 13:19

Eclipse User

Hi Taghreed,

Trying to understand and suggest solutions against a poorly named metamodel is not easy either I'm afraid. You'll have to help me out a bit more here before I can provide any further assistance.

Cheers,
Dimitris

[Updated on: Fri, 31 March 2017 13:21] by Moderator

Re: problem with adding element to ordered set [message #1758716 is a reply to message #1758696]

Fri, 31 March 2017 17:58

Eclipse User

Hi Dimitris ,
I have attached the metamodel as a diagram ,i hope it can help you .The relation between taskactivities and activity is very clear in the diagram.

I wish you can help me .

Thanks,
Taghreed.

Attachment: LQN metamodel.png
(Size: 330.90KB, Downloaded 417 times)

[Updated on: Fri, 31 March 2017 18:00] by Moderator

Re: problem with adding element to ordered set [message #1758730 is a reply to message #1758716]

Sat, 01 April 2017 03:27

Eclipse User

Hi Taghreed,

To add an "activity" "a" under a "taskactivities" "ta", "ta.activity.add(a);" should work.

Cheers,
Dimitris

Re: problem with adding element to ordered set [message #1758745 is a reply to message #1758730]

Sat, 01 April 2017 11:16

Eclipse User

Hi Dimitris,
i added a loop to for taskactivities sequence then i used ta.activity.add(a) .Thanks for your help.

var tasks = Lqn!task.all;
	 	  for (t in  tasks){
	 	  if (t.name="Artifact3"){
	 	  var ta=t.taskactivities.println();	 	  
	 if (not ta.isEmpty()){
          	  var a :new Lqn!activity;
                 a.name="OpaqueAction999";
             
             for (tac in t.taskactivities) {
                 tac.activity.add(a);}
               "activity2.name ".print()+a.name.println();
          	
          	  }
      
          	 }
	 	      }

[Updated on: Sat, 01 April 2017 11:18] by Moderator

Previous Topic:	commit in EOL
Next Topic:	Error in installing epsilon on eclipse Luna

Goto Forum:

-=] Back to Top [=-

Current Time: Tue Jul 22 03:59:40 EDT 2025

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter