Home » Eclipse Projects » GEF » Bug in GEF, Eclipse Platform, or LogicEditor
| Bug in GEF, Eclipse Platform, or LogicEditor [message #127655] |
Fri, 16 April 2004 08:27  |
Eclipse User |
|
|
|
Originally posted by: phil.williams.toadmail.com
There is a bug in the LogicEditor Example (and also my editor which I
used the LogicEditor as a starting point) and I am not sure where the
bug is or how to correct it so I am hoping that someone here can offer
some insight. I am using 2.1.2. Here is the symptom.
Open a diagram (I open a 4-bit adder) in the logic editor and save it.
Then do a "Save As..." and save it under a different file name. If you
now modify (say, increment one of the LEDs) it, the editor is marked
dirty as expected. Now Save the changed diagram (the editor is not
marked dirty anymore) close the editor and open it back up. The changes
were not saved. I originally thought that this was isolated to changes
made in the outline view, but is also happens if the changes were made
directly in the diagram.
It seems that there is a handle to the old model object lying around
somewhere. You can see the handle in the outline page (or any page in a
PageView) if you set the break point appropriately. However, if I put
breakpoints in the performSaveAs() method, you will see that the model
does seem to be updated.
Any ideas on how to fix or work around this bug? I thought that somehow
the workbench's selection was not being updated (since doCreatePage() is
not being called for the newly "saved as" editor, but it seems a little
more than that since changes in the editor are not saved as well.
Your help would be greatly appreciated as always.
Thanks,
Phil
|
|
|
| Re: Bug in GEF, Eclipse Platform, or LogicEditor [message #127682 is a reply to message #127655] |
Fri, 16 April 2004 10:38  |
| Eclipse User |
|
|
|
Originally posted by: none.us.ibm.com
Phil,
See
https://bugs.eclipse.org/bugs/show_bug.cgi?id=46005.
"Phil Williams" <phil.williams@toadmail.com> wrote in message
news:c5oj51$26m$1@eclipse.org...
> There is a bug in the LogicEditor Example (and also my editor which I
> used the LogicEditor as a starting point) and I am not sure where the
> bug is or how to correct it so I am hoping that someone here can offer
> some insight. I am using 2.1.2. Here is the symptom.
>
> Open a diagram (I open a 4-bit adder) in the logic editor and save it.
> Then do a "Save As..." and save it under a different file name. If you
> now modify (say, increment one of the LEDs) it, the editor is marked
> dirty as expected. Now Save the changed diagram (the editor is not
> marked dirty anymore) close the editor and open it back up. The changes
> were not saved. I originally thought that this was isolated to changes
> made in the outline view, but is also happens if the changes were made
> directly in the diagram.
>
> It seems that there is a handle to the old model object lying around
> somewhere. You can see the handle in the outline page (or any page in a
> PageView) if you set the break point appropriately. However, if I put
> breakpoints in the performSaveAs() method, you will see that the model
> does seem to be updated.
>
> Any ideas on how to fix or work around this bug? I thought that somehow
> the workbench's selection was not being updated (since doCreatePage() is
> not being called for the newly "saved as" editor, but it seems a little
> more than that since changes in the editor are not saved as well.
>
> Your help would be greatly appreciated as always.
>
> Thanks,
> Phil
>
|
|
|
| Re: Bug in GEF, Eclipse Platform, or LogicEditor [message #127692 is a reply to message #127682] |
Fri, 16 April 2004 09:55 |
| Eclipse User |
|
|
|
Originally posted by: phil.williams.toadmail.com
This is a multi-part message in MIME format.
--------------030401090501000404020609
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Thanks that did the trick. I should have searched there in the first place.
Phil
Whitney Sorenson wrote:
>Phil,
>
>See
>https://bugs.eclipse.org/bugs/show_bug.cgi?id=46005.
>
>"Phil Williams" <phil.williams@toadmail.com> wrote in message
>news:c5oj51$26m$1@eclipse.org...
>
>
>>There is a bug in the LogicEditor Example (and also my editor which I
>>used the LogicEditor as a starting point) and I am not sure where the
>>bug is or how to correct it so I am hoping that someone here can offer
>>some insight. I am using 2.1.2. Here is the symptom.
>>
>>Open a diagram (I open a 4-bit adder) in the logic editor and save it.
>>Then do a "Save As..." and save it under a different file name. If you
>>now modify (say, increment one of the LEDs) it, the editor is marked
>>dirty as expected. Now Save the changed diagram (the editor is not
>>marked dirty anymore) close the editor and open it back up. The changes
>>were not saved. I originally thought that this was isolated to changes
>>made in the outline view, but is also happens if the changes were made
>>directly in the diagram.
>>
>>It seems that there is a handle to the old model object lying around
>>somewhere. You can see the handle in the outline page (or any page in a
>>PageView) if you set the break point appropriately. However, if I put
>>breakpoints in the performSaveAs() method, you will see that the model
>>does seem to be updated.
>>
>>Any ideas on how to fix or work around this bug? I thought that somehow
>>the workbench's selection was not being updated (since doCreatePage() is
>>not being called for the newly "saved as" editor, but it seems a little
>>more than that since changes in the editor are not saved as well.
>>
>>Your help would be greatly appreciated as always.
>>
>>Thanks,
>>Phil
>>
>>
>>
>
>
>
>
--------------030401090501000404020609
Content-Type: text/html; charset=us-ascii
Content-Transfer-Encoding: 7bit
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
<title></title>
</head>
<body>
Thanks that did the trick. I should have searched there in the first
place.<br>
<br>
Phil<br>
<br>
Whitney Sorenson wrote:
<blockquote cite="midc5on8m$83o$1@eclipse.org" type="cite">
<pre wrap="">Phil,
See
<a class="moz-txt-link-freetext" href="https://bugs.eclipse.org/bugs/show_bug.cgi?id=46005">https://bugs.eclipse.org/bugs/show_bug.cgi?id=46005</a>.
"Phil Williams" <a class="moz-txt-link-rfc2396E" href="mailto:phil.williams@toadmail.com"><phil.williams@toadmail.com></a> wrote in message
<a class="moz-txt-link-freetext" href="news:c5oj51$26m$1@eclipse.org">news:c5oj51$26m$1@eclipse.org</a>...
</pre>
<blockquote type="cite">
<pre wrap="">There is a bug in the LogicEditor Example (and also my editor which I
used the LogicEditor as a starting point) and I am not sure where the
bug is or how to correct it so I am hoping that someone here can offer
some insight. I am using 2.1.2. Here is the symptom.
Open a diagram (I open a 4-bit adder) in the logic editor and save it.
Then do a "Save As..." and save it under a different file name. If you
now modify (say, increment one of the LEDs) it, the editor is marked
dirty as expected. Now Save the changed diagram (the editor is not
marked dirty anymore) close the editor and open it back up. The changes
were not saved. I originally thought that this was isolated to changes
made in the outline view, but is also happens if the changes were made
directly in the diagram.
It seems that there is a handle to the old model object lying around
somewhere. You can see the handle in the outline page (or any page in a
PageView) if you set the break point appropriately. However, if I put
breakpoints in the performSaveAs() method, you will see that the model
does seem to be updated.
Any ideas on how to fix or work around this bug? I thought that somehow
the workbench's selection was not being updated (since doCreatePage() is
not being called for the newly "saved as" editor, but it seems a little
more than that since changes in the editor are not saved as well.
Your help would be greatly appreciated as always.
Thanks,
Phil
</pre>
</blockquote>
<pre wrap=""><!---->
</pre>
</blockquote>
</body>
</html>
--------------030401090501000404020609--
|
|
|
| Re: Bug in GEF, Eclipse Platform, or LogicEditor [message #127764 is a reply to message #127692] |
Fri, 16 April 2004 14:09 |
| Eclipse User |
|
|
|
This is a multi-part message in MIME format.
------=_NextPart_000_0062_01C423B4.087ECE30
Content-Type: text/plain;
charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
The best thing to do would be to find an example better than the =
LogicEditor (perhaps JDT's java editor). The LogicEditor has not been =
extensively tested and I wouldn't be surprised if it still had some =
bugs. Showing how to save/load your file, etc. was never the main goal =
of the LogicEditor. In any case, if you didn't want to change too many =
things, your best bet would be to look at the LogicEditor in the HEAD =
stream and do what it does. The fix that Brett suggested in the bug =
that Whitney linked to was neither the best solution, nor did it address =
all the issues. So, you should probably take a look at the latest =
LogicEditor.
"Phil Williams" <phil.williams@toadmail.com> wrote in message =
news:c5ooa7$9so$1@eclipse.org...
Thanks that did the trick. I should have searched there in the first =
place.
Phil
Whitney Sorenson wrote:=20
Phil,
See
https://bugs.eclipse.org/bugs/show_bug.cgi?id=3D46005.
"Phil Williams" <phil.williams@toadmail.com> wrote in message
news:c5oj51$26m$1@eclipse.org...
There is a bug in the LogicEditor Example (and also my editor which I
used the LogicEditor as a starting point) and I am not sure where the
bug is or how to correct it so I am hoping that someone here can offer
some insight. I am using 2.1.2. Here is the symptom.
Open a diagram (I open a 4-bit adder) in the logic editor and save it.
Then do a "Save As..." and save it under a different file name. If you
now modify (say, increment one of the LEDs) it, the editor is marked
dirty as expected. Now Save the changed diagram (the editor is not
marked dirty anymore) close the editor and open it back up. The changes
were not saved. I originally thought that this was isolated to changes
made in the outline view, but is also happens if the changes were made
directly in the diagram.
It seems that there is a handle to the old model object lying around
somewhere. You can see the handle in the outline page (or any page in a
PageView) if you set the break point appropriately. However, if I put
breakpoints in the performSaveAs() method, you will see that the model
does seem to be updated.
Any ideas on how to fix or work around this bug? I thought that somehow
the workbench's selection was not being updated (since doCreatePage() is
not being called for the newly "saved as" editor, but it seems a little
more than that since changes in the editor are not saved as well.
Your help would be greatly appreciated as always.
Thanks,
Phil
=20
------=_NextPart_000_0062_01C423B4.087ECE30
Content-Type: text/html;
charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD><TITLE></TITLE>
<META http-equiv=3DContent-Type =
content=3Dtext/html;charset=3DISO-8859-1>
<META content=3D"MSHTML 6.00.2800.1400" name=3DGENERATOR>
<STYLE></STYLE>
</HEAD>
<BODY bgColor=3D#ffffff>
<DIV><FONT face=3DArial size=3D2>The best thing to do would be =
to find an=20
example better than the LogicEditor (perhaps JDT's java editor). =
The=20
LogicEditor has not been extensively tested and I wouldn't be surprised =
if it=20
still had some bugs. Showing how to save/load your file, etc. was =
never=20
the main goal of the LogicEditor. In any case, if you didn't want =
to=20
change too many things, your best bet would be to look at the =
LogicEditor in the=20
HEAD stream and do what it does. The fix that Brett suggested in =
the bug=20
that Whitney linked to was neither the best solution, nor did it address =
all the=20
issues. So, you should probably take a look at the latest=20
LogicEditor.</FONT></DIV>
<DIV><FONT face=3DArial size=3D2></FONT> </DIV>
<BLOCKQUOTE dir=3Dltr=20
style=3D"PADDING-RIGHT: 0px; PADDING-LEFT: 5px; MARGIN-LEFT: 5px; =
BORDER-LEFT: #000000 2px solid; MARGIN-RIGHT: 0px">
<DIV>"Phil Williams" <<A=20
=
href=3D"mailto:phil.williams@toadmail.com">phil.williams@toadmail.com</A>=
>=20
wrote in message <A=20
=
href=3D"news:c5ooa7$9so$1@eclipse.org">news:c5ooa7$9so$1@eclipse.org</A>.=
...</DIV>Thanks=20
that did the trick. I should have searched there in the first=20
place.<BR><BR>Phil<BR><BR>Whitney Sorenson wrote:=20
<BLOCKQUOTE cite=3Dmidc5on8m$83o$1@eclipse.org type=3D"cite"><PRE =
wrap=3D"">Phil,
See
<A class=3Dmoz-txt-link-freetext =
href=3D"https://bugs.eclipse.org/bugs/show_bug.cgi?id=3D46005">https://bu=
gs.eclipse.org/bugs/show_bug.cgi?id=3D46005</A>.
"Phil Williams" <A class=3Dmoz-txt-link-rfc2396E =
href=3D"mailto:phil.williams@toadmail.com"><phil.williams@toadmail.com=
></A> wrote in message
<A class=3Dmoz-txt-link-freetext =
href=3D"news:c5oj51$26m$1@eclipse.org">news:c5oj51$26m$1@eclipse.org</A>.=
...
</PRE>
<BLOCKQUOTE type=3D"cite"><PRE wrap=3D"">There is a bug in the =
LogicEditor Example (and also my editor which I
used the LogicEditor as a starting point) and I am not sure where the
bug is or how to correct it so I am hoping that someone here can offer
some insight. I am using 2.1.2. Here is the symptom.
Open a diagram (I open a 4-bit adder) in the logic editor and save it.
Then do a "Save As..." and save it under a different file name. If you
now modify (say, increment one of the LEDs) it, the editor is marked
dirty as expected. Now Save the changed diagram (the editor is not
marked dirty anymore) close the editor and open it back up. The changes
were not saved. I originally thought that this was isolated to changes
made in the outline view, but is also happens if the changes were made
directly in the diagram.
It seems that there is a handle to the old model object lying around
somewhere. You can see the handle in the outline page (or any page in a
PageView) if you set the break point appropriately. However, if I put
breakpoints in the performSaveAs() method, you will see that the model
does seem to be updated.
Any ideas on how to fix or work around this bug? I thought that somehow
the workbench's selection was not being updated (since doCreatePage() is
not being called for the newly "saved as" editor, but it seems a little
more than that since changes in the editor are not saved as well.
Your help would be greatly appreciated as always.
Thanks,
Phil
</PRE></BLOCKQUOTE><PRE wrap=3D""><!---->
</PRE></BLOCKQUOTE></BLOCKQUOTE></BODY></HTML>
------=_NextPart_000_0062_01C423B4.087ECE30--
|
|
|
| Re: Bug in GEF, Eclipse Platform, or LogicEditor [message #127803 is a reply to message #127764] |
Fri, 16 April 2004 13:52 |
| Eclipse User |
|
|
|
Originally posted by: phil.williams.toadmail.com
This is a multi-part message in MIME format.
--------------080707000306040707000301
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
I will do that when I get a chance. One question though, will the fixes
that are in the latest HEAD be applicable to the 2.1.2 version of GEF or
are they dependent on 3.0Mx?
Thanks again,
Phil
Pratik Shah wrote:
> The best thing to do would be to find an example better than the
> LogicEditor (perhaps JDT's java editor). The LogicEditor has not been
> extensively tested and I wouldn't be surprised if it still had some
> bugs. Showing how to save/load your file, etc. was never the main
> goal of the LogicEditor. In any case, if you didn't want to change
> too many things, your best bet would be to look at the LogicEditor in
> the HEAD stream and do what it does. The fix that Brett suggested in
> the bug that Whitney linked to was neither the best solution, nor did
> it address all the issues. So, you should probably take a look at the
> latest LogicEditor.
>
>
> "Phil Williams" <phil.williams@toadmail.com
> <mailto:phil.williams@toadmail.com>> wrote in message
> news:c5ooa7$9so$1@eclipse.org...
> Thanks that did the trick. I should have searched there in the
> first place.
>
> Phil
>
> Whitney Sorenson wrote:
>
>>Phil,
>>
>>See
>>https://bugs.eclipse.org/bugs/show_bug.cgi?id=46005.
>>
>>"Phil Williams" <phil.williams@toadmail.com> wrote in message
>>news:c5oj51$26m$1@eclipse.org...
>>
>>
>>>There is a bug in the LogicEditor Example (and also my editor which I
>>>used the LogicEditor as a starting point) and I am not sure where the
>>>bug is or how to correct it so I am hoping that someone here can offer
>>>some insight. I am using 2.1.2. Here is the symptom.
>>>
>>>Open a diagram (I open a 4-bit adder) in the logic editor and save it.
>>>Then do a "Save As..." and save it under a different file name. If you
>>>now modify (say, increment one of the LEDs) it, the editor is marked
>>>dirty as expected. Now Save the changed diagram (the editor is not
>>>marked dirty anymore) close the editor and open it back up. The changes
>>>were not saved. I originally thought that this was isolated to changes
>>>made in the outline view, but is also happens if the changes were made
>>>directly in the diagram.
>>>
>>>It seems that there is a handle to the old model object lying around
>>>somewhere. You can see the handle in the outline page (or any page in a
>>>PageView) if you set the break point appropriately. However, if I put
>>>breakpoints in the performSaveAs() method, you will see that the model
>>>does seem to be updated.
>>>
>>>Any ideas on how to fix or work around this bug? I thought that somehow
>>>the workbench's selection was not being updated (since doCreatePage() is
>>>not being called for the newly "saved as" editor, but it seems a little
>>>more than that since changes in the editor are not saved as well.
>>>
>>>Your help would be greatly appreciated as always.
>>>
>>>Thanks,
>>>Phil
>>>
>>>
>>>
>>
>>
>>
>>
--------------080707000306040707000301
Content-Type: text/html; charset=us-ascii
Content-Transfer-Encoding: 7bit
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
<title></title>
</head>
<body>
I will do that when I get a chance. One question though, will the
fixes that are in the latest HEAD be applicable to the 2.1.2 version of
GEF or are they dependent on 3.0Mx?<br>
<br>
Thanks again,<br>
Phil<br>
<br>
<br>
Pratik Shah wrote:
<blockquote cite="midc5p3lp$qv4$1@eclipse.org" type="cite">
<title></title>
<meta http-equiv="Content-Type" content="text/html;charset=ISO-8859-1">
<meta content="MSHTML 6.00.2800.1400" name="GENERATOR">
<style></style>
<div><font face="Arial" size="2">The best thing to do would be
to find an example better than the LogicEditor (perhaps JDT's java
editor). The LogicEditor has not been extensively tested and I
wouldn't be surprised if it still had some bugs. Showing how to
save/load your file, etc. was never the main goal of the LogicEditor.
In any case, if you didn't want to change too many things, your best
bet would be to look at the LogicEditor in the HEAD stream and do what
it does. The fix that Brett suggested in the bug that Whitney linked
to was neither the best solution, nor did it address all the issues.
So, you should probably take a look at the latest LogicEditor.</font></div>
<div> </div>
<blockquote dir="ltr"
style="border-left: 2px solid rgb(0, 0, 0); padding-right: 0px; padding-left: 5px; margin-left: 5px; margin-right: 0px;">
<div>"Phil Williams" <<a href="mailto:phil.williams@toadmail.com">phil.williams@toadmail.com</a>>
wrote in message <a href="news:c5ooa7$9so$1@eclipse.org">news:c5ooa7$9so$1@eclipse.org</a>...</div>
Thanks that did the trick. I should have searched there in the first
place.<br>
<br>
Phil<br>
<br>
Whitney Sorenson wrote:
<blockquote cite="midc5on8m$83o$1@eclipse.org" type="cite">
<pre wrap="">Phil,
See
<a class="moz-txt-link-freetext"
href="https://bugs.eclipse.org/bugs/show_bug.cgi?id=46005">https://bugs.eclipse.org/bugs/show_bug.cgi?id=46005</a>.
"Phil Williams" <a class="moz-txt-link-rfc2396E"
href="mailto:phil.williams@toadmail.com"><phil.williams@toadmail.com></a> wrote in message
<a class="moz-txt-link-freetext" href="news:c5oj51$26m$1@eclipse.org">news:c5oj51$26m$1@eclipse.org</a>...
</pre>
<blockquote type="cite">
<pre wrap="">There is a bug in the LogicEditor Example (and also my editor which I
used the LogicEditor as a starting point) and I am not sure where the
bug is or how to correct it so I am hoping that someone here can offer
some insight. I am using 2.1.2. Here is the symptom.
Open a diagram (I open a 4-bit adder) in the logic editor and save it.
Then do a "Save As..." and save it under a different file name. If you
now modify (say, increment one of the LEDs) it, the editor is marked
dirty as expected. Now Save the changed diagram (the editor is not
marked dirty anymore) close the editor and open it back up. The changes
were not saved. I originally thought that this was isolated to changes
made in the outline view, but is also happens if the changes were made
directly in the diagram.
It seems that there is a handle to the old model object lying around
somewhere. You can see the handle in the outline page (or any page in a
PageView) if you set the break point appropriately. However, if I put
breakpoints in the performSaveAs() method, you will see that the model
does seem to be updated.
Any ideas on how to fix or work around this bug? I thought that somehow
the workbench's selection was not being updated (since doCreatePage() is
not being called for the newly "saved as" editor, but it seems a little
more than that since changes in the editor are not saved as well.
Your help would be greatly appreciated as always.
Thanks,
Phil
</pre>
</blockquote>
<pre wrap=""><!---->
</pre>
</blockquote>
</blockquote>
</blockquote>
</body>
</html>
--------------080707000306040707000301--
|
|
|
| Re: Bug in GEF, Eclipse Platform, or LogicEditor [message #127830 is a reply to message #127803] |
Fri, 16 April 2004 16:03 |
| Eclipse User |
|
|
|
This is a multi-part message in MIME format.
------=_NextPart_000_00B4_01C423C3.F17CA850
Content-Type: text/plain;
charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
I don't think we are using any new API that was introduced in 3.0, so it =
should work. However, there's only one way to be sure......
Once you've patched your editor, let us know how it went.
"Phil Williams" <phil.williams@toadmail.com> wrote in message =
news:c5p65j$tpr$1@eclipse.org...
I will do that when I get a chance. One question though, will the =
fixes that are in the latest HEAD be applicable to the 2.1.2 version of =
GEF or are they dependent on 3.0Mx?
Thanks again,
Phil
Pratik Shah wrote:=20
The best thing to do would be to find an example better than the =
LogicEditor (perhaps JDT's java editor). The LogicEditor has not been =
extensively tested and I wouldn't be surprised if it still had some =
bugs. Showing how to save/load your file, etc. was never the main goal =
of the LogicEditor. In any case, if you didn't want to change too many =
things, your best bet would be to look at the LogicEditor in the HEAD =
stream and do what it does. The fix that Brett suggested in the bug =
that Whitney linked to was neither the best solution, nor did it address =
all the issues. So, you should probably take a look at the latest =
LogicEditor.
"Phil Williams" <phil.williams@toadmail.com> wrote in message =
news:c5ooa7$9so$1@eclipse.org...
Thanks that did the trick. I should have searched there in the =
first place.
Phil
Whitney Sorenson wrote:=20
Phil,
See
https://bugs.eclipse.org/bugs/show_bug.cgi?id=3D46005.
"Phil Williams" <phil.williams@toadmail.com> wrote in message
news:c5oj51$26m$1@eclipse.org...
There is a bug in the LogicEditor Example (and also my editor which I
used the LogicEditor as a starting point) and I am not sure where the
bug is or how to correct it so I am hoping that someone here can offer
some insight. I am using 2.1.2. Here is the symptom.
Open a diagram (I open a 4-bit adder) in the logic editor and save it.
Then do a "Save As..." and save it under a different file name. If you
now modify (say, increment one of the LEDs) it, the editor is marked
dirty as expected. Now Save the changed diagram (the editor is not
marked dirty anymore) close the editor and open it back up. The changes
were not saved. I originally thought that this was isolated to changes
made in the outline view, but is also happens if the changes were made
directly in the diagram.
It seems that there is a handle to the old model object lying around
somewhere. You can see the handle in the outline page (or any page in a
PageView) if you set the break point appropriately. However, if I put
breakpoints in the performSaveAs() method, you will see that the model
does seem to be updated.
Any ideas on how to fix or work around this bug? I thought that somehow
the workbench's selection was not being updated (since doCreatePage() is
not being called for the newly "saved as" editor, but it seems a little
more than that since changes in the editor are not saved as well.
Your help would be greatly appreciated as always.
Thanks,
Phil
=20
------=_NextPart_000_00B4_01C423C3.F17CA850
Content-Type: text/html;
charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD><TITLE></TITLE>
<META http-equiv=3DContent-Type =
content=3Dtext/html;charset=3DISO-8859-1>
<META content=3D"MSHTML 6.00.2800.1400" name=3DGENERATOR></HEAD>
<BODY bgColor=3D#ffffff>
<DIV><FONT face=3DArial size=3D2>I don't think we are using any new API =
that was=20
introduced in 3.0, so it should work. However, there's only one =
way to be=20
sure......</FONT></DIV>
<DIV><FONT face=3DArial size=3D2></FONT> </DIV>
<DIV><FONT face=3DArial size=3D2>Once you've patched your editor, let us =
know how it=20
went.</FONT></DIV>
<DIV><FONT face=3DArial size=3D2></FONT> </DIV>
<DIV><FONT face=3DArial size=3D2></FONT> </DIV>
<DIV>"Phil Williams" <<A=20
href=3D"mailto:phil.williams@toadmail.com">phil.williams@toadmail.com</A>=
>=20
wrote in message <A=20
href=3D"news:c5p65j$tpr$1@eclipse.org">news:c5p65j$tpr$1@eclipse.org</A>.=
...</DIV>
<BLOCKQUOTE dir=3Dltr=20
style=3D"PADDING-RIGHT: 0px; PADDING-LEFT: 5px; MARGIN-LEFT: 5px; =
BORDER-LEFT: #000000 2px solid; MARGIN-RIGHT: 0px">I=20
will do that when I get a chance. One question though, will the =
fixes=20
that are in the latest HEAD be applicable to the 2.1.2 version of GEF =
or are=20
they dependent on 3.0Mx?<BR><BR>Thanks =
again,<BR>Phil<BR><BR><BR>Pratik Shah=20
wrote:=20
<BLOCKQUOTE cite=3Dmidc5p3lp$qv4$1@eclipse.org type=3D"cite">
<META content=3D"MSHTML 6.00.2800.1400" name=3DGENERATOR>
<STYLE></STYLE>
<DIV><FONT face=3DArial size=3D2>The best thing to do would be =
to find=20
an example better than the LogicEditor (perhaps JDT's java =
editor). =20
The LogicEditor has not been extensively tested and I wouldn't be =
surprised=20
if it still had some bugs. Showing how to save/load your file, =
etc.=20
was never the main goal of the LogicEditor. In any case, if =
you didn't=20
want to change too many things, your best bet would be to look at =
the=20
LogicEditor in the HEAD stream and do what it does. The fix =
that Brett=20
suggested in the bug that Whitney linked to was neither the best =
solution,=20
nor did it address all the issues. So, you should probably =
take a look=20
at the latest LogicEditor.</FONT></DIV>
<DIV> </DIV>
<BLOCKQUOTE dir=3Dltr=20
style=3D"PADDING-RIGHT: 0px; PADDING-LEFT: 5px; MARGIN-LEFT: 5px; =
BORDER-LEFT: rgb(0,0,0) 2px solid; MARGIN-RIGHT: 0px">
<DIV>"Phil Williams" <<A=20
=
href=3D"mailto:phil.williams@toadmail.com">phil.williams@toadmail.com</A>=
>=20
wrote in message <A=20
=
href=3D"news:c5ooa7$9so$1@eclipse.org">news:c5ooa7$9so$1@eclipse.org</A>.=
...</DIV>Thanks=20
that did the trick. I should have searched there in the =
first=20
place.<BR><BR>Phil<BR><BR>Whitney Sorenson wrote:=20
<BLOCKQUOTE cite=3Dmidc5on8m$83o$1@eclipse.org type=3D"cite"><PRE =
wrap=3D"">Phil,
See
<A class=3Dmoz-txt-link-freetext =
href=3D"https://bugs.eclipse.org/bugs/show_bug.cgi?id=3D46005">https://bu=
gs.eclipse.org/bugs/show_bug.cgi?id=3D46005</A>.
"Phil Williams" <A class=3Dmoz-txt-link-rfc2396E =
href=3D"mailto:phil.williams@toadmail.com"><phil.williams@toadmail.com=
></A> wrote in message
<A class=3Dmoz-txt-link-freetext =
href=3D"news:c5oj51$26m$1@eclipse.org">news:c5oj51$26m$1@eclipse.org</A>.=
...
</PRE>
<BLOCKQUOTE type=3D"cite"><PRE wrap=3D"">There is a bug in the =
LogicEditor Example (and also my editor which I
used the LogicEditor as a starting point) and I am not sure where the
bug is or how to correct it so I am hoping that someone here can offer
some insight. I am using 2.1.2. Here is the symptom.
Open a diagram (I open a 4-bit adder) in the logic editor and save it.
Then do a "Save As..." and save it under a different file name. If you
now modify (say, increment one of the LEDs) it, the editor is marked
dirty as expected. Now Save the changed diagram (the editor is not
marked dirty anymore) close the editor and open it back up. The changes
were not saved. I originally thought that this was isolated to changes
made in the outline view, but is also happens if the changes were made
directly in the diagram.
It seems that there is a handle to the old model object lying around
somewhere. You can see the handle in the outline page (or any page in a
PageView) if you set the break point appropriately. However, if I put
breakpoints in the performSaveAs() method, you will see that the model
does seem to be updated.
Any ideas on how to fix or work around this bug? I thought that somehow
the workbench's selection was not being updated (since doCreatePage() is
not being called for the newly "saved as" editor, but it seems a little
more than that since changes in the editor are not saved as well.
Your help would be greatly appreciated as always.
Thanks,
Phil
</PRE></BLOCKQUOTE><PRE wrap=3D""><!---->
=
</PRE></BLOCKQUOTE></BLOCKQUOTE></BLOCKQUOTE></BLOCKQUOTE ></BODY></HTML>
------=_NextPart_000_00B4_01C423C3.F17CA850--
|
|
|
| Re: Bug in GEF, Eclipse Platform, or LogicEditor [message #127857 is a reply to message #127830] |
Sat, 17 April 2004 09:50 |
| Eclipse User |
|
|
|
Originally posted by: phil.williams.toadmail.com
This is a multi-part message in MIME format.
--------------060509020002030406000701
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
I patched the my editor with the code from CVS. However, in the
discussion of the bug it is mentioned that there should be a call to
getGraphicalViewer().setContents(diagram);
that is missing from the code in CVS. Without this, the model in the
graphical viewer is not updated properly. Am I missing something or
should there still a bug in performSaveAs?
Thanks,
Phil
Pratik Shah wrote:
> I don't think we are using any new API that was introduced in 3.0, so
> it should work. However, there's only one way to be sure......
>
> Once you've patched your editor, let us know how it went.
>
>
> "Phil Williams" <phil.williams@toadmail.com
> <mailto:phil.williams@toadmail.com>> wrote in message
> news:c5p65j$tpr$1@eclipse.org...
>
> I will do that when I get a chance. One question though, will the
> fixes that are in the latest HEAD be applicable to the 2.1.2
> version of GEF or are they dependent on 3.0Mx?
>
> Thanks again,
> Phil
>
>
> Pratik Shah wrote:
>
>> The best thing to do would be to find an example better than the
>> LogicEditor (perhaps JDT's java editor). The LogicEditor has not
>> been extensively tested and I wouldn't be surprised if it still
>> had some bugs. Showing how to save/load your file, etc. was
>> never the main goal of the LogicEditor. In any case, if you
>> didn't want to change too many things, your best bet would be to
>> look at the LogicEditor in the HEAD stream and do what it does.
>> The fix that Brett suggested in the bug that Whitney linked to
>> was neither the best solution, nor did it address all the
>> issues. So, you should probably take a look at the latest
>> LogicEditor.
>>
>>
>> "Phil Williams" <phil.williams@toadmail.com
>> <mailto:phil.williams@toadmail.com>> wrote in message
>> news:c5ooa7$9so$1@eclipse.org...
>> Thanks that did the trick. I should have searched there in
>> the first place.
>>
>> Phil
>>
>> Whitney Sorenson wrote:
>>
>>>Phil,
>>>
>>>See
>>>https://bugs.eclipse.org/bugs/show_bug.cgi?id=46005.
>>>
>>>"Phil Williams" <phil.williams@toadmail.com> wrote in message
>>>news:c5oj51$26m$1@eclipse.org...
>>>
>>>
>>>>There is a bug in the LogicEditor Example (and also my editor which I
>>>>used the LogicEditor as a starting point) and I am not sure where the
>>>>bug is or how to correct it so I am hoping that someone here can offer
>>>>some insight. I am using 2.1.2. Here is the symptom.
>>>>
>>>>Open a diagram (I open a 4-bit adder) in the logic editor and save it.
>>>>Then do a "Save As..." and save it under a different file name. If you
>>>>now modify (say, increment one of the LEDs) it, the editor is marked
>>>>dirty as expected. Now Save the changed diagram (the editor is not
>>>>marked dirty anymore) close the editor and open it back up. The changes
>>>>were not saved. I originally thought that this was isolated to changes
>>>>made in the outline view, but is also happens if the changes were made
>>>>directly in the diagram.
>>>>
>>>>It seems that there is a handle to the old model object lying around
>>>>somewhere. You can see the handle in the outline page (or any page in a
>>>>PageView) if you set the break point appropriately. However, if I put
>>>>breakpoints in the performSaveAs() method, you will see that the model
>>>>does seem to be updated.
>>>>
>>>>Any ideas on how to fix or work around this bug? I thought that somehow
>>>>the workbench's selection was not being updated (since doCreatePage() is
>>>>not being called for the newly "saved as" editor, but it seems a little
>>>>more than that since changes in the editor are not saved as well.
>>>>
>>>>Your help would be greatly appreciated as always.
>>>>
>>>>Thanks,
>>>>Phil
>>>>
>>>>
>>>>
>>>
>>>
>>>
>>>
--------------060509020002030406000701
Content-Type: text/html; charset=us-ascii
Content-Transfer-Encoding: 7bit
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
<title></title>
</head>
<body>
I patched the my editor with the code from CVS. However, in the
discussion of the bug it is mentioned that there should be a call to <br>
<br>
getGraphicalViewer().setContents(diagram);<br>
<br>
that is missing from the code in CVS. Without this, the model in the
graphical viewer is not updated properly. Am I missing something or
should there still a bug in performSaveAs?<br>
<br>
Thanks,<br>
Phil<br>
<br>
<br>
Pratik Shah wrote:<br>
<blockquote cite="midc5pabb$3k6$1@eclipse.org" type="cite">
<title></title>
<meta http-equiv="Content-Type" content="text/html;charset=ISO-8859-1">
<meta content="MSHTML 6.00.2800.1400" name="GENERATOR">
<div><font face="Arial" size="2">I don't think we are using any new
API that was introduced in 3.0, so it should work. However, there's
only one way to be sure......</font></div>
<div> </div>
<div><font face="Arial" size="2">Once you've patched your editor, let
us know how it went.</font></div>
<div> </div>
<div> </div>
<div>"Phil Williams" <<a href="mailto:phil.williams@toadmail.com">phil.williams@toadmail.com</a>>
wrote in message <a href="news:c5p65j$tpr$1@eclipse.org">news:c5p65j$tpr$1@eclipse.org</a>...</div>
<blockquote dir="ltr"
style="border-left: 2px solid rgb(0, 0, 0); padding-right: 0px; padding-left: 5px; margin-left: 5px; margin-right: 0px;">I
will do that when I get a chance. One question though, will the fixes
that are in the latest HEAD be applicable to the 2.1.2 version of GEF
or are they dependent on 3.0Mx?<br>
<br>
Thanks again,<br>
Phil<br>
<br>
<br>
Pratik Shah wrote:
<blockquote cite="midc5p3lp$qv4$1@eclipse.org" type="cite">
<meta content="MSHTML 6.00.2800.1400" name="GENERATOR">
<style></style>
<div><font face="Arial" size="2">The best thing to do would be
to find an example better than the LogicEditor (perhaps JDT's java
editor). The LogicEditor has not been extensively tested and I
wouldn't be surprised if it still had some bugs. Showing how to
save/load your file, etc. was never the main goal of the LogicEditor.
In any case, if you didn't want to change too many things, your best
bet would be to look at the LogicEditor in the HEAD stream and do what
it does. The fix that Brett suggested in the bug that Whitney linked
to was neither the best solution, nor did it address all the issues.
So, you should probably take a look at the latest LogicEditor.</font></div>
<div> </div>
<blockquote dir="ltr"
style="border-left: 2px solid rgb(0, 0, 0); padding-right: 0px; padding-left: 5px; margin-left: 5px; margin-right: 0px;">
<div>"Phil Williams" <<a
href="mailto:phil.williams@toadmail.com">phil.williams@toadmail.com</a>>
wrote in message <a href="news:c5ooa7$9so$1@eclipse.org">news:c5ooa7$9so$1@eclipse.org</a>...</div>
Thanks that did the trick. I should have searched there in the first
place.<br>
<br>
Phil<br>
<br>
Whitney Sorenson wrote:
<blockquote cite="midc5on8m$83o$1@eclipse.org" type="cite">
<pre wrap="">Phil,
See
<a class="moz-txt-link-freetext"
href="https://bugs.eclipse.org/bugs/show_bug.cgi?id=46005">https://bugs.eclipse.org/bugs/show_bug.cgi?id=46005</a>.
"Phil Williams" <a class="moz-txt-link-rfc2396E"
href="mailto:phil.williams@toadmail.com"><phil.williams@toadmail.com></a> wrote in message
<a class="moz-txt-link-freetext" href="news:c5oj51$26m$1@eclipse.org">news:c5oj51$26m$1@eclipse.org</a>...
</pre>
<blockquote type="cite">
<pre wrap="">There is a bug in the LogicEditor Example (and also my editor which I
used the LogicEditor as a starting point) and I am not sure where the
bug is or how to correct it so I am hoping that someone here can offer
some insight. I am using 2.1.2. Here is the symptom.
Open a diagram (I open a 4-bit adder) in the logic editor and save it.
Then do a "Save As..." and save it under a different file name. If you
now modify (say, increment one of the LEDs) it, the editor is marked
dirty as expected. Now Save the changed diagram (the editor is not
marked dirty anymore) close the editor and open it back up. The changes
were not saved. I originally thought that this was isolated to changes
made in the outline view, but is also happens if the changes were made
directly in the diagram.
It seems that there is a handle to the old model object lying around
somewhere. You can see the handle in the outline page (or any page in a
PageView) if you set the break point appropriately. However, if I put
breakpoints in the performSaveAs() method, you will see that the model
does seem to be updated.
Any ideas on how to fix or work around this bug? I thought that somehow
the workbench's selection was not being updated (since doCreatePage() is
not being called for the newly "saved as" editor, but it seems a little
more than that since changes in the editor are not saved as well.
Your help would be greatly appreciated as always.
Thanks,
Phil
</pre>
</blockquote>
<pre wrap=""><!---->
</pre>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
</body>
</html>
--------------060509020002030406000701--
|
|
|
| Re: Bug in GEF, Eclipse Platform, or LogicEditor [message #127943 is a reply to message #127857] |
Mon, 19 April 2004 12:22 |
| Eclipse User |
|
|
|
This is a multi-part message in MIME format.
------=_NextPart_000_0029_01C42600.A5988C30
Content-Type: text/plain;
charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
That is being done in the setInput(...) method. A look at the =
repository tells me that the following methods/classes were updated for =
this fix:
doSave
performSaveAs
setInput
ResourceTracker
Make sure you have updated all of those.
"Phil Williams" <phil.williams@toadmail.com> wrote in message =
news:c5rccr$1em$1@eclipse.org...
I patched the my editor with the code from CVS. However, in the =
discussion of the bug it is mentioned that there should be a call to=20
getGraphicalViewer().setContents(diagram);
that is missing from the code in CVS. Without this, the model in the =
graphical viewer is not updated properly. Am I missing something or =
should there still a bug in performSaveAs?
Thanks,
Phil
Pratik Shah wrote:
I don't think we are using any new API that was introduced in 3.0, =
so it should work. However, there's only one way to be sure......
Once you've patched your editor, let us know how it went.
"Phil Williams" <phil.williams@toadmail.com> wrote in message =
news:c5p65j$tpr$1@eclipse.org...
I will do that when I get a chance. One question though, will the =
fixes that are in the latest HEAD be applicable to the 2.1.2 version of =
GEF or are they dependent on 3.0Mx?
Thanks again,
Phil
Pratik Shah wrote:=20
The best thing to do would be to find an example better than the =
LogicEditor (perhaps JDT's java editor). The LogicEditor has not been =
extensively tested and I wouldn't be surprised if it still had some =
bugs. Showing how to save/load your file, etc. was never the main goal =
of the LogicEditor. In any case, if you didn't want to change too many =
things, your best bet would be to look at the LogicEditor in the HEAD =
stream and do what it does. The fix that Brett suggested in the bug =
that Whitney linked to was neither the best solution, nor did it address =
all the issues. So, you should probably take a look at the latest =
LogicEditor.
"Phil Williams" <phil.williams@toadmail.com> wrote in message =
news:c5ooa7$9so$1@eclipse.org...
Thanks that did the trick. I should have searched there in =
the first place.
Phil
Whitney Sorenson wrote:=20
Phil,
See
https://bugs.eclipse.org/bugs/show_bug.cgi?id=3D46005.
"Phil Williams" <phil.williams@toadmail.com> wrote in message
news:c5oj51$26m$1@eclipse.org...
There is a bug in the LogicEditor Example (and also my editor which I
used the LogicEditor as a starting point) and I am not sure where the
bug is or how to correct it so I am hoping that someone here can offer
some insight. I am using 2.1.2. Here is the symptom.
Open a diagram (I open a 4-bit adder) in the logic editor and save it.
Then do a "Save As..." and save it under a different file name. If you
now modify (say, increment one of the LEDs) it, the editor is marked
dirty as expected. Now Save the changed diagram (the editor is not
marked dirty anymore) close the editor and open it back up. The changes
were not saved. I originally thought that this was isolated to changes
made in the outline view, but is also happens if the changes were made
directly in the diagram.
It seems that there is a handle to the old model object lying around
somewhere. You can see the handle in the outline page (or any page in a
PageView) if you set the break point appropriately. However, if I put
breakpoints in the performSaveAs() method, you will see that the model
does seem to be updated.
Any ideas on how to fix or work around this bug? I thought that somehow
the workbench's selection was not being updated (since doCreatePage() is
not being called for the newly "saved as" editor, but it seems a little
more than that since changes in the editor are not saved as well.
Your help would be greatly appreciated as always.
Thanks,
Phil
=20
------=_NextPart_000_0029_01C42600.A5988C30
Content-Type: text/html;
charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD><TITLE></TITLE>
<META http-equiv=3DContent-Type =
content=3Dtext/html;charset=3DISO-8859-1>
<META content=3D"MSHTML 6.00.2800.1400" name=3DGENERATOR></HEAD>
<BODY bgColor=3D#ffffff>
<DIV><FONT face=3DArial size=3D2>That is being done in the setInput(...) =
method. A look at the repository tells me that the following=20
methods/classes were updated for this fix:</FONT></DIV>
<DIV><FONT face=3DArial size=3D2></FONT> </DIV>
<DIV><FONT face=3DArial size=3D2>doSave</FONT></DIV>
<DIV><FONT face=3DArial size=3D2>performSaveAs</FONT></DIV>
<DIV><FONT face=3DArial size=3D2>setInput</FONT></DIV>
<DIV><FONT face=3DArial size=3D2>ResourceTracker</FONT></DIV>
<DIV><FONT face=3DArial size=3D2></FONT> </DIV>
<DIV><FONT face=3DArial size=3D2>Make sure you have updated all of=20
those.</FONT></DIV>
<DIV><FONT face=3DArial size=3D2></FONT> </DIV>
<BLOCKQUOTE dir=3Dltr=20
style=3D"PADDING-RIGHT: 0px; PADDING-LEFT: 5px; MARGIN-LEFT: 5px; =
BORDER-LEFT: #000000 2px solid; MARGIN-RIGHT: 0px">
<DIV>"Phil Williams" <<A=20
=
href=3D"mailto:phil.williams@toadmail.com">phil.williams@toadmail.com</A>=
>=20
wrote in message <A=20
=
href=3D"news:c5rccr$1em$1@eclipse.org">news:c5rccr$1em$1@eclipse.org</A>.=
...</DIV>I=20
patched the my editor with the code from CVS. However, in the =
discussion=20
of the bug it is mentioned that there should be a call to=20
<BR><BR> =20
getGraphicalViewer().setContents(diagram);<BR><BR>that is missing from =
the=20
code in CVS. Without this, the model in the graphical viewer is =
not=20
updated properly. Am I missing something or should there still a =
bug in=20
performSaveAs?<BR><BR>Thanks,<BR>Phil<BR><BR><BR>Pratik Shah =
wrote:<BR>
<BLOCKQUOTE cite=3Dmidc5pabb$3k6$1@eclipse.org type=3D"cite">
<META content=3D"MSHTML 6.00.2800.1400" name=3DGENERATOR>
<DIV><FONT face=3DArial size=3D2>I don't think we are using any new =
API that was=20
introduced in 3.0, so it should work. However, there's only =
one way to=20
be sure......</FONT></DIV>
<DIV> </DIV>
<DIV><FONT face=3DArial size=3D2>Once you've patched your editor, =
let us know=20
how it went.</FONT></DIV>
<DIV> </DIV>
<DIV> </DIV>
<DIV>"Phil Williams" <<A=20
=
href=3D"mailto:phil.williams@toadmail.com">phil.williams@toadmail.com</A>=
>=20
wrote in message <A=20
=
href=3D"news:c5p65j$tpr$1@eclipse.org">news:c5p65j$tpr$1@eclipse.org</A>.=
...</DIV>
<BLOCKQUOTE dir=3Dltr=20
style=3D"PADDING-RIGHT: 0px; PADDING-LEFT: 5px; MARGIN-LEFT: 5px; =
BORDER-LEFT: rgb(0,0,0) 2px solid; MARGIN-RIGHT: 0px">I=20
will do that when I get a chance. One question though, will =
the=20
fixes that are in the latest HEAD be applicable to the 2.1.2 =
version of=20
GEF or are they dependent on 3.0Mx?<BR><BR>Thanks=20
again,<BR>Phil<BR><BR><BR>Pratik Shah wrote:=20
<BLOCKQUOTE cite=3Dmidc5p3lp$qv4$1@eclipse.org type=3D"cite">
<META content=3D"MSHTML 6.00.2800.1400" name=3DGENERATOR>
<STYLE></STYLE>
<DIV><FONT face=3DArial size=3D2>The best thing to do would =
be=20
to find an example better than the LogicEditor (perhaps =
JDT's java=20
editor). The LogicEditor has not been extensively tested =
and I=20
wouldn't be surprised if it still had some bugs. Showing =
how to=20
save/load your file, etc. was never the main goal of the=20
LogicEditor. In any case, if you didn't want to change too =
many=20
things, your best bet would be to look at the LogicEditor in the =
HEAD=20
stream and do what it does. The fix that Brett suggested =
in the=20
bug that Whitney linked to was neither the best solution, nor =
did it=20
address all the issues. So, you should probably take a =
look at the=20
latest LogicEditor.</FONT></DIV>
<DIV> </DIV>
<BLOCKQUOTE dir=3Dltr=20
style=3D"PADDING-RIGHT: 0px; PADDING-LEFT: 5px; MARGIN-LEFT: =
5px; BORDER-LEFT: rgb(0,0,0) 2px solid; MARGIN-RIGHT: 0px">
<DIV>"Phil Williams" <<A=20
=
href=3D"mailto:phil.williams@toadmail.com">phil.williams@toadmail.com</A>=
>=20
wrote in message <A=20
=
href=3D"news:c5ooa7$9so$1@eclipse.org">news:c5ooa7$9so$1@eclipse.org</A>.=
...</DIV>Thanks=20
that did the trick. I should have searched there in the =
first=20
place.<BR><BR>Phil<BR><BR>Whitney Sorenson wrote:=20
<BLOCKQUOTE cite=3Dmidc5on8m$83o$1@eclipse.org =
type=3D"cite"><PRE wrap=3D"">Phil,
See
<A class=3Dmoz-txt-link-freetext =
href=3D"https://bugs.eclipse.org/bugs/show_bug.cgi?id=3D46005">https://bu=
gs.eclipse.org/bugs/show_bug.cgi?id=3D46005</A>.
"Phil Williams" <A class=3Dmoz-txt-link-rfc2396E =
href=3D"mailto:phil.williams@toadmail.com"><phil.williams@toadmail.com=
></A> wrote in message
<A class=3Dmoz-txt-link-freetext =
href=3D"news:c5oj51$26m$1@eclipse.org">news:c5oj51$26m$1@eclipse.org</A>.=
...
</PRE>
<BLOCKQUOTE type=3D"cite"><PRE wrap=3D"">There is a bug in =
the LogicEditor Example (and also my editor which I
used the LogicEditor as a starting point) and I am not sure where the
bug is or how to correct it so I am hoping that someone here can offer
some insight. I am using 2.1.2. Here is the symptom.
Open a diagram (I open a 4-bit adder) in the logic editor and save it.
Then do a "Save As..." and save it under a different file name. If you
now modify (say, increment one of the LEDs) it, the editor is marked
dirty as expected. Now Save the changed diagram (the editor is not
marked dirty anymore) close the editor and open it back up. The changes
were not saved. I originally thought that this was isolated to changes
made in the outline view, but is also happens if the changes were made
directly in the diagram.
It seems that there is a handle to the old model object lying around
somewhere. You can see the handle in the outline page (or any page in a
PageView) if you set the break point appropriately. However, if I put
breakpoints in the performSaveAs() method, you will see that the model
does seem to be updated.
Any ideas on how to fix or work around this bug? I thought that somehow
the workbench's selection was not being updated (since doCreatePage() is
not being called for the newly "saved as" editor, but it seems a little
more than that since changes in the editor are not saved as well.
Your help would be greatly appreciated as always.
Thanks,
Phil
</PRE></BLOCKQUOTE><PRE wrap=3D""><!---->
=
</PRE></BLOCKQUOTE></BLOCKQUOTE></BLOCKQUOTE></BLOCKQUOTE ></BLOCKQUOTE></=
BLOCKQUOTE></BODY></HTML>
------=_NextPart_000_0029_01C42600.A5988C30--
|
|
|
Goto Forum:
Current Time: Tue Jul 22 14:03:08 EDT 2025
Powered by FUDForum. Page generated in 0.25194 seconds |
Home