Eclipse Community Forums: Graphiti » Enable injecting behavior objects in DiagramBehavior

Home » Modeling » Graphiti » Enable injecting behavior objects in DiagramBehavior

Enable injecting behavior objects in DiagramBehavior [message #1018920]

Thu, 14 March 2013 13:32

Eclipse User

Hi,

I just cloned the graphiti git repository to (locally) fix the problem I
reported concerning DoubleClickContext. A lot of errors popped up
concerning the switch to DiagramBehavior, which were easy to fix. Thank
you for this new feature and the explanation of how to update the code.

However, I also noticed that the various behavior objects for
persistency, update etc. were created in DiagramBehavior's constructor.
As discussed in https://bugs.eclipse.org/bugs/show_bug.cgi?id=394315,
this makes it difficult to @Inject these objects, since they are created
before the injector has a chance to provide them. This was fixed for
DiagramEditor, according to the bug, and should also be fixed in
DiagramBehavior, IMO.

Hallvard

Re: Enable injecting behavior objects in DiagramBehavior [message #1019370 is a reply to message #1018920]

Fri, 15 March 2013 10:59

Eclipse User

That bug's solution is currently awating review in gerrit, it'll be modified to preserve the functionality in the new structure

Re: Enable injecting behavior objects in DiagramBehavior [message #1020608 is a reply to message #1019370]

Mon, 18 March 2013 10:56

Eclipse User

I have merged that change today, it is now part of the master branch.

Michael

Previous Topic:	Why graphiti is better than GEF
Next Topic:	Loading an existing model to a Graphiti Editor

Goto Forum:

-=] Back to Top [=-

Current Time: Thu Jul 24 17:21:34 EDT 2025

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter