Eclipse Community Forums: Oomph » State of tests, build and gerrit

Help

Home

Home » Eclipse Projects » Oomph » State of tests, build and gerrit

Show: Today's Messages :: Show Polls :: Message Navigator

State of tests, build and gerrit [message #1587846]

Tue, 27 January 2015 15:49

Christian Schneider

Messages: 3
Registered: January 2015

Junior Member

Hi,

I was wondering what the state of the oomph build is regarding tests. When running mvn package on master or on 1.0.0 there are several failing tests. On the build server the tests are skipped completely. Additionally gerrit is not configured to use automatic builds for voting.

For the extended caching [1] I've written a new test. Which I would obviously like to run with maven Smile

So what is the plan with the tests? Should the failing tests be disabled? What do you think about using the build for voting in gerrit?

Regards,
Christian

[1] bugs.eclipse.org/bugs/show_bug.cgi?id=458225

Report message to a moderator

Re: State of tests, build and gerrit [message #1589050 is a reply to message #1587846]

Wed, 28 January 2015 07:51

Eike Stepper

Messages: 6692
Registered: July 2009

Senior Member

Am 27.01.2015 um 19:28 schrieb Christian Schneider:
> Hi,
>
> I was wondering what the state of the oomph build is regarding tests. When running mvn package on master or on 1.0.0
> there are several failing tests. On the build server the tests are skipped completely. Additionally gerrit is not
> configured to use automatic builds for voting.
>
> For the extended caching [1] I've written a new test. Which I would obviously like to run with maven :)
>
> So what is the plan with the tests?
I anted to investigate how that's done with Maven. If you know it, can you contribute a patch for our pom.xml?

> Should the failing tests be disabled?
I guess I should see why they're failing and either fix or remove them.

> What do you think about using the build for voting in gerrit?
I was scared by the discussion about code injection into the automatically executed Gerrit tests (can't find the link
right now) and wanted to wait and see where it goes.

Cheers
/Eike

----
http://www.esc-net.de
http://thegordian.blogspot.com
http://twitter.com/eikestepper

Cheers
/Eike

----
http://www.esc-net.de
http://thegordian.blogspot.com
http://twitter.com/eikestepper

Report message to a moderator

Re: State of tests, build and gerrit [message #1599019 is a reply to message #1589050]

Tue, 03 February 2015 10:15

Christian Schneider

Messages: 3
Registered: January 2015

Junior Member

Uh, when posting a new topic I'm not subscribed to it... sorry for the late reply.

> I anted to investigate how that's done with Maven. If you know it, can you contribute a patch for our pom.xml?
Well, the tests are run by maven. So no patch to the pom is required. It just stops executing tests as soon as it encounters a failing test. Thus all test have to be successful to properly work with maven (and an automatic build voting in general).

>> Should the failing tests be disabled?
> I guess I should see why they're failing and either fix or remove them.
Ok, should I go with disabling them and mark them as //TODO in the code in the meanwhile?

> I was scared by the discussion about code injection into the automatically > executed Gerrit tests (can't find the link
> right now) and wanted to wait and see where it goes.
I see. But as other projects still use it, it should not impose much of an additional risk, should it?

Regards
Christian

Report message to a moderator