Problems with EASE's SelectionModule & missing extensions [message #1520283] |
Sat, 20 December 2014 23:51  |
Eclipse User |
|
|
|
I noticed a mismatch between the registration of the modeling selector extensions and the code in the selector service that looks up these extensions.
There are 2 selection extensions in org.eclipse.ease.modules.modeling:
<extension
point="org.eclipse.ease.modules.modeling.selector">
<selector
id="GMFSemanticSeletor"
impl="org.eclipse.ease.modules.modeling.selector.GMFSemanticSeletor"
priority="50">
</selector>
<selector
id="GMFNotationSelector"
impl="org.eclipse.ease.modules.modeling.selector.GMFNotationSelector"
priority="45">
</selector>
</extension>
The SelectorService is looking up the extension with the wrong ID and wrong name.
I also noticed that there are several EASE modules that are not included in the plugin.xml extensions.
I propose the following fixes:
diff --git a/plugins/org.eclipse.ease.modules.modeling/plugin.xml b/plugins/org.eclipse.ease.modules.modeling/plugin.xml
index 0b24c38..7dcc79c 100644
--- a/plugins/org.eclipse.ease.modules.modeling/plugin.xml
+++ b/plugins/org.eclipse.ease.modules.modeling/plugin.xml
@@ -23,6 +23,36 @@
</category>
<module
category="org.eclipse.ease.modules.category.modeling"
+ class="org.eclipse.ease.modules.modeling.DialogModule"
+ id="org.eclipse.ease.modules.modeling.ecore"
+ name="DialogModule"
+ visible="true">
+ <dependency
+ module="org.eclipse.ease.module.platform.ui">
+ </dependency>
+ </module>
+ <module
+ category="org.eclipse.ease.modules.category.modeling"
+ class="org.eclipse.ease.modules.modeling.SelectionModule"
+ id="org.eclipse.ease.modules.modeling.ecore"
+ name="SelectionModule"
+ visible="true">
+ <dependency
+ module="org.eclipse.ease.module.platform.ui">
+ </dependency>
+ </module>
+ <module
+ category="org.eclipse.ease.modules.category.modeling"
+ class="org.eclipse.ease.modules.modeling.WorkbenchModule"
+ id="org.eclipse.ease.modules.modeling.ecore"
+ name="WorkbenchModule"
+ visible="true">
+ <dependency
+ module="org.eclipse.ease.module.platform.ui">
+ </dependency>
+ </module>
+ <module
+ category="org.eclipse.ease.modules.category.modeling"
class="org.eclipse.ease.modules.modeling.EcoreModule"
id="org.eclipse.ease.modules.modeling.ecore"
name="ECore"
diff --git a/plugins/org.eclipse.ease.modules.modeling/src/org/eclipse/ease/modules/modeling/SelectorService.java b/plugins/org.eclipse.ease.modules.modeling/src/org/eclipse/ease/modules/modeling/SelectorService.java
index 2ff2ce0..b4e6206 100644
--- a/plugins/org.eclipse.ease.modules.modeling/src/org/eclipse/ease/modules/modeling/SelectorService.java
+++ b/plugins/org.eclipse.ease.modules.modeling/src/org/eclipse/ease/modules/modeling/SelectorService.java
@@ -37,7 +37,7 @@ import com.google.common.collect.TreeMultimap;
*/
public class SelectorService {
- private static final String SELECTOR_EXT_POINT_ID = "org.eclipse.ease.module.platform.Selector";
+ private static final String SELECTOR_EXT_POINT_ID = "org.eclipse.ease.modules.modeling.selector";
private static class SingletonHolder {
@@ -143,7 +143,7 @@ public class SelectorService {
final IConfigurationElement[] config = Platform.getExtensionRegistry().getConfigurationElementsFor(SELECTOR_EXT_POINT_ID);
for (final IConfigurationElement e : config) {
- if ("Selector".equals(e.getName())) {
+ if ("selector".equals(e.getName())) {
String id = e.getAttribute("id");
try {
ISelector newSelector = (ISelector) e.createExecutableExtension("impl");
- Nicolas.
|
|
|
|
|
Powered by
FUDForum. Page generated in 0.07632 seconds