Eclipse Community Forums: Orion (Archived)

Help

Home

Home » Archived » Orion (Archived) » esprima(esprima code management)

Show: Today's Messages :: Show Polls :: Message Navigator

esprima [message #1505870]

Wed, 10 December 2014 11:27

Tamir Menahem

Messages: 1
Registered: December 2014

Junior Member

Hello,

I've noticed that the Orion client esprima.js code is being changed (fixed) regularly in Orion git
[git.eclipse.org/c/orion/org.eclipse.orion.client.git/log/bundles/org.eclipse.orion.client.javascript/web/esprima/esprima.js]

Why these changes are being done in Orion git and not in Esprima git? Is this due to the required lifecycle management (time perspective)? Are these changes being contributed later to the esprima git?

The motivation for this question is to verify that when using updated Orion client to guarantee that I have also the updated esprima.

Thanks, Tamir

Report message to a moderator

Re: esprima [message #1601019 is a reply to message #1505870]

Wed, 04 February 2015 17:15

Michael Rennie

Messages: 67
Registered: July 2009
Location: Canada

Member

> Why these changes are being done in Orion git and not in Esprima git? Is this due to the required lifecycle management (time perspective)? Are these changes being contributed later to the esprima git?

The changes made to the Orion version add in additional recovery options for incomplete syntax and various other things, mainly for our use in content assist scenarios.

I have been working with the Esprima folks to try and incorporate some of these changes directly into Esprima:

https://code.google.com/p/esprima/issues/detail?id=553
https://code.google.com/p/esprima/issues/detail?id=538
https://code.google.com/p/esprima/issues/detail?id=549
https://code.google.com/p/esprima/issues/detail?id=545

But there are some cases where our solution for recovery is not compatible with Esprima - for example we wrap entire parse functions to be able to backtrack and recover expressions, this solution is not acceptable for Esprima and fails some of their build-time tests.

> The motivation for this question is to verify that when using updated Orion client to guarantee that I have also the updated esprima.

Currently there is no guarantee that you will get the latest version of Esprima, in fact, for 8.0 we will ship with version 1.1.0-dev of Esprima.

Hope this helps,
Mike

Report message to a moderator

Previous Topic:	Building and Deploying Orion
Next Topic:	Webtools dev roadmap questions

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Fri Dec 08 13:46:11 GMT 2023

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter