Skip to main content


Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Language IDEs » Orion » esprima(esprima code management)
icon5.gif  esprima [message #1505870] Wed, 10 December 2014 11:27 Go to next message
Tamir Menahem is currently offline Tamir MenahemFriend
Messages: 1
Registered: December 2014
Junior Member
Hello,

I've noticed that the Orion client esprima.js code is being changed (fixed) regularly in Orion git
[git.eclipse.org/c/orion/org.eclipse.orion.client.git/log/bundles/org.eclipse.orion.client.javascript/web/esprima/esprima.js]

Why these changes are being done in Orion git and not in Esprima git? Is this due to the required lifecycle management (time perspective)? Are these changes being contributed later to the esprima git?

The motivation for this question is to verify that when using updated Orion client to guarantee that I have also the updated esprima.

Thanks, Tamir
Re: esprima [message #1601019 is a reply to message #1505870] Wed, 04 February 2015 17:15 Go to previous message
Michael Rennie is currently offline Michael RennieFriend
Messages: 67
Registered: July 2009
Location: Canada
Member
> Why these changes are being done in Orion git and not in Esprima git? Is this due to the required lifecycle management (time perspective)? Are these changes being contributed later to the esprima git?

The changes made to the Orion version add in additional recovery options for incomplete syntax and various other things, mainly for our use in content assist scenarios.

I have been working with the Esprima folks to try and incorporate some of these changes directly into Esprima:

https://code.google.com/p/esprima/issues/detail?id=553
https://code.google.com/p/esprima/issues/detail?id=538
https://code.google.com/p/esprima/issues/detail?id=549
https://code.google.com/p/esprima/issues/detail?id=545

But there are some cases where our solution for recovery is not compatible with Esprima - for example we wrap entire parse functions to be able to backtrack and recover expressions, this solution is not acceptable for Esprima and fails some of their build-time tests.

> The motivation for this question is to verify that when using updated Orion client to guarantee that I have also the updated esprima.

Currently there is no guarantee that you will get the latest version of Esprima, in fact, for 8.0 we will ship with version 1.1.0-dev of Esprima.

Hope this helps,
Mike
Previous Topic:Building and Deploying Orion
Next Topic:Webtools dev roadmap questions
Goto Forum:
  


Current Time: Tue Sep 25 19:18:00 GMT 2018

Powered by FUDForum. Page generated in 0.03272 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top