Eclipse Community Forums: Eclipse Scout » What is the idea behind ICodeRow / ILookupRow?

Help

Home

Home » Eclipse Projects » Eclipse Scout » What is the idea behind ICodeRow / ILookupRow?

Show: Today's Messages :: Show Polls :: Message Navigator

What is the idea behind ICodeRow / ILookupRow? [message #1431329]

Thu, 25 September 2014 14:35

Jeremie Bresson

Messages: 1252
Registered: October 2011

Senior Member

ICodeRow / ILookupRow where introduced with Luna.

What is the idea behind those interfaces?

More precisely, I do not understand why there are some setters on the interface for some members (IconId, ExtKey, Value) and not for other (BackgroundColor, Font, ForegroundColor).

Not having the setters in the interface a good pratice. The API indicate that the object is an immutable object.

I do not think that the framework will react on a change of the Text Property when ILookupRow#setText(String) is called.

For Cell and ICell the concept is not exaclty the same:
In Tables we can call getCell() [Immutable version of the Cell] and getCellForUpdate() [Mutable version of the Cell].

Having a look at the implementation of AbstractCodeTypeWithGeneric.execOverwriteCode(ICodeRow<CODE_ID>, ICodeRow<CODE_ID>)
It is really strange to have to do the check "newCode instanceof CodeRow", only because some of the setters are not available.

When I see "X instanceOf Y" in the code I should write (as framework user), it rings a bell "something is not right"

Those ICodeRow and ILookupRow interfaces where introduced with Luna. It is a little bit confusing to add code that to not respect other patterns we have already in scout.

Report message to a moderator

Re: What is the idea behind ICodeRow / ILookupRow? [message #1431348 is a reply to message #1431329]

Thu, 25 September 2014 15:11

Judith Gull

Messages: 75
Registered: February 2010

Member

Hi Jérémie
Before Luna, code row and lookup row did not have anything in common, but were used for the same things. That's why the two interfaces ICodeRow extending ILookupRow were introduced.
Clearly, ILookupRow and ICodeRow are not intended to be immutable (because a lot of things can be change). I agree that the casting in bstractCodeTypeWithGeneric.execOverwriteCode is not a good implementation.
Please make a gerrit change with an improved solution.

Report message to a moderator