Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » e(fx)clipse » e(fx)clipse CSS validation questions
e(fx)clipse CSS validation questions [message #1404278] Wed, 30 July 2014 20:54 Go to next message
Joe Joeseph is currently offline Joe JoesephFriend
Messages: 2
Registered: July 2014
Junior Member
Hey Tom, first of all, thanks for all of your hard work!

Couple of questions, I recently installed e(fx)clipse from the nightly build update site (http://download.eclipse.org/efxclipse/updates-nightly/site/).

I wanted to start playing around with CSS so I created a new Java FX project in Eclipse and copy and pasted in the Modena source files from the jdk_1.8.0_05 javafx demos and samples. My thought was to try and customize modena.css and then view the changes using the Modena sample application since it conveniently displays most (all?) of the controls.

So I extracted modena.css from the jfxrt.jar file that comes with the JDK and copied it over into my src/main/resources folder in my Eclipse project.

My first issue was that it seemed like the CSS validator does not recognize the vast majority of javafx CSS attributes (e.g. -fx-base). I support for that coming in a subsequent release?

Regardless, I started customizing some of the CSS attributes. Now as you know the modena.css file is pretty large (>3000 lines). It was not possible for me to quickly re-run the application because Eclipse would take lots of time on the "parsing and validating custom_modena.css" task (~ 1-2 minutes). I'm on a pretty fast Linux machine so that was surprising. Any ideas?

Thanks again for all your awesome work!
Joe
Re: e(fx)clipse CSS validation questions [message #1404308 is a reply to message #1404278] Thu, 31 July 2014 07:27 Go to previous messageGo to next message
Thomas Schindl is currently offline Thomas SchindlFriend
Messages: 5859
Registered: July 2009
Senior Member
Hi,

What you see is a regression caused by the fact that e(fx)clipse css
toolsuite got a lot cleverer in 1.0.0 by analyzing the classpath for
cssext-Files so that libraries like (controlsfx, our own pane libs)
added would contribute to the look up process.

I've filed https://bugs.eclipse.org/bugs/show_bug.cgi?id=440836 and we
just pushed the initial change which fixes 90% of the performance
problem a 2nd improvement will follow Monday which is our internal
e(fx)clipse day.

A new build has been published so if you check for updates on
http://download.eclipse.org/efxclipse/updates-nightly/site/ you should
get a performance boost, validation still takes a few seconds but is no
more than 5 seconds in modena.css for me now.

The problems with "-fx-base" and friends who are variables (they are NOT
attributes on Nodes!) is something that is on our list of future
improvements but I don't think we can get something in for 1.0

Tom

On 31.07.14 04:01, Joe Joeseph wrote:
> Hey Tom, first of all, thanks for all of your hard work!
>
> Couple of questions, I recently installed e(fx)clipse from the nightly
> build update site
> (http://download.eclipse.org/efxclipse/updates-nightly/site/).
>
> I wanted to start playing around with CSS so I created a new Java FX
> project in Eclipse and copy and pasted in the Modena source files from
> the jdk_1.8.0_05 javafx demos and samples. My thought was to try and
> customize modena.css and then view the changes using the Modena sample
> application since it conveniently displays most (all?) of the controls.
>
> So I extracted modena.css from the jfxrt.jar file that comes with the
> JDK and copied it over into my src/main/resources folder in my Eclipse
> project.
>
> My first issue was that it seemed like the CSS validator does not
> recognize the vast majority of javafx CSS attributes (e.g. -fx-base). I
> support for that coming in a subsequent release?
>
> Regardless, I started customizing some of the CSS attributes. Now as
> you know the modena.css file is pretty large (>3000 lines). It was not
> possible for me to quickly re-run the application because Eclipse would
> take lots of time on the "parsing and validating custom_modena.css" task
> (~ 1-2 minutes). I'm on a pretty fast Linux machine so that was
> surprising. Any ideas?
>
> Thanks again for all your awesome work!
> Joe
Re: e(fx)clipse CSS validation questions [message #1404341 is a reply to message #1404308] Thu, 31 July 2014 10:48 Go to previous messageGo to next message
Thomas Schindl is currently offline Thomas SchindlFriend
Messages: 5859
Registered: July 2009
Senior Member
Hi,

I went through the modena.css and added some missing properties (and
filed some bugs against JavaFX because they use invalid properties -
this happens if you use an editor who does not understand the valid
properties for a selector)!

If you come across more of them please add file a bug against e(fx)clipse

Tom

On 31.07.14 09:27, Tom Schindl wrote:
> Hi,
>
> What you see is a regression caused by the fact that e(fx)clipse css
> toolsuite got a lot cleverer in 1.0.0 by analyzing the classpath for
> cssext-Files so that libraries like (controlsfx, our own pane libs)
> added would contribute to the look up process.
>
> I've filed https://bugs.eclipse.org/bugs/show_bug.cgi?id=440836 and we
> just pushed the initial change which fixes 90% of the performance
> problem a 2nd improvement will follow Monday which is our internal
> e(fx)clipse day.
>
> A new build has been published so if you check for updates on
> http://download.eclipse.org/efxclipse/updates-nightly/site/ you should
> get a performance boost, validation still takes a few seconds but is no
> more than 5 seconds in modena.css for me now.
>
> The problems with "-fx-base" and friends who are variables (they are NOT
> attributes on Nodes!) is something that is on our list of future
> improvements but I don't think we can get something in for 1.0
>
> Tom
>
> On 31.07.14 04:01, Joe Joeseph wrote:
>> Hey Tom, first of all, thanks for all of your hard work!
>>
>> Couple of questions, I recently installed e(fx)clipse from the nightly
>> build update site
>> (http://download.eclipse.org/efxclipse/updates-nightly/site/).
>>
>> I wanted to start playing around with CSS so I created a new Java FX
>> project in Eclipse and copy and pasted in the Modena source files from
>> the jdk_1.8.0_05 javafx demos and samples. My thought was to try and
>> customize modena.css and then view the changes using the Modena sample
>> application since it conveniently displays most (all?) of the controls.
>>
>> So I extracted modena.css from the jfxrt.jar file that comes with the
>> JDK and copied it over into my src/main/resources folder in my Eclipse
>> project.
>>
>> My first issue was that it seemed like the CSS validator does not
>> recognize the vast majority of javafx CSS attributes (e.g. -fx-base). I
>> support for that coming in a subsequent release?
>>
>> Regardless, I started customizing some of the CSS attributes. Now as
>> you know the modena.css file is pretty large (>3000 lines). It was not
>> possible for me to quickly re-run the application because Eclipse would
>> take lots of time on the "parsing and validating custom_modena.css" task
>> (~ 1-2 minutes). I'm on a pretty fast Linux machine so that was
>> surprising. Any ideas?
>>
>> Thanks again for all your awesome work!
>> Joe
>
Re: e(fx)clipse CSS validation questions [message #1404354 is a reply to message #1404341] Thu, 31 July 2014 13:05 Go to previous message
Joe Joeseph is currently offline Joe JoesephFriend
Messages: 2
Registered: July 2014
Junior Member
Awesome news! Thanks again for you and your team's hard work!
Previous Topic:Using Jemmy for e4 javafx application
Next Topic:How to model a status bar
Goto Forum:
  


Current Time: Sat Aug 29 17:03:14 GMT 2015

Powered by FUDForum. Page generated in 0.02185 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software