Eclipse Community Forums: EMF-IncQuery » Simplification of Query

Home

Home » Archived » EMF-IncQuery » Simplification of Query

Simplification of Query [message #1404125]

Tue, 29 July 2014 14:53

Eclipse User

Hi,

could you please tell me, if there is any way of to simplify of shorten the following query:

pattern TooLargeMemberContainers(memberContainer : MemberContainer) {
	countClassMethods == count find classMethods(memberContainer, _AnyclassMethod);
	countConstructors == count find constructors(memberContainer, _Anyconstructor);
	countInterfaceMethods == count find interfaceMethods(memberContainer, _Anyinterface);
	totalCount == eval(countClassMethods + countConstructors + countInterfaceMethods);
	check(totalCount > 20);
}

private pattern classMethods(type, classMethod : ClassMethod) {
	MemberContainer.members(type, classMethod);
}

private pattern constructors(type, constructor : Constructor) {
	MemberContainer.members(type, constructor);
}

private pattern interfaceMethods(type, interfaceMethod : InterfaceMethod) {
	MemberContainer.members(type, interfaceMethod);
}

Thanks and Greetings, Mario

Re: Simplification of Query [message #1404155 is a reply to message #1404125]

Wed, 30 July 2014 01:31

Eclipse User

Are there any other type of member that you don't want to count? If not, it is not necessary to count all different members sparately:

pattern TooLargeMemberContainers(memberContainer : MemberContainer) {
	totalCount == count find members(memberContainer, _member);
	check(totalCount > 20);
}

private pattern members(type, member) {
	MemberContainer.members(type, member);
}

It's still possible to restrict counted members to certain types:

pattern TooLargeMemberContainers(memberContainer : MemberContainer) {
	totalCount == count find members(memberContainer, _member);
	check(totalCount > 20);
}

private pattern members(type, member) {
	MemberContainer.members(type, member);
	find counterMembers(member);
}

private pattern countedMembers(member){
	ClassMethod(member);
} or {
	Constructor(member);
} or {
	InterfaceMethod(member);
}

I hope this helps

Balázs;

Re: Simplification of Query [message #1404190 is a reply to message #1404155]

Wed, 30 July 2014 06:23

Eclipse User

Thanks a lot, your version is more readable and easier to extend. I just fixed one bug.
In the checkType pattern, in the signature I had to add the Type of the parameter member.

pattern TooLargeMemberContainers(memberContainer : MemberContainer) {
	totalCount == count find members(memberContainer, _);
	check(totalCount > 20);
}

private pattern members(type, member) {
	MemberContainer.members(type, member);
	find checkType(member);
}

private pattern checkType(member : Member){
	ClassMethod(member);
} or {
	Constructor(member);
} or {
	InterfaceMethod(member);
}

Previous Topic:	Compare values
Next Topic:	get Eclass of EObject

Goto Forum:

-=] Back to Top [=-

Current Time: Fri May 16 23:40:33 EDT 2025

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter