Skip to main content


Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » EGit / JGit » Reword: Add change id for gerrit
Reword: Add change id for gerrit [message #1402791] Thu, 17 July 2014 13:55 Go to next message
Felix Dorner is currently offline Felix DornerFriend
Messages: 295
Registered: March 2012
Senior Member
Hi,

I accidentally made a few commits without adding a change id for gerrit.
How can I reword these commits, adding a gerrit change Id? Is it
sufficient to just add the Change-Id:00000.... "template" and the real
id will be filled in on commit?

Felix
Re: Reword: Add change id for gerrit [message #1402813 is a reply to message #1402791] Thu, 17 July 2014 14:47 Go to previous messageGo to next message
Felix Dorner is currently offline Felix DornerFriend
Messages: 295
Registered: March 2012
Senior Member
On 17/07/2014 15:55, Felix Dorner wrote:
> Hi,
>
> I accidentally made a few commits without adding a change id for gerrit.
> How can I reword these commits, adding a gerrit change Id? Is it
> sufficient to just add the Change-Id:00000.... "template" and the real
> id will be filled in on commit?
>
Managed to do it with a sequence of soft resets + cherry picks.
Re: Reword: Add change id for gerrit [message #1403393 is a reply to message #1402791] Wed, 23 July 2014 12:10 Go to previous messageGo to next message
Matthias Sohn is currently offline Matthias SohnFriend
Messages: 1072
Registered: July 2009
Senior Member
The easiest way is to use interactive rebase and "edit" all commits which lack the changeId and click the "Add Change-Id button" in the staging view while editing each of these commits. Adding the Change-Id template
Change-Id: I0000000000000000000000000000000000000000 in the reword dialog unfortunately doesn't work.

In order to simplify this we should add the "Add Change-Id" and "Add Signed-off-by" buttons in the dialog coming up when using "Reword" during interactive rebase.
Re: Reword: Add change id for gerrit [message #1403394 is a reply to message #1403393] Wed, 23 July 2014 12:15 Go to previous message
Matthias Sohn is currently offline Matthias SohnFriend
Messages: 1072
Registered: July 2009
Senior Member
I filed https://bugs.eclipse.org/bugs/show_bug.cgi?id=440211 to track this
Previous Topic:WorkDir dirty after merge
Next Topic:Getting changed files from commitId(SHA-1)
Goto Forum:
  


Current Time: Fri Aug 23 13:45:34 GMT 2019

Powered by FUDForum. Page generated in 0.02538 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top