Eclipse Community Forums: GMF (Graphical Modeling Framework) » DestroyElementCommand is executed two times when "del." key is pressed and one time with t

Home » Modeling » GMF (Graphical Modeling Framework) » DestroyElementCommand is executed two times when "del." key is pressed and one time with t

Show: Today's Messages :: Show Polls :: Message Navigator

DestroyElementCommand is executed two times when "del." key is pressed and one time with t [message #188951]

Fri, 23 May 2008 09:09

Youmm P.

Messages: 140
Registered: July 2009

Senior Member

Hello,

In the XYZSemanticEditPolicy class, there is this code:

protected Command getDestroyElementCommand (DestroyElementRequest req)
{
CompoundCommand cc = getDestroyEdgesCommand ();
addDestroyChildNodesCommand (cc);
addDestroyShortcutsCommand (cc);
View view = (View) getHost ().getModel ();
if (view.getEAnnotation ("Shortcut") != null) { //$NON-NLS-1$
req.setElementToDestroy (view);
}

cc.add (getGEFWrapper (new DestroyElementCommand(req)));

return cc.unwrap ();
}

I replaced the line

cc.add (getGEFWrapper (new DestroyElementCommand(req)));

by my own delete command:

cc.add (getGEFWrapper (new MyOwnDestroyElementCommand(req)));

When I delete the graphical element on the diagram with the context
menu, MyOwnDestroyElementCommand is executed one time BUT when I delete
the graphical element with the "del." key, it is called two times.

How can I have it being executed only one time in both cases?

Report message to a moderator

Re: DestroyElementCommand is executed two times when "del." key is pressed and one time wi [message #189283 is a reply to message #188951]

Sat, 24 May 2008 19:36

Lazar Codrut-Lucian

Messages: 91
Registered: July 2009

Member

It has something to do with the edit policies that are installed. If you'll
try a debug session, you'll see that the command that gets executed is a
complex compound command, and that the destroy command is requested twice,
from two different policies. I added some code in a policy to avoid the
recursive code of a policy to request the command if the request is of a
certain type (DestroyRequest, or something like that). I couldn't find the
place where I made the modification. Maybe I forgot to mark the code as
@generated NOT.

Do you have an exception being thrown when the second Destroy command gets
executed?

Lucian

Report message to a moderator

Re: DestroyElementCommand is executed two times when "del." key is pressed and one time wi [message #189306 is a reply to message #189283]

Mon, 26 May 2008 08:38

Youmm P.

Messages: 140
Registered: July 2009

Senior Member

> place where I made the modification. Maybe I forgot to mark the code as
> @generated NOT.
Ok. If you find it again, please post the code here.

>
> Do you have an exception being thrown when the second Destroy command gets
> executed?
No.

Report message to a moderator

Previous Topic:	custom tab "human readable" not changing
Next Topic:	Having only one edge for an EReference with EOpposite

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Fri Apr 26 19:06:32 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter