Eclipse Community Forums: ServerTools (WTP) » Request to extend XMLMultiPageEditorPart

Home » Language IDEs » ServerTools (WTP) » Request to extend XMLMultiPageEditorPart

Request to extend XMLMultiPageEditorPart [message #186745]

Mon, 22 January 2007 13:52

Eclipse User

Originally posted by: fakeaddress.brainkandy.org

Hi,

I'd like to make a small change to XMLMultiPageEditorPart.

Right now, the source page in an XML document stored as

private StrucutredTextEditor fTextEditor

and is initialized in protected createSourcePage():

fTextEditor = createTextEditor();
fTextEditor.setEditorPart(this);

Finally, createTextEditor() looks like this:

private StructuredTextEditor createTextEditor() {
return new StructuredTextEditor();
}

What I really really want is to make createTextEditor protected, and so
when I extend XMLMultiPageEditorPart, createTextEditor can create
something that extends StructuredTextEditor.

I know very little about a) making Eclipse contributions and b) getting
patches like this integrated into my source.

I'm also assuming this is a reasonable change.

Please advise.

Thanks, Robert

Re: Request to extend XMLMultiPageEditorPart [message #186811 is a reply to message #186745]

Mon, 22 January 2007 22:02

Eclipse User

Originally posted by: fakeaddress.brainkandy.org

Robert Konigsberg wrote:
> Hi,
>
> I'd like to make a small change to XMLMultiPageEditorPart.
>
> Right now, the source page in an XML document stored as
>
> private StrucutredTextEditor fTextEditor
>
> and is initialized in protected createSourcePage():
>
> fTextEditor = createTextEditor();
> fTextEditor.setEditorPart(this);
>
> Finally, createTextEditor() looks like this:
>
> private StructuredTextEditor createTextEditor() {
> return new StructuredTextEditor();
> }
>
> What I really really want is to make createTextEditor protected, and so
> when I extend XMLMultiPageEditorPart, createTextEditor can create
> something that extends StructuredTextEditor.
>
> I know very little about a) making Eclipse contributions and b) getting
> patches like this integrated into my source.
>
> I'm also assuming this is a reasonable change.
>
> Please advise.
>
> Thanks, Robert

Let me expand just slightly -- tell you what I'm really trying to do to
see if there's a slightly better way to do it:

My intent is to add a contribution to the status bar when viewing the
source page. That doesn't require changes to the source page, but the
event that creates the change to the status bar will come from Foo
extends StructuredSourceEditor (by overriding handleCursorPositionChanged).

Re: Request to extend XMLMultiPageEditorPart [message #186825 is a reply to message #186811]

Tue, 23 January 2007 12:28

Eclipse User

Anyone interested can follow along with the RFE at
https://bugs.eclipse.org/bugs/show_bug.cgi?id=171352 , which
concerns opening up the createTextEditor() method.

--
Nitin Dahyabhai
Structured Source Editor

Re: Request to extend XMLMultiPageEditorPart [message #187212 is a reply to message #186825]

Sat, 27 January 2007 16:03

Eclipse User

Originally posted by: konigsberg-at-g-m.ail-ddooott.com

In summary, Nitin showed me that this extension was unnecessary, and that
there was a service that provided what I needed. Thanks, Nitin!

"Nitin Dahyabhai" <nitind@us.ibm.com> wrote in message
news:ep5gjj$12g$1@utils.eclipse.org...
> Anyone interested can follow along with the RFE at
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=171352 , which concerns
> opening up the createTextEditor() method.
>
> --
> Nitin Dahyabhai
> Structured Source Editor

Previous Topic:	Re: Adding a menu contribution to XML Editor
Next Topic:	Source formating - JSP

Goto Forum:

-=] Back to Top [=-

Current Time: Wed Jul 02 18:50:03 EDT 2025

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter