| Re: AdapterFactoryLabelProvider, GMF and memory leak [message #185756] |
Wed, 07 May 2008 14:47 |
Eclipse User |
|
|
|
Originally posted by: merks.ca.ibm.com
Mariot,
Open a bugzilla and I'll add some Javadoc to point out that "dispose"
should be called.
Mariot Chauvin wrote:
> Hi,
>
> While trying to find memory leak in my GMF based modeler, I found some
> code generated by GMF, which seems to me leaked :
>
> /**
> * @generated
> */
> public class LabelProviderWrapper extends DecoratingLabelProvider {
>
> /**
> * @generated
> */
> public LabelProviderWrapper() {
> super(new
> AdapterFactoryLabelProvider(MyPlugin.getInstance().getItemPr ovidersAdapterFactory()),
> null);
> }
>
> ....
>
> This code is called each time I open my modeler editor.
> As my adapterFactory is an instance of IChangeNotifier, the label
> provider is added as listener to my adapter factory and not removed
> when editor closed :(.
>
> If I did not miss something, I think it would be nice to inform in
> AdapterFactoryLabelProvider constructor javadoc that if the adapter
> factory given as parameter is an instance of IChangeNotifier, the
> label provider will be added as listener to the adapter factory.
>
> Regards,
>
> Mariot
|
|
|
Powered by
FUDForum. Page generated in 0.02625 seconds
] 
Search
Help
Register
Login
Home
