Eclipse Community Forums: GEF » Property sheet problems with MPE

Home » Eclipse Projects » GEF » Property sheet problems with MPE

Property sheet problems with MPE [message #175743]

Tue, 05 April 2005 20:28

Eclipse User

I have an editor with multiple GEF editor pages in it, written based on
the Redbook example (EMF plus GEF) and EDiagram. I find that after I
have created and loaded several editors the property pages are not
working properly. If I click on a part I get a "generic" page with what
looks like the properties for the top-level part. If I click on another
editor's tab and come back again the correct properties are being
displayed until I click on another part.

In setActivePage and pageChange I call the following:

super...
getDelegatingCommandStack().setCurrentCommandStack(
getCurrentPage().getCommandStack() );
getDelegatingZoomManager().setCurrentZoomManager(
getZoomManager(getCurrentPage().getGraphicalViewer()) );
getOutlinePage().initialize( getCurrentPage() );

I presume that the delegatingCommandStack is waking up the
UndoablePropertySheetEntry but I can't quite figure out what is going
astray after that.

Thanks,
Barry

Re: Property sheet problems with MPE [message #175833 is a reply to message #175743]

Wed, 06 April 2005 13:50

Eclipse User

You're not using EMF's providers as property sources, are you?

I don't know how the MPE works, but I take it that somewhere somebody is
properly updating the selection provider when pages are flipped. Something
like:
getSite().getWorkbenchWindow().getSelectionService().setSele ctionProvider(ge
tCurrentPage().getGraphicalViewer()).

Add a listener to the workbench's selection service and see what do you get
when you click on something in the viewer. Also, you can add a breakpoint
to select() in your graphical viewer and trace it to see where it's getting
lost.

"Barry Lay" <blay@laysercomputing.com> wrote in message
news:d2valc$npi$1@news.eclipse.org...
> I have an editor with multiple GEF editor pages in it, written based on
> the Redbook example (EMF plus GEF) and EDiagram. I find that after I
> have created and loaded several editors the property pages are not
> working properly. If I click on a part I get a "generic" page with what
> looks like the properties for the top-level part. If I click on another
> editor's tab and come back again the correct properties are being
> displayed until I click on another part.
>
> In setActivePage and pageChange I call the following:
>
> super...
> getDelegatingCommandStack().setCurrentCommandStack(
> getCurrentPage().getCommandStack() );
> getDelegatingZoomManager().setCurrentZoomManager(
> getZoomManager(getCurrentPage().getGraphicalViewer()) );
> getOutlinePage().initialize( getCurrentPage() );
>
> I presume that the delegatingCommandStack is waking up the
> UndoablePropertySheetEntry but I can't quite figure out what is going
> astray after that.
>
> Thanks,
> Barry

Re: Property sheet problems with MPE [message #176121 is a reply to message #175833]

Thu, 07 April 2005 22:56

Eclipse User

Pratik Shah wrote:
> You're not using EMF's providers as property sources, are you?

Yes I am. I used the mechanism EDiagram uses to do this.

> I don't know how the MPE works, but I take it that somewhere somebody is
> properly updating the selection provider when pages are flipped. Something
> like:
> getSite().getWorkbenchWindow().getSelectionService().setSele ctionProvider(ge
> tCurrentPage().getGraphicalViewer()).

This method doesn't exist, but getSite().setSelectionProvider() does. I
added this to the setFocus method of the GEF editor page and this seems
to fix the problem.

I guess that multiple GEF editors wasn't part of thinking for the
examples - its not exactly a beginner issue. Perhaps this detail might
be included in a future example for those of us that are too ambitious
for our own good.

Thanks for all of your help. You lead me to the solution.

Barry

Re: Property sheet problems with MPE [message #176256 is a reply to message #176121]

Fri, 08 April 2005 14:34

Eclipse User

Originally posted by: none.us.ibm.com

See https://bugs.eclipse.org/bugs/show_bug.cgi?id=46207

The current MPE in the workbench is a flawed concept. It will never work as
you want it to.

"Barry Lay" <blay@laysercomputing.com> wrote in message
news:d34s5m$95q$1@news.eclipse.org...
> Pratik Shah wrote:
>> You're not using EMF's providers as property sources, are you?
>
> Yes I am. I used the mechanism EDiagram uses to do this.
>
>> I don't know how the MPE works, but I take it that somewhere somebody is
>> properly updating the selection provider when pages are flipped.
>> Something
>> like:
>> getSite().getWorkbenchWindow().getSelectionService().setSele ctionProvider(ge
>> tCurrentPage().getGraphicalViewer()).
>
> This method doesn't exist, but getSite().setSelectionProvider() does. I
> added this to the setFocus method of the GEF editor page and this seems to
> fix the problem.
>
> I guess that multiple GEF editors wasn't part of thinking for the
> examples - its not exactly a beginner issue. Perhaps this detail might be
> included in a future example for those of us that are too ambitious for
> our own good.
>
> Thanks for all of your help. You lead me to the solution.
>
> Barry

Previous Topic:	EMF & GEF, 1:1 mapping between model object and EditParts
Next Topic:	Updating contents of FigureCanvas

Goto Forum:

-=] Back to Top [=-

Current Time: Wed Jul 23 13:43:28 EDT 2025

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter