Eclipse Community Forums: Remote Application Platform (RAP)

Help

Home

Home » Eclipse Projects » Remote Application Platform (RAP) » MenuItem accelerator text

Show: Today's Messages :: Show Polls :: Message Navigator

MenuItem accelerator text [message #1062654]

Mon, 10 June 2013 09:25

Yury Mising name

Messages: 95
Registered: May 2010
Location: Russia

Member

Predefined eclipse menu items are displayed without full accelerator text. For example, action File->Save is displayed with text "Save S" instead of "Save Ctrl+S".
The cause of this is in org.eclipse.jface.bindings.keys.formatting.NativeKeyFormatter.sortModifierKeys(int)

protected int[] sortModifierKeys(final int modifierKeys) {
...

		if (Util.isWindows()) {
...

		} else if (Util.isGtk() || Util.isMotif()) {
...

		} else if (Util.isMac()) {
...
		}

		return sortedKeys;
	}

All "if" blocks return false.

How to solve this problem?

Best regards,
Yury.

Report message to a moderator

Re: MenuItem accelerator text [message #1062662 is a reply to message #1062654]

Mon, 10 June 2013 09:52

Ivan Furnadjiev

Messages: 2426
Registered: July 2009
Location: Sofia, Bulgaria

Senior Member

Hi Yury,
interesting finding :-). In RAP SWT.getPlatform() returns "rap".
Probably the correct fix will be to add a RAP specific "else if"... or
simply default "else" that behaves as Windows for example. Or...
if (Util.isWindows() || "rap".equals( SWT.getPlatform() )) {
What do you think? Please open an enhancement request and we could
discuss the possibilities there.
Best,
Ivan

On 6/10/2013 12:25 PM, Yury Mising name wrote:
> Predefined eclipse menu items are displayed without full accelerator
> text. For example, action File->Save is displayed with text "Save S"
> instead of "Save Ctrl+S".
> The cause of this is in
> org.eclipse.jface.bindings.keys.formatting.NativeKeyFormatter.sortModifierKeys(int)
>
>
> protected int[] sortModifierKeys(final int modifierKeys) {
> ..
>
> if (Util.isWindows()) {
> ..
>
> } else if (Util.isGtk() || Util.isMotif()) {
> ..
>
> } else if (Util.isMac()) {
> ..
> }
>
> return sortedKeys;
> }
>
>
> All "if" blocks return false.
>
> How to solve this problem?
>
> Best regards,
> Yury.

--
Ivan Furnadjiev

Twitter: @EclipseRAP
Blog: http://eclipsesource.com/blogs/

Professional services for RAP and RCP?
http://eclipsesource.com/services/rap/

Report message to a moderator