Eclipse Community Forums: NatTable » How to contribute my changes of nattable builder api formally by sending a review?

Home » Eclipse Projects » NatTable » How to contribute my changes of nattable builder api formally by sending a review?(How to contribute my changes of nattable builder api formally by sending a review?)

Show: Today's Messages :: Show Polls :: Message Navigator

How to contribute my changes of nattable builder api formally by sending a review? [message #1061140]

Thu, 30 May 2013 08:18

SD Khan

Messages: 63
Registered: May 2013

Member

Hi,

I have added some minor changes in the following classes

org.eclipse.nebula.widgets.nattable.extension.builder.layers.BodyLayerStack this class is from nattable extension builder jar file

org.eclipse.nebula.widgets.nattable.extension.glazedlists.filterrow.DefaultGlazedListsFilterStrategy this class is from nattable extensions glazedlist jar file.

The changes solves the issue of enable filter row option which is given in TableModel class of nattable builder api.

Now, i want's to contribute those changes formally, how and where i should send it for review ?

Regards,
Safdar Khan

Report message to a moderator

Re: How to contribute my changes of nattable builder api formally by sending a review? [message #1061254 is a reply to message #1061140]

Thu, 30 May 2013 19:02

Dirk Fauth

Messages: 2815
Registered: July 2012

Senior Member

Hi,

to contribute you have to create a ticket in bugzilla and attach a patch file that we can use to add your code into the codebase.

You also have to do some formal stuff to allow us to add and release your code under the EPL http://wiki.eclipse.org/Development_Resources/Contribution_Questionnaire

Great that you want to take care of the builder stuff yourself and contribute back!

Greez,
Dirk

Report message to a moderator

Re: How to contribute my changes of nattable builder api formally by sending a review? [message #1061305 is a reply to message #1061254]

Fri, 31 May 2013 06:08

SD Khan

Messages: 63
Registered: May 2013

Member

Okay thanks !, however i have done the following steps

*I have created my account on https://github.com
*Got the clone copy of the nattable project.
*Made my changes locally and commit that to my clone repository at github acoount.
*I have generated a pull request from my branch into master branch with detail description of changes.

Now, it has been more than 14 hours but no one has replied yet, will it will work ? or i really need to create a bug and should attach a patch file with it as you directed.

Thanks,
Safdar Khan

Report message to a moderator

Re: How to contribute my changes of nattable builder api formally by sending a review? [message #1061437 is a reply to message #1061305]

Fri, 31 May 2013 15:39

Dirk Fauth

Messages: 2815
Registered: July 2012

Senior Member

Hi Safdar,

Sorry but we are not sitting in front of the forum waiting to answer any questions. We all have a full time job and are working on NatTable in our spare time. 14 hours with no reply even can happen because of different time zones.

We are not working with pull requests from GitHub. You need to create a ticket and attach a patch with your commit. This way the IP process is able to ensure that everything is correct.

Greez,
Dirk

Report message to a moderator