Eclipse Community Forums: NatTable » Issue with RowSelectionProvider

Home » Eclipse Projects » NatTable » Issue with RowSelectionProvider

Issue with RowSelectionProvider [message #1049970]

Fri, 26 April 2013 10:21

Eclipse User

Hello,

i recently came across the RowSelectionProvider since i am using row selection in my nattable. The problem that i had with this implementation is, that in 'setSelection()' it always creates a SelectRowsCommand with the 'withControlMask' set to true. So the 'setSelection()' is more like an 'addSelection()'. Is there a real use case for this behavior?

I got around this issue, by writing my own selection provider, which is based on RowSelectionProvider. But it would be quite nice, if the default provider could be parametrized.

Regards, Ralf

Re: Issue with RowSelectionProvider [message #1049995 is a reply to message #1049970]

Fri, 26 April 2013 10:59

Eclipse User

To be honest, I don't know. Following the spec/javadoc, the selection given as parameter should be the new selection. Therefore using the control mask is wrong.

But as you never know who is using our stuff in which way I agree with making it configurable in some way.

Could you please file a bug for this so we can keep track of it?

Re: Issue with RowSelectionProvider [message #1050015 is a reply to message #1049995]

Fri, 26 April 2013 11:23

Eclipse User

Ok created the ticket for you.
https://bugs.eclipse.org/bugs/show_bug.cgi?id=406677

Also fixed and pushed it directly.

Re: Issue with RowSelectionProvider [message #1051759 is a reply to message #1050015]

Mon, 29 April 2013 03:43

Eclipse User

Sorry for the late response, but I've been off-line till now. Thanks a lot for creating the ticket and fixing it!

Ralf

Previous Topic:	scroll very tall row that doesn't fit in table
Next Topic:	Eclipse plugin

Goto Forum:

-=] Back to Top [=-

Current Time: Wed Jul 09 08:31:12 EDT 2025

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter