Eclipse Community Forums: NatTable » customize DialogErrorHandling class

Home » Eclipse Projects » NatTable » customize DialogErrorHandling class(own dialog error handling behavior needed)

customize DialogErrorHandling class [message #995262]

Sat, 29 December 2012 10:19

Eclipse User

Hello,

I've got a problem using the new error handling in nattable. The default behavior using the DialogErrorHandling is to discard or change a value after validation. But what I need to do is validate the value and then keep or discard it. If the user decides to keep the value, it should be set by the PropertyAccessor class. I've created my own custom DialogErrorHandling class to change the dialog presented to the user and handle the "keep" button pressed behavior. Now to the problem, if the user clicks on "keep" I want to commit the value entered in the cell editor, but if I do so the validator will be fired again and I get the same dialog over and over again. Any suggestions on this?

greetings,
sascha

Re: customize DialogErrorHandling class [message #996568 is a reply to message #995262]

Wed, 02 January 2013 06:53

Eclipse User

Hi Sascha,

well the issue on this is that you call commit for keeping the value. And the commit process simplified is always convert -> validate -> update
There is currently no way to skip the validation sometimes. So the only way is

a) implement the commit behaviour yourself without the validation part. So do the conversion and then call the UpdateDataCommand and then close the open editor.
b) open such a dialog in the PropertyAccessor yourself if it should be more a warning instead of real validation. Remember that validation normally is used to avoid wrong data in your data model.

What is the exact use case for commiting invalid data to the model? Maybe we need to extend the mechanisms in some way.

Greez,
Dirk

Re: customize DialogErrorHandling class [message #996575 is a reply to message #996568]

Wed, 02 January 2013 07:18

Eclipse User

Hey Dirk,

I already did implement your option A yesterday. Don't like it that way but I see no other solution. But let me explain my usecase to you.

Example:
- 3 Cells (January, Februray, March)
- 1 Cell (Quarter1)

The user is able to enter values for every month in the quarter and the quarter value will be summed up. But the user should also be able to enter the quarter value by himself. Doing so a warning dialog will show up and inform the user about the already existing month values. The user should decide now rather to override the quarter/month values. That means if you try to enter a value for a month or quarter but a 'contra' value already exists the popup dialog shows up and asks to set or discard the entered value.

Greetings,
Sascha

Re: customize DialogErrorHandling class [message #997310 is a reply to message #996575]

Sat, 05 January 2013 10:01

Eclipse User

I will create some enhancement bug to add support for such behaviour when I'm back. There are surely some more use cases that would need that.

Re: customize DialogErrorHandling class [message #1001698 is a reply to message #997310]

Thu, 17 January 2013 03:30

Eclipse User

Created a bug for this https://bugs.eclipse.org/bugs/show_bug.cgi?id=398357

Re: customize DialogErrorHandling class [message #1005841 is a reply to message #1001698]

Mon, 28 January 2013 18:24

Eclipse User

Committed a fix for this with the major edit refactoring.