| [EMF Compare] GenericDiffEngine private functions? [message #138387] |
Fri, 10 July 2009 21:00  |
Eclipse User |
|
|
|
Originally posted by: stephenmccants.yahoo.com
Hello,
I'm looking at extending the GenericDiffEngine in order to make some changes that work better for
my specific model. I tried to override the checkMoves() function and then was looking at having it
call createRemoteMoveOperation() or createMoveOperation() (similar to how it does in
GenericDiffEngine). However, those functions are private so I cannot call them or override them.
Should they be made protected to allow for calls and overriding? Or would it be better to make
them protected and final to just allow for calls? Or is there a good reason why they are private
and I'm just not seeing it?
Thanks!
--Stephen
|
|
|
| Re: [EMF Compare] GenericDiffEngine private functions? [message #138583 is a reply to message #138387] |
Wed, 15 July 2009 07:45  |
|
This is a multi-part message in MIME format.
--------------060700020906010904090201
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
Hi Stephen,
Most if not all functions of the GenericDiffEngine (same for the rest of
the code) is private because we thought it wouldn't need to be used by
overriding classes; and we didn't need to with our own subclassing. This
was done to allow us to refactor the engine when needed.
This choice is mostly arbitrary though : do not hesitate to raise
enhancement requests or bugs for "API opening". We won't open everything
-we don't want an unmaintainable API-, but we can open what's needed by
clients :).
Regards,
Laurent Goubet
Obeo
Stephen McCants a
|
|
|
| Re: [EMF Compare] GenericDiffEngine private functions? [message #621131 is a reply to message #138387] |
Wed, 15 July 2009 07:45 |
|
This is a multi-part message in MIME format.
--------------060700020906010904090201
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
Hi Stephen,
Most if not all functions of the GenericDiffEngine (same for the rest of
the code) is private because we thought it wouldn't need to be used by
overriding classes; and we didn't need to with our own subclassing. This
was done to allow us to refactor the engine when needed.
This choice is mostly arbitrary though : do not hesitate to raise
enhancement requests or bugs for "API opening". We won't open everything
-we don't want an unmaintainable API-, but we can open what's needed by
clients :).
Regards,
Laurent Goubet
Obeo
Stephen McCants a
|
|
|
Powered by
FUDForum. Page generated in 0.02325 seconds
] 
Search
Help
Register
Login
Home
