| PDE support for running tests in a separate thread [message #12136] |
Fri, 02 January 2009 20:58  |
Eclipse User |
|
|
|
It is clear to me that UI tests should be run in a non-UI thread and I
am happy to see that SWTBot supports this. However, it seems to be
essentially a workaround to this PDE bug
https://bugs.eclipse.org/bugs/show_bug.cgi?id=89044
Is there any interest or ongoing effort to make this part of PDE? To me
it is a no-brainer that PDE should support it.
What particularly interests me about adding this to PDE is the ability
to run SWTBot tests without installing SWTBot into the IDE (i.e. just
having it part of the target platform). Not to mention this would make
the net.sf.swtbot.eclipse.ui and all its copied code no longer necessary.
Will
|
|
|
|
|
|
|
|
|
|
| Re: PDE support for running tests in a separate thread [message #36722 is a reply to message #36654] |
Mon, 25 May 2009 06:13  |
| Eclipse User |
|
|
|
I've fixed this in the latest build available on the update site.
-- Ketan
On 25/5/09 13:07, Jakob Lyng Petersen wrote:
> Actually, I found the work-around in another thread in this newsgroup:
>
> You have to add the following command-line argument to the
> runtime-configuration (even if it runs as an SWTBot Test):
> -application org.eclipse.swtbot.eclipse.core.swtbottestapplication
>
> (see the tread "New SWTBot Release"(
>
> --Jakob.
>
> Jakob Lyng Petersen wrote:
>> Yes, it returns a non-null value.
>> And Display.getCurrent() also returns a non-null value (meaning that
>> the current thread is the UI thread). (I guess getDefault() always
>> returns a non-null value?)
>>
>> Jakob.
>>
>> Ketan Padegaonkar wrote:
>>> Does Display.getDefault() inside the test give you a non-null value ?
>>>
>>> -- Ketan
>>>
>>> On 22/5/09 20:03, Jakob Lyng Petersen wrote:
>>>> Hi Ketan,
>>>>
>>>> Yeah, I do that, actually. So, are there any other explanations why it
>>>> looks like my tests are run on the UI thread?
>>>>
>>>> Jakob.
>>>>
>>>> Ketan Padegaonkar wrote:
>>>>> You need to run the tests SWTBot tests not PDE-junit tests.
>>>>>
>>>>> -- Ketan
>>>>>
>>>>> On 22/5/09 19:34, Jakob Lyng Petersen wrote:
>>>>>> I noticed that the PDE fix was made for 3.5M5. Does the newest
>>>>>> version
>>>>>> of SWTBOT depend on this fix being available? The reason I ask is
>>>>>> that I
>>>>>> just installed version 2.0.0.316-dev. Launching that from Eclipse 3.4
>>>>>> seems to force SWTBOT to run on the UI thread. The other team
>>>>>> members in
>>>>>> my team experience that SWTBOT does NOT run on the UI thread -
>>>>>> they are
>>>>>> using version 2.0.0.204-dev.
>>>>>>
>>>>>> -- Jakob.
>>>>>
>>>
|
|
|
| Re: PDE support for running tests in a separate thread [message #36756 is a reply to message #36654] |
Mon, 25 May 2009 06:13 |
| Eclipse User |
|
|
|
I've fixed this in the latest build available on the update site.
-- Ketan
On 25/5/09 13:07, Jakob Lyng Petersen wrote:
> Actually, I found the work-around in another thread in this newsgroup:
>
> You have to add the following command-line argument to the
> runtime-configuration (even if it runs as an SWTBot Test):
> -application org.eclipse.swtbot.eclipse.core.swtbottestapplication
>
> (see the tread "New SWTBot Release"(
>
> --Jakob.
>
> Jakob Lyng Petersen wrote:
>> Yes, it returns a non-null value.
>> And Display.getCurrent() also returns a non-null value (meaning that
>> the current thread is the UI thread). (I guess getDefault() always
>> returns a non-null value?)
>>
>> Jakob.
>>
>> Ketan Padegaonkar wrote:
>>> Does Display.getDefault() inside the test give you a non-null value ?
>>>
>>> -- Ketan
>>>
>>> On 22/5/09 20:03, Jakob Lyng Petersen wrote:
>>>> Hi Ketan,
>>>>
>>>> Yeah, I do that, actually. So, are there any other explanations why it
>>>> looks like my tests are run on the UI thread?
>>>>
>>>> Jakob.
>>>>
>>>> Ketan Padegaonkar wrote:
>>>>> You need to run the tests SWTBot tests not PDE-junit tests.
>>>>>
>>>>> -- Ketan
>>>>>
>>>>> On 22/5/09 19:34, Jakob Lyng Petersen wrote:
>>>>>> I noticed that the PDE fix was made for 3.5M5. Does the newest
>>>>>> version
>>>>>> of SWTBOT depend on this fix being available? The reason I ask is
>>>>>> that I
>>>>>> just installed version 2.0.0.316-dev. Launching that from Eclipse 3.4
>>>>>> seems to force SWTBOT to run on the UI thread. The other team
>>>>>> members in
>>>>>> my team experience that SWTBOT does NOT run on the UI thread -
>>>>>> they are
>>>>>> using version 2.0.0.204-dev.
>>>>>>
>>>>>> -- Jakob.
>>>>>
>>>
|
|
|
Powered by
FUDForum. Page generated in 0.09152 seconds
Home