| [EMF Compare]icons for remote changes not implemented? [message #122334] |
Tue, 13 May 2008 10:28  |
Eclipse User |
|
|
|
Hi,
It seems the remote provider does not pick up the model icons contributed by
generated Edit plugins, and the image is shown as a generic diamond of EMF
models. It works fine for local changes though. The class I refer to is
RemoteAddModelElementItemProvider, here is the getImage() impl:
/**
* This returns RemoteAddModelElement.gif.
* <!-- begin-user-doc --> <!-- end-user-doc -->
* @generated
*/
@Override
public Object getImage(Object object) {
return overlayImage(object,
getResourceLocator().getImage("full/obj16/RemoteAddModelElement "));
//$NON-NLS-1$
}
Furthermore the icon referenced here is a diamond in the source code.
In comparison, the addmodelelementitemprovider implementation was overriden:
/**
* This returns AddModelElement.gif. <!-- begin-user-doc --> <!--
end-user-doc -->
*
* @generated NOT
*/
@Override
public Object getImage(Object object) {
final AddModelElement diff = (AddModelElement)object;
Object labelImage =
AdapterUtils.getItemProviderImage(diff.getRightElement());
if (labelImage != null) {
List<Object> images = new ArrayList<Object>(2);
images.add(labelImage);
images.add(getResourceLocator().getImage("full/obj16/AddModelElement "));
//$NON-NLS-1$
labelImage = new ComposedImage(images);
} else {
labelImage = getResourceLocator().getImage("full/obj16/AddModelElement");
//$NON-NLS-1$
}
return labelImage;
}
Thanks,
David
|
|
|
|
|
| Re: [EMF Compare]icons for remote changes not implemented? [message #618042 is a reply to message #122334] |
Wed, 14 May 2008 04:00  |
| Eclipse User |
|
|
|
This is a multi-part message in MIME format.
--------------050001030807050700010404
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
David,
Remote changes (3-way comparison) have been implemented after all
others. I guess we forgot the icons when implementing it :) (or worse,
we left "@generated" on the *Impl classes which effectively overrode the
modifications).
Though this doesn't seem to be of utmost importance, could you raise a
bugzilla on this issue?
Thanks
Laurent Goubet
Obeo
David Michonneau a
|
|
|
|
Powered by
FUDForum. Page generated in 0.25803 seconds
Home