Skip to main content


Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » Equinox » Bug in AdapterHook, more precisly BundleFileWrapperFactoryHook
Bug in AdapterHook, more precisly BundleFileWrapperFactoryHook [message #100176] Mon, 22 October 2007 11:54 Go to next message
Eclipse UserFriend
Originally posted by: Jan-Hendrik.Diederich.bredex.de

Hello,
another bug in the AdapterHooks (see
http://wiki.eclipse.org/Adaptor_Hooks). More precisely in the
BundleFileWrapperFactoryHook. It should wrap every Bundle and therefore
every file it contains if I return my own Bundle class, i.e. also every
plugin.xml file in every jar _and_ directory. But it only works if I
execute my Eclipse RCP application with a launcher in the Eclipse
environment. If I let it run as an Eclipse RCP my own
BundleFile.getEntry(...) method gets much less calls. And it should make
absolutely no difference!

I even hooked me into the ClassLoaderHook with my own classloader, with
its own getResource(s) and findLocalResource(s) methods, but this methods
are only used to load a few unimportant property files.

That _must_ be a bug. But before creating a BugEntry I ask, just to make
it sure.

If no one disagrees I create a Bugentry.
Jan Diederich
Re: Bug in AdapterHook, more precisly BundleFileWrapperFactoryHook [message #100246 is a reply to message #100176] Mon, 22 October 2007 21:33 Go to previous messageGo to next message
Thomas Watson is currently offline Thomas WatsonFriend
Messages: 503
Registered: July 2009
Senior Member
Jan Diederich wrote:
> Hello,
> another bug in the AdapterHooks (see
> http://wiki.eclipse.org/Adaptor_Hooks). More precisely in the
> BundleFileWrapperFactoryHook. It should wrap every Bundle and therefore
> every file it contains if I return my own Bundle class, i.e. also every
> plugin.xml file in every jar _and_ directory. But it only works if I
> execute my Eclipse RCP application with a launcher in the Eclipse
> environment. If I let it run as an Eclipse RCP my own
> BundleFile.getEntry(...) method gets much less calls. And it should make
> absolutely no difference!
>

The registry caches the content of the plugin.xml so it does not have to
reparse the content each time eclipse is restarted. Upon restart you
will not see BundleFile.getEntry(...) called for plugin.xml files. Only
on the initial startup where the caches are being populated. If you run
with the -clean option do you see your wrapped bundle file object get
called for plugin.xml files?

Tom
Re: Bug in AdapterHook, more precisly BundleFileWrapperFactoryHook [message #100260 is a reply to message #100246] Tue, 23 October 2007 07:47 Go to previous message
Eclipse UserFriend
Originally posted by: Jan-Hendrik.Diederich.bredex.de

Argh! Yes!
Of course: the plugin cache!
I could've got the idea by myself, damn.

Many thanks for answering.
I will add a warning about this to the wiki entry about Adapter Hooks.
Plus: I'm not really sure if this is a bug due to the definition of this
Hook, although its behavior makes sense.

Thanks,
Jan Diederich


Tom Watson wrote:
> The registry caches the content of the plugin.xml so it does not have to
> reparse the content each time eclipse is restarted. Upon restart you
> will not see BundleFile.getEntry(...) called for plugin.xml files. Only
> on the initial startup where the caches are being populated. If you run
> with the -clean option do you see your wrapped bundle file object get
> called for plugin.xml files?
Previous Topic:Help on Eclipse Help System
Next Topic:Query for Extension Contribution in plug-in dependency order
Goto Forum:
  


Current Time: Tue May 14 11:40:28 GMT 2024

Powered by FUDForum. Page generated in 0.02671 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top