Eclipse Community Forums: Equinox » Bug in org.eclipse.equinox.cm

Help

Home

Home » Eclipse Projects » Equinox » Bug in org.eclipse.equinox.cm

Show: Today's Messages :: Show Polls :: Message Navigator

Bug in org.eclipse.equinox.cm [message #95229]

Mon, 20 August 2007 05:12

M Fisher

Messages: 2
Registered: July 2009

Junior Member

Hello;

I think I have found a bug in the EventDispatcher class in the
implementation of the configuration admin service.

from line 50:
if (configAdminReference != null)
configAdminReference = reference;

The variable configAdminReference is not assigned anywhere else in the
class, and so will always be null.

I noticed this after I registered a ConfigurationListener and it was not
being called. The reason for this was because ConfigurationEvents are
not created if configAdminReference is null. The setter for the
configAdminReference is called by the ServiceFactory for
ConfigurationAdmin.

bye

Report message to a moderator

Re: Bug in org.eclipse.equinox.cm [message #95245 is a reply to message #95229]

Mon, 20 August 2007 13:42

Simon Kaegi

Messages: 381
Registered: July 2009

Senior Member

Thanks. I'll look into it.
Please open a bug report.

-Simon
"M Fisher" <logicfish@hotmail.com> wrote in message
news:fab7s3$cm$1@build.eclipse.org...
> Hello;
>
> I think I have found a bug in the EventDispatcher class in the
> implementation of the configuration admin service.
>
> from line 50:
> if (configAdminReference != null)
> configAdminReference = reference;
>
> The variable configAdminReference is not assigned anywhere else in the
> class, and so will always be null.
>
> I noticed this after I registered a ConfigurationListener and it was not
> being called. The reason for this was because ConfigurationEvents are
> not created if configAdminReference is null. The setter for the
> configAdminReference is called by the ServiceFactory for
> ConfigurationAdmin.
>
> bye

Report message to a moderator

Re: Bug in org.eclipse.equinox.cm [message #95260 is a reply to message #95229]

Mon, 20 August 2007 14:18

Simon Kaegi

Messages: 381
Registered: July 2009

Senior Member

In order to generate events you would need to call configuration.update(...)
or configuration.delete().
You should only be able to get at a Configuration object via the ConfigAdmin
service which in turn should initialize EventDispatcher. e.g.
ManagedServices and ManagedServiceFactories only provide access to a
dictionary of properties.
Are we leaking a Configuration object somewhere?? Perhaps a subtle threading
problem??

Can you provide some details on what you're doing or better yet a test case.

Thanks.
-Simon

"M Fisher" <logicfish@hotmail.com> wrote in message
news:fab7s3$cm$1@build.eclipse.org...
> Hello;
>
> I think I have found a bug in the EventDispatcher class in the
> implementation of the configuration admin service.
>
> from line 50:
> if (configAdminReference != null)
> configAdminReference = reference;
>
> The variable configAdminReference is not assigned anywhere else in the
> class, and so will always be null.
>
> I noticed this after I registered a ConfigurationListener and it was not
> being called. The reason for this was because ConfigurationEvents are
> not created if configAdminReference is null. The setter for the
> configAdminReference is called by the ServiceFactory for
> ConfigurationAdmin.
>
> bye

Report message to a moderator