Eclipse Community Forums: scout » Scout RT

Help

Home

Home » Eclipse Projects » scout » Scout RT - Questions...(...after code review)

Show: Today's Messages :: Show Polls :: Message Navigator

Scout RT - Questions... [message #737771]

Sat, 15 October 2011 12:25

Jeremie Bresson

Messages: 124
Registered: November 2010

Senior Member

I have done a little bit code review in the the Scout RT code... It has raised some questions:

1. Consistency:
I opened a bug 359668 in order to point out the fact that there is no ITimeField interface and no AbstractTimeColumn class. This is not a big deal, but it would be nice to add them (even marker class / interface) to have the same pattern everywhere.

2. ListBox (resp. TreeBox) and CompositeField

ListBox and TreeBox are also CompositeField (implementing ICompositeField and loading the IFormField inner-classes in getConfiguredFields() during the initialization).

AbstractListBox (resp. AbstractTreeBox) uses this property internally for AbstractListBoxFilterBox (resp. AbstractTreeBoxFilterBox)...

  @Order(1)
  public class ListBoxFilterBox extends AbstractListBoxFilterBox

Is the composite field "nature" of AbstractListBox (resp AbstractTreeBox) only for internal use ? I have tried to add a StringField as inner-class of a ListBox ?? It doesn't seems to have any effect.

The SDK do not propose to create a FormField in a ListBox...
Does it make sense to add any kind of FormField in a ListBox (resp a TreeBox)?

3. RadioButtonGroup and CompositeField

For RadioButtonGroup, the situation is a little bit different. The SDK allows to add RadioButton or any kind of FormField.

index.php/fa/4304/0/

The FormFields (for example a StringField) added in the RadioButtonGroup also appears...

I personally wonder what the use case is, to have any kind of FormField as inner-class of a RadioButtonGroup... For me only inner RadioButtons makes sense.

Attachment: RadioButtonGroup_SDK_Add.png
(Size: 56.55KB, Downloaded 378 times)

Report message to a moderator

Re: Scout RT - Questions... [message #739550 is a reply to message #737771]

Mon, 17 October 2011 15:51

Ivan Motsch

Messages: 133
Registered: March 2010

Senior Member

A very often case is having a "list" of sections where a radio button is on the left and a group box or other field is on the right. That can that way easily be covered.

The following example is in place in some projects (simplified code):

public class RadioButtonGroup extends AbstractRadioButtonGroup<Long> {

  public class EveryoneButton extends AbstractRadioButton {
  }

  public class EveryoneField extends AbstractPlaceholderField {
    ...
  }


  public class PartitionButton extends AbstractRadioButton {
  }

  public class PartitionField extends AbstractSmartField<Long> {
    ...
  }


  public class DepartmentButton extends AbstractRadioButton {
  }

  public class DepartmentField extends AbstractSmartField<Long> {
    ...
  }


  public class TeamButton extends AbstractRadioButton {
  }

  public class TeamField extends AbstractSmartField<Long> {
    ...
  }


  public class PersonButton extends AbstractRadioButton {
  }

  public class PersonField extends AbstractPersonField {
    ...
  }
}

And this looks as the attached image.

Attachment: radio_group.png
(Size: 9.55KB, Downloaded 225 times)

Report message to a moderator

Previous Topic:	Eclipse Scout RC4: MySql support?
Next Topic:	Connection to database does not work

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Sat Apr 04 10:01:59 GMT 2020

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter