|
| Re: Customization and NPE with RAP business theme [message #668175 is a reply to message #668131] |
Wed, 04 May 2011 10:26   |
 Holger Staudacher
Messages: 166
Registered: July 2009 |
Senior Member |
|
|
Hi Jean,
please see my comments below.
On 2011-05-03 23:14:51 +0200, Jean Bovet <jean.bovet@oracle.com> said:
> Hi,
>
> First of all thanks for the guys behind the RAP business theme to bring
> such a great theme. I am trying to use it in our application (it works
> well except one little issue that I describe below) and I have a few
> questions:
>
> 1) As I read in a previous post, if I want to customize the logo of the
> theme, I have to override one of the layout set. In this particular
> case, I suppose I need to override the layoutset.logo and create a
> class similar to LogoInitializer to provide my own logo, correct?
I suggest that you chek out the org.eclipse.rap.examples project from
our CVS. In this bundle we override the logo. I think you can simply
copy this part.
>
> 2) Is there a way to change the margins of the theme (e.g. the left and
> right margins inside the browser frame)? If not through extension, I
> suppose I would need to modify the theme source itself.
No, there is no way to modify this via an extension. One possibility
would be to create a new design and use the business theme as base. I
think the
org.eclipse.rap.internal.design.example.business.BusinessWin dowComposer
is the right point to start. You only need to rewrite this one and use
the PresentantionFactory from teh business design.
>
> 3) When I click on the configuration button of one of my view, I get
> the following NPE:
> java.lang.NullPointerException
> at
> org.eclipse.rap.internal.design.example.stacks.Configuration Dialog.loadActionSettings(ConfigurationDialog.java:218)
at
org.eclipse.rap.internal.design.example.stacks.Configuration Dialog.createDialogArea(ConfigurationDialog.java:135)
at
org.eclipse.jface.dialogs.PopupDialog.createContents(PopupDi alog.java:683)
Apparently
>
> one of my toolitem doesn't have a contribution item. That is correct in
> the sense that I'm adding to the toolbar manager several
> ContributionItem items and several IAction items. It works fine with
> the default theme so does the business theme doesn't support the
> IAction items?
This sounds like a bug to me. Can you provide a snippet to reproduce it
and file a bug against the eclips ebugzilla?
Thank in advance.
Cheers Holger
>
> Thanks,
>
> Jean
--
--
Holger Staudacher | EclipseSource Karlsruhe
Need professional support for RAP and RCP?
Go to: http://eclipsesource.com/support
Twitter : @hstaudacher
Blog : http://eclipsesource.com/blogs/tag/rap/
|
|
|
| Re: Customization and NPE with RAP business theme [message #668294 is a reply to message #668175] |
Wed, 04 May 2011 21:28 |
Jean Bovet
Messages: 34
Registered: September 2009 |
Member |
|
|
Thanks Holger! I will check the examples and will provide a snippet to
reproduce the issue (I'll double check my code first to see if
something obvious can solve that).
Jean
On 2011-05-04 03:26:38 -0700, Holger Staudacher said:
> Hi Jean,
> please see my comments below.
>
> On 2011-05-03 23:14:51 +0200, Jean Bovet <jean.bovet@oracle.com> said:
>
>> Hi,
>>
>> First of all thanks for the guys behind the RAP business theme to bring
>> such a great theme. I am trying to use it in our application (it works
>> well except one little issue that I describe below) and I have a few
>> questions:
>>
>> 1) As I read in a previous post, if I want to customize the logo of the
>> theme, I have to override one of the layout set. In this particular
>> case, I suppose I need to override the layoutset.logo and create a
>> class similar to LogoInitializer to provide my own logo, correct?
>
> I suggest that you chek out the org.eclipse.rap.examples project from
> our CVS. In this bundle we override the logo. I think you can simply
> copy this part.
>
>>
>> 2) Is there a way to change the margins of the theme (e.g. the left and
>> right margins inside the browser frame)? If not through extension, I
>> suppose I would need to modify the theme source itself.
>
> No, there is no way to modify this via an extension. One possibility
> would be to create a new design and use the business theme as base. I
> think the
> org.eclipse.rap.internal.design.example.business.BusinessWin dowComposer
> is the right point to start. You only need to rewrite this one and use
> the PresentantionFactory from teh business design.
>
>>
>> 3) When I click on the configuration button of one of my view, I get
>> the following NPE:
>> java.lang.NullPointerException
>> at
>> org.eclipse.rap.internal.design.example.stacks.Configuration Dialog.loadActionSettings(ConfigurationDialog.java:218)
at
org.eclipse.rap.internal.design.example.stacks.Configuration Dialog.createDialogArea(ConfigurationDialog.java:135)
at
org.eclipse.jface.dialogs.PopupDialog.createContents(PopupDi alog.java:683)
Apparently
one
>>
>> of my toolitem doesn't have a contribution item. That is correct in the
>> sense that I'm adding to the toolbar manager several ContributionItem
>> items and several IAction items. It works fine with the default theme
>> so does the business theme doesn't support the IAction items?
>
>
> This sounds like a bug to me. Can you provide a snippet to reproduce it
> and file a bug against the eclips ebugzilla?
>
> Thank in advance.
>
> Cheers Holger
>
>>
>> Thanks,
>>
>> Jean
>
>
> --
|
|
|
Powered by
FUDForum. Page generated in 0.03540 seconds
] 
Search
Help
Register
Login
Home
