Eclipse Community Forums: Remote Application Platform (RAP) » WorkbenchPage setPerspective

Help

Home

Home » Eclipse Projects » Remote Application Platform (RAP) » WorkbenchPage setPerspective - CoolBar problem

Show: Today's Messages :: Show Polls :: Message Navigator

WorkbenchPage setPerspective - CoolBar problem [message #660462]

Fri, 18 March 2011 14:40

NkD Missing name

Messages: 61
Registered: July 2009

Member

This is a multi-part message in MIME format.
--------------090106090204030804010704
Content-Type: text/plain; charset=ISO-8859-2; format=flowed
Content-Transfer-Encoding: 7bit

I have
java.lang.NullPointerException at
org.eclipse.ui.internal.WorkbenchPage.setPerspective(Workben chPage.java:3715)

because I don't use CoolBar in my PresentationFactory:

Solution for me is extends: if (mgr != null) to if (mgr != null &&
mgr.getControl2() != null)

I use RAP 1.4 M5+

--------------090106090204030804010704
Content-Type: text/plain;
name="patch.txt"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename="patch.txt"

Index: Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java
============================================================ =======
RCS file: /cvsroot/rt/org.eclipse.rap/runtime.ui/org.eclipse.rap.ui.wo rkbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java,v
retrieving revision 1.7
diff -u -r1.7 WorkbenchPage.java
--- Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java 28 Dec 2010 14:47:59 -0000 1.7
+++ Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java 18 Mar 2011 14:27:28 -0000
@@ -3699,7 +3699,7 @@
// switched. Turn off redraw to help with this.
ICoolBarManager2 mgr = (ICoolBarManager2) window.getCoolBarManager2();
try {
- if (mgr != null)
+ if (mgr != null && mgr.getControl2() != null)
mgr.getControl2().setRedraw(false);
getClientComposite().setRedraw(false);

@@ -3711,7 +3711,7 @@
});
} finally {
getClientComposite().setRedraw(true);
- if (mgr != null)
+ if (mgr != null && mgr.getControl2() != null)
mgr.getControl2().setRedraw(true);
IWorkbenchPart part = getActivePart();
if (part != null) {

--------------090106090204030804010704--

Report message to a moderator

Re: WorkbenchPage setPerspective - CoolBar problem [message #660472 is a reply to message #660462]

Fri, 18 March 2011 14:49

Ivan Furnadjiev

Messages: 2359
Registered: July 2009
Location: Sofia, Bulgaria

Senior Member

Hi Michal,
we already has this bug opened:
326289: NullPointerException in Workbenchpage with disabled coolbar
https://bugs.eclipse.org/bugs/show_bug.cgi?id=326289
but I thought that it has been fixed with the migration to the workbench
3.7 code base. I will check it against RCP (workbench 3.7) again.
Best,
Ivan

On 3/18/2011 4:40 PM, Michal NkD Nikodím wrote:
> I have
> java.lang.NullPointerException at
> org.eclipse.ui.internal.WorkbenchPage.setPerspective(Workben chPage.java:3715)
>
> because I don't use CoolBar in my PresentationFactory:
>
> Solution for me is extends: if (mgr != null) to if (mgr != null &&
> mgr.getControl2() != null)
>
> I use RAP 1.4 M5+
>
>
>
>
>

Report message to a moderator

Re: WorkbenchPage setPerspective - CoolBar problem [message #660473 is a reply to message #660462]

Fri, 18 March 2011 14:59

Ivan Furnadjiev

Messages: 2359
Registered: July 2009
Location: Sofia, Bulgaria

Senior Member

Hi Michal,
could you provide a snippet to reproduce it (attach it to the bug 326289
and 254936)? Please test your snippet in RCP. If it is reproducible in
RCP too, please reopen this bug:
254936: [Coolbar] Cannot switch perspective in a RCP application without
Coolbars
https://bugs.eclipse.org/bugs/show_bug.cgi?id=254936
Thanks,
Ivan

On 3/18/2011 4:40 PM, Michal NkD Nikodím wrote:
> I have
> java.lang.NullPointerException at
> org.eclipse.ui.internal.WorkbenchPage.setPerspective(Workben chPage.java:3715)
>
> because I don't use CoolBar in my PresentationFactory:
>
> Solution for me is extends: if (mgr != null) to if (mgr != null &&
> mgr.getControl2() != null)
>
> I use RAP 1.4 M5+
>
>
>
>
>

Report message to a moderator

Previous Topic:	Accessing properties file through jar
Next Topic:	How to access MC pojo beans from a RAP app

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Tue Oct 26 15:35:56 GMT 2021

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter