|
|
| Re: Plan for formatter related issues? [message #659646 is a reply to message #658641] |
Mon, 14 March 2011 23:45  |
 Henrik Lindberg
Messages: 2509
Registered: July 2009 |
Senior Member |
|
|
I just updated to Xtext 2.0 2011-03-14, and all of the formatter related
issues I was referring to are still there (cry)...
Checked bugzillas - I have reported some, but my problems looked very
similar to what was already reported by others and some of those seemed
to be easily reproduced with small grammars. Some of those have been
fixed, but I did not see any improvement on the issues I have.
If someone is willing to checkout the cloudsmith/geppetto from github
and run JUnit tests that reproduce the formatting errors I am seeing
then I can add a couple of more tests and collect the existing failing
tests into one JUnit class for easy consumption.
Should I report this as a single issue "various formatting functionality
broken in 2.0" or somesuch?
I want to expose the functionality of geppetto to the puppet community,
but I am reluctant as long as formatting works as badly as it does now
(quick fixes are out of the questions in many cases for instance as the
result depends on formatting). So, I think the formatting issues are
very important.
A sample of some of the issues I am referring to:
(Are all the fixes marked RC1 also fixed in 2.0? In some bugs there were
remarks that fixes were also applied to master, but in some the comments
does not say.)
https://bugs.eclipse.org/bugs/show_bug.cgi?id=318883 - reported for 1.0
and looks similar to my issue (the tip that other elements in the
grammar should be tried has no effect in my case).
And https://bugs.eclipse.org/bugs/show_bug.cgi?id=329150 (closed as a
duplicate of the above).
https://bugs.eclipse.org/bugs/show_bug.cgi?id=336235
https://bugs.eclipse.org/bugs/show_bug.cgi?id=318728 - Formatting around
Comments, seems to be capable of screwing things up royally as well.
https://bugs.eclipse.org/bugs/show_bug.cgi?id=315559 -
[formatter/matcher] Unordered groups are not handled correctly - is also
pretty bad.
And this one - https://bugs.eclipse.org/bugs/show_bug.cgi?id=314095 -
[formatter/matcher] formatting of quick fix produces wrong layout
https://bugs.eclipse.org/bugs/show_bug.cgi?id=314027 -
[formatter/matcher] Support before/after indentation -> problem with
matcher remaining - looks similar to an issue I also have.
https://bugs.eclipse.org/bugs/show_bug.cgi?id=313677
https://bugs.eclipse.org/bugs/show_bug.cgi?id=314034 [formatter]
Relative linewrap, nospace formatting priority - closed as duplicate of
the one below.
https://bugs.eclipse.org/bugs/show_bug.cgi?id=313677 - [formatter]
precedence of NoSpace/Linewrap unexpected. This may be one issue I am
seeing.
https://bugs.eclipse.org/bugs/show_bug.cgi?id=308161 - Declarative
formatter ignores custom terminal rules - I have similar constructs.
(there are more...)
Regards
- henrik
On 3/9/11 11:04 AM, Jan Koehnlein wrote:
> We think we have fixed the critical ones. For the rest, we'll try to fix
> them before the Indigo release.
>
>
> Am 09.03.11 02:10, schrieb Henrik Lindberg:
>> Hi,
>> I wonder what the plan is for "all the formatter related issues" for
>> Xtext 2.0.
>>
>> Regards
>> - henrik
>
>
|
|
|
Powered by
FUDForum. Page generated in 0.03438 seconds
] 
Search
Help
Register
Login
Home
