Eclipse Community Forums: EGit / JGit » Git and version qualifiers

Help

Home

Home » Eclipse Projects » EGit / JGit » Git and version qualifiers

Show: Today's Messages :: Show Polls :: Message Navigator

Git and version qualifiers [message #654350]

Tue, 15 February 2011 10:44

Maxime Jeanmart

Messages: 35
Registered: November 2010

Member

Hi,

P2 normally asks the following version format "major.minor.service.qualifier" for plug-ins, though it's not really mandatory. What I think is mandatory is to have the version number be monotonically increasing. The usual pattern is to include the source control id in the qualifier. Unfortunately, git uses hash codes as ids, which doesn't ensure that the number increases with versions.

So how does it work for plug-in versions stored using git? I noticed that eGit and JGit plug-ins don't use the qualifier at the end of the version number: Should we do just that, forget about the qualifier?

Maxime

Report message to a moderator

Re: Git and version qualifiers [message #654367 is a reply to message #654350]

Tue, 15 February 2011 12:23

Paul Webster

Messages: 6859
Registered: July 2009
Location: Ottawa

Senior Member

On 02/15/2011 05:44 AM, Maxime Jeanmart wrote:
> So how does it work for plug-in versions stored using git? I noticed
> that eGit and JGit plug-ins don't use the qualifier at the end of the
> version number: Should we do just that, forget about the qualifier?

egit and jgit do use the qualifier, at least for the nightlies. I guess
just not for the release. That means technically the nightly plugin is
"greater" than the released plugin.

But I didn't have any trouble updating from a nightly to the release, I
guess it doesn't matter so much.

But in e4 we use git repos and map files with PDE build and the Git
fetch factory, and it produces plugins with the traditional increasing
qualifier.

PW

--
Paul Webster
http://wiki.eclipse.org/Platform_Command_Framework
http://wiki.eclipse.org/Command_Core_Expressions
http://wiki.eclipse.org/Platform_Expression_Framework
http://wiki.eclipse.org/Menu_Contributions
http://wiki.eclipse.org/Menus_Extension_Mapping
http://help.eclipse.org/galileo/index.jsp?topic=/org.eclipse .platform.doc.isv/guide/workbench.htm

Paul Webster
http://wiki.eclipse.org/Platform_Command_Framework
http://wiki.eclipse.org/Command_Core_Expressions
http://wiki.eclipse.org/Menu_Contributions

Report message to a moderator

Re: Git and version qualifiers [message #654406 is a reply to message #654367]

Tue, 15 February 2011 15:44

Chris Aniszczyk

Messages: 674
Registered: July 2009

Senior Member

I always recommend using the qualifier. The reason EGit and JGit drop the qualifier for releases is due to Maven and P2 versioning differences.

So essentially, we'll have nightly builds...
0.11.0.qualifier

When we release, we'll do a 0.11.1, tag and move on to 0.11.2.qualifier... if we need to release again, we'll do a 0.11.3 and 0.11.4.qualifier... and so on.

Hope that makes a bit sense.

Report message to a moderator

Re: Git and version qualifiers [message #654511 is a reply to message #654406]

Wed, 16 February 2011 07:17

Maxime Jeanmart

Messages: 35
Registered: November 2010

Member

I think it makes sense indeed. Since the qualifier starts with the date, the nightly build always produces a higher qualifier, whatever the id after the date.
I guess we just have to take care if we do more than a build a day for some reasons, which should not happen too often.

Report message to a moderator

Previous Topic:	Show Annotation
Next Topic:	ANT Support?

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Thu Apr 02 16:59:13 GMT 2020

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter