Skip to main content


Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Archived » Buckminster » Plugin signatures lost upon site.p2
Plugin signatures lost upon site.p2 [message #644192] Thu, 09 December 2010 19:30 Go to next message
Thorsten Meinl is currently offline Thorsten MeinlFriend
Messages: 85
Registered: July 2009
Member
Hi all,

When plugins from the target platform are packaged into an p2 repository
using the site.p2 action, their signatures are lost. This does not
affect all plugins, but merely plugins that reside inside the TP as
directories. Signatures from pure-Jar plugins are retained. Examples are
java.xml.rpc or org.apache.ant. It seems to me, that this is a bug. Or
am I doing something wrong?

Cheers,

Thorsten
Re: Plugin signatures lost upon site.p2 [message #644201 is a reply to message #644192] Thu, 09 December 2010 21:13 Go to previous messageGo to next message
Thorsten Meinl is currently offline Thorsten MeinlFriend
Messages: 85
Registered: July 2009
Member
It seems the problem is the "recreate.jar" task in
org/eclipse/buckminster/pde/antscripts/build.xml:

<target name="recreate.jar" depends="create.output.dir">
<buckminster.copy todir="${buckminster.temp}">
<buckminster.filesetgroup value="${fs:action.requirements}"/>
</buckminster.copy>
<zip zipfile="${sp:action.output}">
<fileset dir="${buckminster.temp}" includes="META-INF/*"
excludes="META-INF/*.RSA,META-INF/*.DSA,META-INF/*.SF"/>
<fileset dir="${buckminster.temp}" excludes="META-INF/*"/>
</zip>
</target>

The signing files are deliberately excluded from the created JAR files,
causing exactly the behaviour I'm seeing. The question is, why are these
files excluded? Thomas should know, as he was the last one having
changed these lines in June 2008 ;-)

Cheers,

Thorsten
Re: Plugin signatures lost upon site.p2 [message #644437 is a reply to message #644201] Sat, 11 December 2010 09:11 Go to previous message
Thomas Hallgren is currently offline Thomas HallgrenFriend
Messages: 3240
Registered: July 2009
Senior Member
Hi Thorsten,

The reason the signing files were excluded was that the recreated jar
file didn't match the original. The behavior was only intended for jars
that was imported into the workspace (and thus changed in more ways than
one), not the jars in the target platform so if you see that behavior
for them too, then it's a bug.

- thomas


On 2010-12-09 22:13, Thorsten Meinl wrote:
> It seems the problem is the "recreate.jar" task in
> org/eclipse/buckminster/pde/antscripts/build.xml:
>
> <target name="recreate.jar" depends="create.output.dir">
> <buckminster.copy todir="${buckminster.temp}">
> <buckminster.filesetgroup value="${fs:action.requirements}"/>
> </buckminster.copy>
> <zip zipfile="${sp:action.output}">
> <fileset dir="${buckminster.temp}" includes="META-INF/*"
> excludes="META-INF/*.RSA,META-INF/*.DSA,META-INF/*.SF"/>
> <fileset dir="${buckminster.temp}" excludes="META-INF/*"/>
> </zip>
> </target>
>
> The signing files are deliberately excluded from the created JAR files,
> causing exactly the behaviour I'm seeing. The question is, why are these
> files excluded? Thomas should know, as he was the last one having
> changed these lines in June 2008 ;-)
>
> Cheers,
>
> Thorsten
Previous Topic:Hudson Update does not re-install PSF provider
Next Topic:Orbit plugin cannot be resolved with eclipse.import provider
Goto Forum:
  


Current Time: Fri Apr 26 18:39:38 GMT 2024

Powered by FUDForum. Page generated in 0.02748 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top