Plugin signatures lost upon site.p2 [message #644192] |
Thu, 09 December 2010 14:30  |
Eclipse User |
|
|
|
Hi all,
When plugins from the target platform are packaged into an p2 repository
using the site.p2 action, their signatures are lost. This does not
affect all plugins, but merely plugins that reside inside the TP as
directories. Signatures from pure-Jar plugins are retained. Examples are
java.xml.rpc or org.apache.ant. It seems to me, that this is a bug. Or
am I doing something wrong?
Cheers,
Thorsten
|
|
|
|
Re: Plugin signatures lost upon site.p2 [message #644437 is a reply to message #644201] |
Sat, 11 December 2010 04:11  |
Eclipse User |
|
|
|
Hi Thorsten,
The reason the signing files were excluded was that the recreated jar
file didn't match the original. The behavior was only intended for jars
that was imported into the workspace (and thus changed in more ways than
one), not the jars in the target platform so if you see that behavior
for them too, then it's a bug.
- thomas
On 2010-12-09 22:13, Thorsten Meinl wrote:
> It seems the problem is the "recreate.jar" task in
> org/eclipse/buckminster/pde/antscripts/build.xml:
>
> <target name="recreate.jar" depends="create.output.dir">
> <buckminster.copy todir="${buckminster.temp}">
> <buckminster.filesetgroup value="${fs:action.requirements}"/>
> </buckminster.copy>
> <zip zipfile="${sp:action.output}">
> <fileset dir="${buckminster.temp}" includes="META-INF/*"
> excludes="META-INF/*.RSA,META-INF/*.DSA,META-INF/*.SF"/>
> <fileset dir="${buckminster.temp}" excludes="META-INF/*"/>
> </zip>
> </target>
>
> The signing files are deliberately excluded from the created JAR files,
> causing exactly the behaviour I'm seeing. The question is, why are these
> files excluded? Thomas should know, as he was the last one having
> changed these lines in June 2008 ;-)
>
> Cheers,
>
> Thorsten
|
|
|
Powered by
FUDForum. Page generated in 0.04718 seconds