Skip to main content


Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » Remote Application Platform (RAP) » Dispose all WizardRegistry on Workbench.shutdown()
Dispose all WizardRegistry on Workbench.shutdown() [message #628203] Thu, 23 September 2010 10:39 Go to next message
Yury Mising name is currently offline Yury Mising nameFriend
Messages: 95
Registered: May 2010
Location: Russia
Member
Hi, All!

There are 3 static WizardRegisties in WorkbenchPlugin. I think we must to dispose them while Workbench is closing (Workbench.shutdown()) and reseting WorkbenchPlugin:
    private void shutdown() {
...
        if (WorkbenchPlugin.getDefault() != null) {
            WorkbenchPlugin.getDefault().reset();
        }
...
    }

because RAP isn't one display application. Supposed patch is below:
### Eclipse Workspace Patch 1.0
#P org.eclipse.rap.ui.workbench
Index: Eclipse UI/org/eclipse/ui/internal/WorkbenchPlugin.java
===================================================================
RCS file: /cvsroot/rt/org.eclipse.rap/runtime.ui/org.eclipse.rap.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchPlugin.java,v
retrieving revision 1.24
diff -u -r1.24 WorkbenchPlugin.java
--- Eclipse UI/org/eclipse/ui/internal/WorkbenchPlugin.java	3 May 2010 06:47:36 -0000	1.24
+++ Eclipse UI/org/eclipse/ui/internal/WorkbenchPlugin.java	23 Sep 2010 10:37:24 -0000
@@ -388,6 +388,10 @@
         	operationSupport.dispose();
         	operationSupport = null;
         }
+        
+        ((AbstractWizardRegistry)getNewWizardRegistry()).dispose();
+        ((AbstractWizardRegistry)getImportWizardRegistry()).dispose();
+        ((AbstractWizardRegistry)getExportWizardRegistry()).dispose();
 
         DEBUG = false;
          

Re: Dispose all WizardRegistry on Workbench.shutdown() [message #628603 is a reply to message #628203] Thu, 23 September 2010 13:18 Go to previous messageGo to next message
Ralf Sternberg is currently offline Ralf SternbergFriend
Messages: 1313
Registered: July 2009
Senior Member

Thanks for the patch, Yury. Would you mind to attach it to a bug and
relate it to bug 309661? Then we can consider it during the workbench
migration.

Regards, Ralf

--
Ralf Sternberg

Need professional support for RAP and RCP?
http://www.eclipsesource.com/support/

Twitter: http://twitter.com/eclipsesource
Blog: http://www.eclipsesource.com/blogs/
Re: Dispose all WizardRegistry on Workbench.shutdown() [message #628765 is a reply to message #628603] Fri, 24 September 2010 04:41 Go to previous message
Yury Mising name is currently offline Yury Mising nameFriend
Messages: 95
Registered: May 2010
Location: Russia
Member
Hi, Ralf!

I've filed a bugzilla 326111 with block relation on 309661.

Best regards,
Yury.
Previous Topic:Animations
Next Topic:Request processing goes wrong with Chrome 7 with session time out (Bug?)
Goto Forum:
  


Current Time: Wed Sep 25 04:46:25 GMT 2024

Powered by FUDForum. Page generated in 0.03881 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top