Eclipse Community Forums: EMF "Technology" (Ecore Tools, EMFatic, etc)

Help

Home

Home » Modeling » EMF "Technology" (Ecore Tools, EMFatic, etc) » EEF ComposedAdapterFactory

Show: Today's Messages :: Show Polls :: Message Navigator

EEF ComposedAdapterFactory [message #622103]

Tue, 09 February 2010 03:11

Miles Parker

Messages: 1341
Registered: July 2009

Senior Member

It looks like the EEF **PropertiesEditionPartForms are not using the same strategy as the EMF generated editors to create the adapter factories? Looking at the source it looks like one is just created and then never modified. That means that I'm not getting the right label providers for references. If I hack it into "CreateMyObjectFlatComboViewer" like so:

owner = new EObjectFlatComboViewer(parent, true);
((ComposedAdapterFactory) adapterFactory).addAdapterFactory(new ResourceItemProviderAdapterFactory());
((ComposedAdapterFactory) adapterFactory).addAdapterFactory(new MyModelProviderAdapterFactory());
((ComposedAdapterFactory) adapterFactory).addAdapterFactory(new MyModelSubPackageItemProviderAdapterFactory());
....
((ComposedAdapterFactory) adapterFactory).addAdapterFactory(new ReflectiveItemProviderAdapterFactory());
owner.setLabelProvider(new AdapterFactoryLabelProvider(adapterFactory));

Then that does work, but obviously that's not very satisfactory. :) Is there a pattern that I'm missing here?

thanks,

Miles

Report message to a moderator

Re: EEF ComposedAdapterFactory [message #622104 is a reply to message #622103]

Tue, 09 February 2010 09:14

Goulwen Le Fur

Messages: 125
Registered: July 2009

Senior Member

Hi Miles,

Thanks for your very interesting feedback. You're right about our
strategy for AdapterFactories. This isn't very satisfactory. We plan to
make a real improvment in the views (it includes the way to defines
adapter factories) but before that, we have a really important thing to
do: create Non-regression Tests.

We currently work on creating these tests and I hope we will finish this
week.

We will begin this phase of refund after.

Now I will check the bugs you open on EEF ;)

--
Goulwen Le Fur - goulwen.lefur@obeo.fr

Miles Parker a écrit :
> It looks like the EEF **PropertiesEditionPartForms are not using the
> same strategy as the EMF generated editors to create the adapter
> factories? Looking at the source it looks like one is just created and
> then never modified. That means that I'm not getting the right label
> providers for references. If I hack it into
> "CreateMyObjectFlatComboViewer" like so:
>
> owner = new EObjectFlatComboViewer(parent, true);
> ((ComposedAdapterFactory) adapterFactory).addAdapterFactory(new
> ResourceItemProviderAdapterFactory());
> ((ComposedAdapterFactory) adapterFactory).addAdapterFactory(new
> MyModelProviderAdapterFactory());
> ((ComposedAdapterFactory) adapterFactory).addAdapterFactory(new
> MyModelSubPackageItemProviderAdapterFactory());
> ...
> ((ComposedAdapterFactory) adapterFactory).addAdapterFactory(new
> ReflectiveItemProviderAdapterFactory());
> owner.setLabelProvider(new
> AdapterFactoryLabelProvider(adapterFactory));
>
> Then that does work, but obviously that's not very satisfactory. :) Is
> there a pattern that I'm missing here?
>
> thanks,
>
> Miles

Report message to a moderator

Previous Topic:	Alternative for ProjectIncludingResourceLoader
Next Topic:	[CDO]

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Tue Apr 23 09:14:56 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter