Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » Buckminster » about.mappins and Buckminster 3.6
about.mappins and Buckminster 3.6 [message #542467] Thu, 24 June 2010 23:47 Go to next message
Philipp Nanz is currently offline Philipp NanzFriend
Messages: 46
Registered: February 2010
Member
After upgrading my Buckminster / Hudson combo to 3.6, I encountered a bug (well, atleast I think so):

I'm trying to override the new default about.mappings action, i.e. I wish to use my own buildFile instead of the predefined buildFileId.

When I add the buildFile via alterActorProperties I get an exception that having both is not allowed; however I can't remove the buildFileId either.

Trying to remove it leads to:

org.eclipse.buckminster.core.common.model.ImmutablePropertyE xception: buildFileId
at org.eclipse.buckminster.core.common.model.ExpandingPropertie s.remove(ExpandingProperties.java:391)
at org.eclipse.buckminster.core.cspecext.model.AlterAttribute.p erformPropertyAlterations(AlterAttribute.java:68)
at org.eclipse.buckminster.core.cspecext.model.AlterAction.alte rActorProperties(AlterAction.java:91)
at org.eclipse.buckminster.core.cspecext.model.AlterAction.alte rAttribute(AlterAction.java:82)
at org.eclipse.buckminster.core.cspecext.model.CSpecExtension.a lterCSpec(CSpecExtension.java:111)
at org.eclipse.buckminster.core.cspec.AbstractResolutionBuilder .applyExtensions(AbstractResolutionBuilder.java:132)
at org.eclipse.buckminster.pde.cspecgen.PDEBuilder.build(PDEBui lder.java:70)
at org.eclipse.buckminster.core.ctype.AbstractComponentType.get Resolution(AbstractComponentType.java:316)
at org.eclipse.buckminster.core.ctype.AbstractComponentType.get Resolution(AbstractComponentType.java:201)
at org.eclipse.buckminster.core.resolver.LocalResolver.fromPath (LocalResolver.java:163)
at org.eclipse.buckminster.core.resolver.LocalResolver.fromPath (LocalResolver.java:184)
at org.eclipse.buckminster.core.metadata.MetadataSynchronizer.r efreshProject(MetadataSynchronizer.java:313)
at org.eclipse.buckminster.core.metadata.MetadataSynchronizer$M etadataRefreshJob.run(MetadataSynchronizer.java:126)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)

Is this a feature or a bug? If it is a feature, how am I supposed to override the default about.mappings action??
Re: about.mappins and Buckminster 3.6 [message #542480 is a reply to message #542467] Fri, 25 June 2010 03:34 Go to previous messageGo to next message
Henrik Lindberg is currently offline Henrik LindbergFriend
Messages: 2509
Registered: July 2009
Senior Member
Sounds like a bug. Please log a bugzilla issue and supply the info...

- henrik

Philipp Nanz <philippn@gmail.com> wrote:
> After upgrading my Buckminster / Hudson combo to 3.6, I encountered a
> bug (well, atleast I think so):
>
> I'm trying to override the new default about.mappings action, i.e. I
> wish to use my own buildFile instead of the predefined buildFileId.
>
> When I add the buildFile via alterActorProperties I get an exception
> that having both is not allowed; however I can't remove the
> buildFileId either.
>
> Trying to remove it leads to:
>
> org.eclipse.buckminster.core.common.model.ImmutablePropertyE xception:
> buildFileId
> at org.eclipse.buckminster.core.common.model.ExpandingPropertie
> s.remove(ExpandingProperties.java:391)
> at org.eclipse.buckminster.core.cspecext.model.AlterAttribute.p
> erformPropertyAlterations(AlterAttribute.java:68)
> at org.eclipse.buckminster.core.cspecext.model.AlterAction.alte
> rActorProperties(AlterAction.java:91)
> at org.eclipse.buckminster.core.cspecext.model.AlterAction.alte
> rAttribute(AlterAction.java:82)
> at org.eclipse.buckminster.core.cspecext.model.CSpecExtension.a
> lterCSpec(CSpecExtension.java:111)
> at org.eclipse.buckminster.core.cspec.AbstractResolutionBuilder
> .applyExtensions(AbstractResolutionBuilder.java:132)
> at org.eclipse.buckminster.pde.cspecgen.PDEBuilder.build(PDEBui
> lder.java:70)
> at org.eclipse.buckminster.core.ctype.AbstractComponentType.get
> Resolution(AbstractComponentType.java:316)
> at org.eclipse.buckminster.core.ctype.AbstractComponentType.get
> Resolution(AbstractComponentType.java:201)
> at org.eclipse.buckminster.core.resolver.LocalResolver.fromPath
> (LocalResolver.java:163)
> at org.eclipse.buckminster.core.resolver.LocalResolver.fromPath
> (LocalResolver.java:184)
> at org.eclipse.buckminster.core.metadata.MetadataSynchronizer.r
> efreshProject(MetadataSynchronizer.java:313)
> at org.eclipse.buckminster.core.metadata.MetadataSynchronizer$M
> etadataRefreshJob.run(MetadataSynchronizer.java:126)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
>
> Is this a feature or a bug? If it is a feature, how am I supposed to
> override the default about.mappings action??



--
- henrik
Re: about.mappins and Buckminster 3.6 [message #542493 is a reply to message #542467] Fri, 25 June 2010 04:59 Go to previous messageGo to next message
Thomas Hallgren is currently offline Thomas HallgrenFriend
Messages: 3240
Registered: July 2009
Senior Member
Hi Philipp,

On 06/25/2010 01:47 AM, Philipp Nanz wrote:
> After upgrading my Buckminster / Hudson combo to 3.6, I encountered a
> bug (well, atleast I think so):
>
I doubt this is a regression. Can you verify that this used to work in earlier versions?

> I'm trying to override the new default about.mappings action, i.e. I
> wish to use my own buildFile instead of the predefined buildFileId.
>
> When I add the buildFile via alterActorProperties I get an exception
> that having both is not allowed; however I can't remove the buildFileId
> either.
>
This sounds like a bug. Can you please report it using our bugzilla? The workaround for now is to remove the action
altogether and then add it again. This should work since removes are executed before new additions are added.

HTH,
- thomas

> Trying to remove it leads to:
>
> org.eclipse.buckminster.core.common.model.ImmutablePropertyE xception:
> buildFileId
> at org.eclipse.buckminster.core.common.model.ExpandingPropertie
> s.remove(ExpandingProperties.java:391)
> at org.eclipse.buckminster.core.cspecext.model.AlterAttribute.p
> erformPropertyAlterations(AlterAttribute.java:68)
> at org.eclipse.buckminster.core.cspecext.model.AlterAction.alte
> rActorProperties(AlterAction.java:91)
> at org.eclipse.buckminster.core.cspecext.model.AlterAction.alte
> rAttribute(AlterAction.java:82)
> at org.eclipse.buckminster.core.cspecext.model.CSpecExtension.a
> lterCSpec(CSpecExtension.java:111)
> at org.eclipse.buckminster.core.cspec.AbstractResolutionBuilder
> .applyExtensions(AbstractResolutionBuilder.java:132)
> at org.eclipse.buckminster.pde.cspecgen.PDEBuilder.build(PDEBui
> lder.java:70)
> at org.eclipse.buckminster.core.ctype.AbstractComponentType.get
> Resolution(AbstractComponentType.java:316)
> at org.eclipse.buckminster.core.ctype.AbstractComponentType.get
> Resolution(AbstractComponentType.java:201)
> at org.eclipse.buckminster.core.resolver.LocalResolver.fromPath
> (LocalResolver.java:163)
> at org.eclipse.buckminster.core.resolver.LocalResolver.fromPath
> (LocalResolver.java:184)
> at org.eclipse.buckminster.core.metadata.MetadataSynchronizer.r
> efreshProject(MetadataSynchronizer.java:313)
> at org.eclipse.buckminster.core.metadata.MetadataSynchronizer$M
> etadataRefreshJob.run(MetadataSynchronizer.java:126)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
>
> Is this a feature or a bug? If it is a feature, how am I supposed to
> override the default about.mappings action??
Re: about.mappins and Buckminster 3.6 [message #542502 is a reply to message #542467] Fri, 25 June 2010 06:42 Go to previous messageGo to next message
Philipp Nanz is currently offline Philipp NanzFriend
Messages: 46
Registered: February 2010
Member
3.5 apparently didn't have a default about.mappings action, so I didn't have to overwrite anything.

Basically, all I want to do is replace a second token besides the @build@ in the about.mappings
Re: about.mappins and Buckminster 3.6 [message #542512 is a reply to message #542467] Fri, 25 June 2010 07:26 Go to previous messageGo to next message
Philipp Nanz is currently offline Philipp NanzFriend
Messages: 46
Registered: February 2010
Member
Bugzilla created: https://bugs.eclipse.org/bugs/show_bug.cgi?id=317922

Thanks for your time!
Re: about.mappins and Buckminster 3.6 [message #542986 is a reply to message #542493] Mon, 28 June 2010 06:39 Go to previous messageGo to next message
Philipp Nanz is currently offline Philipp NanzFriend
Messages: 46
Registered: February 2010
Member
Thomas Hallgren wrote on Fri, 25 June 2010 00:59

The workaround for now is to remove the action
altogether and then add it again. This should work since removes are executed before new additions are added.



Unfortunately that doesn'r work either.

Using:
	<alterActions>
		<remove name="about.mappings"/>
		<private name="about.mappings" actor="ant">
			<actorProperties>
				<property key="buildFile" value="build/about_mappings.ant"/>
				<property key="targets" value="replace.tokens"/>
			</actorProperties>
			<properties>
				<property key="build.id" value="${BUILD_ID} (r${SVN_REVISION})"/>
				<property key="version" value="${VERSION}"/>
			</properties>
			<prerequisites>
				<attribute alias="action.input" name="raw.about.mappings"/>
			</prerequisites>
			<products alias="action.output" base="${buckminster.output}/temp/">
				<path path="about.mappings"/>
			</products>
		</private>
	</alterActions>


I get Problem during meta-data refresh: CSpec net.sf.logsaw.rcp has no action, group, or local artifact named about.mappings
Re: about.mappins and Buckminster 3.6 [message #543283 is a reply to message #542986] Mon, 28 June 2010 23:26 Go to previous messageGo to next message
Thomas Hallgren is currently offline Thomas HallgrenFriend
Messages: 3240
Registered: July 2009
Senior Member
Hi Philipp,

I think you've misinterpreted the cspex syntax. It's an extension of the cspec and the <alterActions> is about altering
or removing existing actions, not about adding them. That's done using a normal <actions> element. Your example attempts
to first remove and then alter the same action.

Try something like this:

<actions>
<private name="about.mappings" actor="ant">
<actorProperties>
<property key="buildFile" value="build/about_mappings.ant"/>
<property key="targets" value="replace.tokens"/>
</actorProperties>
<properties>
<property key="build.id" value="${BUILD_ID} (r${SVN_REVISION})"/>
<property key="version" value="${VERSION}"/>
</properties>
<prerequisites>
<attribute alias="action.input" name="raw.about.mappings"/>
</prerequisites>
<products alias="action.output" base="${buckminster.output}/temp/">
<path path="about.mappings"/>
</products>
</private>
</actions>
<alterActions>
<remove name="about.mappings"/>
</alterActions>

The order is not significant. A remove is always executed before an add.

Regards,
Thomas Hallgren



On 06/28/2010 08:39 AM, Philipp Nanz wrote:
> Thomas Hallgren wrote on Fri, 25 June 2010 00:59
>> The workaround for now is to remove the action altogether and then add
>> it again. This should work since removes are executed before new
>> additions are added.
>
>
> Unfortunately that doesn'r work either.
>
> Using:
> <alterActions>
> <remove name="about.mappings"/>
> <private name="about.mappings" actor="ant">
> <actorProperties>
> <property key="buildFile" value="build/about_mappings.ant"/>
> <property key="targets" value="replace.tokens"/>
> </actorProperties>
> <properties>
> <property key="build.id" value="${BUILD_ID} (r${SVN_REVISION})"/>
> <property key="version" value="${VERSION}"/>
> </properties>
> <prerequisites>
> <attribute alias="action.input" name="raw.about.mappings"/>
> </prerequisites>
> <products alias="action.output" base="${buckminster.output}/temp/">
> <path path="about.mappings"/>
> </products>
> </private>
> </alterActions>
>
>
> I get Problem during meta-data refresh: CSpec net.sf.logsaw.rcp has no
> action, group, or local artifact named about.mappings
Re: about.mappins and Buckminster 3.6 [message #543295 is a reply to message #542467] Tue, 29 June 2010 00:50 Go to previous message
Philipp Nanz is currently offline Philipp NanzFriend
Messages: 46
Registered: February 2010
Member
Hi Thomas, that did the trick! Many thanks for the pointer Smile

Kind regards,
Philipp
Previous Topic:Groovy support, Eclipse 3.6
Next Topic:qaulifier replacement property
Goto Forum:
  


Current Time: Sat Jan 20 10:58:42 GMT 2018

Powered by FUDForum. Page generated in 0.01948 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software