Eclipse Community Forums: Eclipse Platform » StyledText: wrong style length in PaintObjectEvent

Help

Home

Home » Eclipse Projects » Eclipse Platform » StyledText: wrong style length in PaintObjectEvent

Show: Today's Messages :: Show Polls :: Message Navigator

StyledText: wrong style length in PaintObjectEvent [message #523117]

Thu, 25 March 2010 08:16

Franck Mising name

Messages: 92
Registered: July 2009
Location: France

Member

Before I file this as a bug I want to make sure I am not missing something: if I set a StyleRange with a length of 1 and a non null glyph metrics on a StyledText, I receive paint events with an event such that event.style.length = 0.

This seems to come from the way int array ranges are computed and interpreted in StyledTextRenderer vsTextLayout:

- in TextLayout.getRanges() the int[] array is said (javadoc) to contain the "start and end of each text style", and for a style with a length of 1 the array contains [..., <start>,<start>, ...].
Also the setStyle implementation shows that those offsets are inclusive.

- however in StyledTextRenderer.drawLine (end of the method when styles[i].metrics != null) the int[] array obtained from the layout is assumed to contain <start>,<start+1> since the style length is computed as

int length = ranges[(i << 1) + 1] - ranges[i << 1];

Can someone confirm that this is a bug?
Thanks!

Report message to a moderator

Re: StyledText: wrong style length in PaintObjectEvent [message #523817 is a reply to message #523117]

Mon, 29 March 2010 13:46

Felipe Heidrich

Messages: 29
Registered: July 2009

Junior Member

You are right, we are missing a + 1 there.
Please enter the bug.

Thank you
Felipe

Report message to a moderator

Re: StyledText: wrong style length in PaintObjectEvent [message #524241 is a reply to message #523817]

Wed, 31 March 2010 10:05

Franck Mising name

Messages: 92
Registered: July 2009
Location: France

Member

Felipe Heidrich wrote on Mon, 29 March 2010 09:46

You are right, we are missing a + 1 there.
Please enter the bug.

Thank you
Felipe

Thanks, I filed https://bugs.eclipse.org/bugs/show_bug.cgi?id=307681

Report message to a moderator

Previous Topic:	How to contribute to the default cut\|copy/paste StyledText commands
Next Topic:	How do I find the Install Unit (IU) for a particular plug-in?

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Sat Jun 15 22:04:37 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter