Eclipse Community Forums: Buckminster dev

Home » Eclipse Projects » Buckminster dev » Coding style

Thu, 10 December 2009 23:22

Eclipse User

Hi,
Buckminster uses a coding style that differs from the one used by the majority of the projects at Eclipse.org. In
particular, we put the '{' on a new line, i.e.

int size()
{
return size;
}

instead of:

int size() {
return size;
}

For historical reasons (before syntax coloring made the distinction really easy), we also prefix our fields with m_ or
s_, i.e.

private int m_size;

rather than

private int size;

I think it might be time to abandon our own style.

What's your opinion?

Regards,
Thomas Hallgren

Re: Coding style [message #503211 is a reply to message #503170]

Fri, 11 December 2009 07:10

Eclipse User

+1
but unsure of what you are proposing we should do - change everything???

- henrik

On 12/11/09 10:12 AM, Thomas Hallgren wrote:
> Hi,
> Buckminster uses a coding style that differs from the one used by the
> majority of the projects at Eclipse.org. In particular, we put the '{'
> on a new line, i.e.
>
> int size()
> {
> return size;
> }
>
> instead of:
>
> int size() {
> return size;
> }
>
> For historical reasons (before syntax coloring made the distinction
> really easy), we also prefix our fields with m_ or s_, i.e.
>
> private int m_size;
>
> rather than
>
> private int size;
>
> I think it might be time to abandon our own style.
>
> What's your opinion?
>
> Regards,
> Thomas Hallgren

Re: Coding style [message #503213 is a reply to message #503211]

Fri, 11 December 2009 07:17

Eclipse User

On 2009-12-11 13:10, Henrik Lindberg wrote:
> +1
> but unsure of what you are proposing we should do - change everything???
>
Yes, we would change the "Buckminster Coding Style" and run a source clean-up on all code.

- thomas

Re: Coding style [message #503433 is a reply to message #503170]

Mon, 14 December 2009 01:44

Eclipse User

+1

The aggregator uses generated code, which doesn't follow the buckminster
coding style anyway (field prefixes).

Karel

Thomas Hallgren napsal(a):
> Hi,
> Buckminster uses a coding style that differs from the one used by the
> majority of the projects at Eclipse.org. In particular, we put the '{'
> on a new line, i.e.
>
> int size()
> {
> return size;
> }
>
> instead of:
>
> int size() {
> return size;
> }
>
> For historical reasons (before syntax coloring made the distinction
> really easy), we also prefix our fields with m_ or s_, i.e.
>
> private int m_size;
>
> rather than
>
> private int size;
>
> I think it might be time to abandon our own style.
>
> What's your opinion?
>
> Regards,
> Thomas Hallgren

Re: Coding style [message #503445 is a reply to message #503213]

Mon, 14 December 2009 03:49

Eclipse User

+1

We have been talking about this for a few weeks in Pilsen. You were just faster in introducing this topic here :-)

I myself never liked the bucky coding style, so I will appreciate the change very much.

Once we change the coding style rules, we will have to (except the cleanup) refactor the field names manually. I don't think that they will change automatically.

Filip

Thomas Hallgren napsal(a):
> On 2009-12-11 13:10, Henrik Lindberg wrote:
>> +1
>> but unsure of what you are proposing we should do - change everything???
>>
> Yes, we would change the "Buckminster Coding Style" and run a source
> clean-up on all code.
>
> - thomas

Re: Coding style [message #512811 is a reply to message #503170]

Sun, 07 February 2010 17:26

Eclipse User

I just released the cocing style change to the SVN trunk which means that we now have a new revision of all java code.
It will be hard to make history comparisons that span over this revision. Such comparisons will likely need to be split
in two. Prior and after the coding style change.

- thomas

On 12/11/2009 10:12 AM, Thomas Hallgren wrote:
> Hi,
> Buckminster uses a coding style that differs from the one used by the
> majority of the projects at Eclipse.org. In particular, we put the '{'
> on a new line, i.e.
>
> int size()
> {
> return size;
> }
>
> instead of:
>
> int size() {
> return size;
> }
>
> For historical reasons (before syntax coloring made the distinction
> really easy), we also prefix our fields with m_ or s_, i.e.
>
> private int m_size;
>
> rather than
>
> private int size;
>
> I think it might be time to abandon our own style.
>
> What's your opinion?
>
> Regards,
> Thomas Hallgren

Re: Coding style [message #512814 is a reply to message #512811]

Sun, 07 February 2010 19:06

Eclipse User

Finally !
(I have always hated the m_, and s_ prefixes...)

- henrik

On 2/7/10 11:26 PM, Thomas Hallgren wrote:
> I just released the cocing style change to the SVN trunk which means
> that we now have a new revision of all java code. It will be hard to
> make history comparisons that span over this revision. Such comparisons
> will likely need to be split in two. Prior and after the coding style
> change.
>
> - thomas
>
>
> On 12/11/2009 10:12 AM, Thomas Hallgren wrote:
>> Hi,
>> Buckminster uses a coding style that differs from the one used by the
>> majority of the projects at Eclipse.org. In particular, we put the '{'
>> on a new line, i.e.
>>
>> int size()
>> {
>> return size;
>> }
>>
>> instead of:
>>
>> int size() {
>> return size;
>> }
>>
>> For historical reasons (before syntax coloring made the distinction
>> really easy), we also prefix our fields with m_ or s_, i.e.
>>
>> private int m_size;
>>
>> rather than
>>
>> private int size;
>>
>> I think it might be time to abandon our own style.
>>
>> What's your opinion?
>>
>> Regards,
>> Thomas Hallgren
>

Previous Topic:	[buckminster-dev] Project meta data is out of date for tools.buckminster
Next Topic:	[buckminster-dev] Downloading source jars

Goto Forum:

-=] Back to Top [=-

Current Time: Wed May 07 06:56:00 EDT 2025

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter