| How to create patches? [message #491825] |
Thu, 15 October 2009 22:22  |
Eclipse User |
|
|
|
I made a one line change and am create and submit a patch into Bugzilla
but I don't even know how to start. According to the documentation, I'm
supposed to just invoke 'git diff' (or at least, I think that's what I'm
supposed to do). This is good, I get a diff, but the documentation also
mentions something about providing a commit message. How does that come
into play? My only experience with distributed SCM systems is cloning a
bzr repository (and now a git one) so I really don't know what I'm
supposed to do.
Chris's patch doesn't seem to have any commit messages as far as I can
see, it seems like a regular old CVS diff to me.
https://bugs.eclipse.org/bugs/show_bug.cgi?id=291108
Any pointers would be much appreciated.
Thanks,
Remy
|
|
|
|
|
| Re: How to create patches? [message #492006 is a reply to message #491999] |
Fri, 16 October 2009 20:18  |
| Eclipse User |
|
|
|
Remy Suen wrote:
> What I ended up doing was committing through the EGit interface and then
> using 'git format-patch --root'.
--root wasn't necessary for 1 commit. I think you wanted 'git
format-patch -1' to make it format the most recent commit on the current
branch.
> I have attached my simple patch to
> Bugzilla in the mean time. It looks right based on the other attachments
> I've seen attached to Bugzilla but I could be wrong. :|
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=292588
Thanks, applied. I adjusted the commit message a bit to better fit with
standard git conventions, but otherwise the patch was correct.
|
|
|
|
| Re: How to create patches? [message #575044 is a reply to message #575000] |
Fri, 16 October 2009 19:11 |
| Eclipse User |
|
|
|
On Fri, 16 Oct 2009 07:25:00 -0400, Matthias Sohn wrote:
> Find detailed instructions for contribution
> http://wiki.eclipse.org/EGit/Contributor_Guide
Yeah, I tried reading that before posting but it didn't make a lot of
sense to me. Could be just me or it could be because I've never used a
decentralized SCM system, oh well.
What I ended up doing was committing through the EGit interface and then
using 'git format-patch --root'. I have attached my simple patch to
Bugzilla in the mean time. It looks right based on the other attachments
I've seen attached to Bugzilla but I could be wrong. :|
https://bugs.eclipse.org/bugs/show_bug.cgi?id=292588
Regards,
Remy
|
|
|
| Re: How to create patches? [message #575077 is a reply to message #491999] |
Fri, 16 October 2009 20:18 |
| Eclipse User |
|
|
|
Remy Suen wrote:
> What I ended up doing was committing through the EGit interface and then
> using 'git format-patch --root'.
--root wasn't necessary for 1 commit. I think you wanted 'git
format-patch -1' to make it format the most recent commit on the current
branch.
> I have attached my simple patch to
> Bugzilla in the mean time. It looks right based on the other attachments
> I've seen attached to Bugzilla but I could be wrong. :|
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=292588
Thanks, applied. I adjusted the commit message a bit to better fit with
standard git conventions, but otherwise the patch was correct.
|
|
|
Powered by
FUDForum. Page generated in 0.08254 seconds
Home