Eclipse Community Forums: Plugin Development Environment (PDE)

Help

Home

Home » Eclipse Projects » Plugin Development Environment (PDE) » try without catch. A Bug?

Show: Today's Messages :: Show Polls :: Message Navigator

try without catch. A Bug? [message #480837]

Tue, 18 August 2009 15:48

Eclipse User

Originally posted by: kai.edinger.drexler-software.de

Hello,

i have a newbie question. I've found an try-finally construct in the
source org.eclipse.ui.views.markers.internal.ExtendedMarkersView (Method
getUpdateJob) from the org.eclipse.ui.ide plug-in.

The problem with it is, that an exception is raised if a translation is
incorrect (A incorrect format string). It produce a lots of
Error-Dialogs (once per minute ) without any stack-trace. So it is very
hard to find the incorret translation-string.

I've correct the translation-string at the babel project. But is this
also a bug in the source? Should it report this as bug?

Greeting
Kai

Report message to a moderator

Re: try without catch. A Bug? [message #482189 is a reply to message #480837]

Tue, 25 August 2009 16:21

Curtis Windatt

Messages: 166
Registered: July 2009

Senior Member

The finally was added to make sure the tree is updated with any changes, even if there is a problem. Error handling is being passed to the Job Manager. This is a common pattern as the Job Manager will create an error dialog if the workbench is available or just log the problem otherwise.

I don't think the code is wrong (note that this is a forum for PDE, not Platform UI who owns the code). However, if you are having problems with an error dialog popping up every minute, that might be a valid bug. You could file a bug against platform UI describing steps to reproduce the problem.

Report message to a moderator