Eclipse Community Forums: SWTBot » [swtbot4gef] Why is the constructor of SWTBotEditPart and SwtBotConnectionEditPart package-private?

Home » Eclipse Projects » SWTBot » [swtbot4gef] Why is the constructor of SWTBotEditPart and SwtBotConnectionEditPart package-private?

[swtbot4gef] Why is the constructor of SWTBotEditPart and SwtBotConnectionEditPart package-private? [message #479787]

Wed, 12 August 2009 10:10

Eclipse User

I've been wondering why those constructors are package-private. I didn't
see any good reason so I might of overlooked something. It prevents me
from creating new adapters from EditPart I find using a custom search...
It also prevents clients from creating subclasses of those adapter,
since they might need some custom behavior for their model-specific edit
parts.
Also, I don't see why the adapters need to have the parent in its
constructor: its just duplicate information since the EditPart already
has this information...

p.s.: the name of SwtBotConnectionEditPart is misspelled. Swt should be
all uppercase to match the other adapters.
--
Pascal Gélinas | Software Developer
*Nu Echo Inc.*
http://www.nuecho.com/ | http://blog.nuecho.com/

*Because performance matters.*

Re: [swtbot4gef] Why is the constructor of SWTBotEditPart and SwtBotConnectionEditPart package-priva [message #479811 is a reply to message #479787]

Wed, 12 August 2009 11:33

Eclipse User

Hi Pascal,

Could you raise an issue for that ?

Thanks,

Mariot

Pascal Gelinas a écrit :
> I've been wondering why those constructors are package-private. I didn't
> see any good reason so I might of overlooked something. It prevents me
> from creating new adapters from EditPart I find using a custom search...
> It also prevents clients from creating subclasses of those adapter,
> since they might need some custom behavior for their model-specific edit
> parts.
> Also, I don't see why the adapters need to have the parent in its
> constructor: its just duplicate information since the EditPart already
> has this information...
>
> p.s.: the name of SwtBotConnectionEditPart is misspelled. Swt should be
> all uppercase to match the other adapters.

Re: [swtbot4gef] Why is the constructor of SWTBotEditPart and SwtBotConnectionEditPart package-priva [message #479964 is a reply to message #479787]

Thu, 13 August 2009 05:44

Eclipse User

Pascal Gelinas schrieb:
> I've been wondering why those constructors are package-private. I didn't
> see any good reason so I might of overlooked something. It prevents me
> from creating new adapters from EditPart I find using a custom search...
> It also prevents clients from creating subclasses of those adapter,
> since they might need some custom behavior for their model-specific edit
> parts.
> Also, I don't see why the adapters need to have the parent in its
> constructor: its just duplicate information since the EditPart already
> has this information...
>
> p.s.: the name of SwtBotConnectionEditPart is misspelled. Swt should be
> all uppercase to match the other adapters.

You probably have already made the required changes, so we would be glad
if you could attach a patch to your issue if you have done so.

Thanks
Jens

Previous Topic:	No getParent or getParentItem
Next Topic:	SWTBot can't find the "File" menu

Goto Forum:

-=] Back to Top [=-

Current Time: Tue Jun 24 18:58:24 EDT 2025

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter