Eclipse Community Forums: Standard Widget Toolkit (SWT) » Looking for a generic Transfer implementation for simple D&D

Home » Eclipse Projects » Standard Widget Toolkit (SWT) » Looking for a generic Transfer implementation for simple D&D

Show: Today's Messages :: Show Polls :: Message Navigator

Looking for a generic Transfer implementation for simple D&D [message #461742]

Thu, 29 September 2005 08:26

Martin

Messages: 35
Registered: July 2009

Member

Hi,

I need to implement drag&drop support. The drag source is a tree viewer
which contains self-defined model objects. The drop target will be some
widget that knows the model class.

I read some docs on SWT/JFace D&D and it seems I have to implement a
subclass of Transfer in order to use the D&D facilities. Now I wonder if
there's no simpler way of doing this: both sender and receiver know the
data type they exchange, but still I have to write a transportation
format that converts my model objects from/to byte[] (assuming I
subclass ByteArrayTransfer)...

Is there no 'generic' Transfer class that can transfer any Java object?
Or (that would be even better) did I miss something and there's a much
simpler solution for this?

Any comments are welcome.
TIA,
Martin

Report message to a moderator

Re: Looking for a generic Transfer implementation for simple D&D [message #461753 is a reply to message #461742]

Thu, 29 September 2005 11:02

Daniel Hirscher

Messages: 43
Registered: July 2009

Member

Martin,

have a look at EMFs D&D for a good starting point.

--
Daniel

Report message to a moderator

Re: Looking for a generic Transfer implementation for simple D&D [message #461759 is a reply to message #461753]

Thu, 29 September 2005 15:12

Martin

Messages: 35
Registered: July 2009

Member

Daniel Hirscher wrote:
> Martin,
>
> have a look at EMFs D&D for a good starting point.
>

Thanks for that hint. Looks very interesting, but I think that adding
EMF to my project wouldn't be reasonable... I already have a working
data model, and it's very simple (a Composite pattern structure with
three classes) so that using a modeling framework seems a bit
over-engineered.

I just want to be able to pass objects from one SWT thingie to another
via D&D. My current implementation uses TextTransfer to pass a unique
string identifying the object; on the drop site, this id is used to get
the original object from a commonly known storage. That works, but I
feel somewhat dirty when looking at the code...

Regards,
Martin

Report message to a moderator

Re: Looking for a generic Transfer implementation for simple D&D [message #461761 is a reply to message #461759]

Thu, 29 September 2005 16:20

Veronika Irvine

Messages: 1272
Registered: July 2009

Senior Member

Write your own data transfer that just puts a string in the byte array (same
string you were using for TextTransfer) and locally copies over the object.

The reason TextTransfer is not a good choice is because there are lots of
places where Text data is a valid type and people will drop your string into
strange places.

Here is an example class that you can start with:

public class MyTransfer extends ByteArrayTransfer {

private MyType data;
private static final String MYTYPENAME =
"name_for_my_type_which_is_unique_to_me";
private static final int MYTYPEID = registerType (MYTYPENAME);
private static MyTransfer _instance = new MyTransfer ();

public static MyTransfer getInstance () {
return _instance;
}

public void javaToNative (Object object, TransferData transferData) {
if (!checkMyType(object) || !isSupportedType (transferData)) {
DND.error(DND.ERROR_INVALID_DATA);
}
data = (MyType)object;
byte[] buffer = object.toString().getBytes();
super.javaToNative (buffer, transferData);
}

public Object nativeToJava (TransferData transferData) {
if (isSupportedType (transferData)) {
byte [] buffer = (byte []) super.nativeToJava
(transferData);
String string = new String(buffer);
if (string.equals(data.toString())) return data;
}
return null;
}

protected String [] getTypeNames () {
return new String [] {MYTYPENAME};
}

protected int [] getTypeIds () {
return new int [] {MYTYPEID};
}

boolean checkMyType(Object object) {
return (object != null && object instanceof MyType);
}

protected boolean validate(Object object) {
return checkMyType(object);
}
}

"Martin" <address.starts.after.hyphen-martin.umgeher@joanneum.at> wrote in
message news:dhh0bj$18t$1@news.eclipse.org...
> Daniel Hirscher wrote:
>> Martin,
>>
>> have a look at EMFs D&D for a good starting point.
>>
>
> Thanks for that hint. Looks very interesting, but I think that adding EMF
> to my project wouldn't be reasonable... I already have a working data
> model, and it's very simple (a Composite pattern structure with three
> classes) so that using a modeling framework seems a bit over-engineered.
>
> I just want to be able to pass objects from one SWT thingie to another via
> D&D. My current implementation uses TextTransfer to pass a unique string
> identifying the object; on the drop site, this id is used to get the
> original object from a commonly known storage. That works, but I feel
> somewhat dirty when looking at the code...
>
> Regards,
> Martin

Report message to a moderator

Re: Looking for a generic Transfer implementation for simple D&D [message #461786 is a reply to message #461761]

Fri, 30 September 2005 07:47

Martin

Messages: 35
Registered: July 2009

Member

Veronika Irvine wrote:
> Write your own data transfer that just puts a string in the byte array (same
> string you were using for TextTransfer) and locally copies over the object.
>
> The reason TextTransfer is not a good choice is because there are lots of
> places where Text data is a valid type and people will drop your string into
> strange places.
>
> Here is an example class that you can start with:
>
> [ snip ]
>

Thanks, that really helped a lot!

Just as a matter of interest: why do I have to provide something that's
convertable to and from byte[] at all? I just don't get what
javaToNative and nativeToJava are good for if I can store the actual
object I want to transfer in the MyTransfer instance. I experimented a
bit with your code and it seems that those methods have to be called,
but I can ignore their results:

public void javaToNative(Object object, TransferData transferData) {
if (!validate(object) || !isSupportedType(transferData)) {
DND.error(DND.ERROR_INVALID_DATA);
}
data = (MyType)object;
super.javaToNative("whatever".getBytes(), transferData);
}

@Override
public Object nativeToJava(TransferData transferData) {
super.nativeToJava(transferData);
return data;
}

I'd really like to understand SWT D&D a bit better, so any explanation
(e.g. why this works or why it's evil) is welcome.

thx
Martin

Report message to a moderator

Re: Looking for a generic Transfer implementation for simple D&D [message #461808 is a reply to message #461786]

Fri, 30 September 2005 14:01

Veronika Irvine

Messages: 1272
Registered: July 2009

Senior Member

Drag and Drop uses the OS to transfer the data. The destination can be in a
completely different application from the source so you can not transfer a
Java object. Also, on many platforms drag and drop will fail if you don't
provide any data at all.

You do not have to create a byte array but if you do not use a byte array
you will have to write platform specific code to create a pointer to your
data in whatever form you choose. The byte array is a convenience format
provided by SWT.

"Martin" <address.starts.after.hyphen-martin.umgeher@joanneum.at> wrote in
message news:dhiqkt$cv6$1@news.eclipse.org...
> Veronika Irvine wrote:
>> Write your own data transfer that just puts a string in the byte array
>> (same string you were using for TextTransfer) and locally copies over the
>> object.
>>
>> The reason TextTransfer is not a good choice is because there are lots of
>> places where Text data is a valid type and people will drop your string
>> into strange places.
>>
>> Here is an example class that you can start with:
>>
>> [ snip ]
>>
>
> Thanks, that really helped a lot!
>
> Just as a matter of interest: why do I have to provide something that's
> convertable to and from byte[] at all? I just don't get what javaToNative
> and nativeToJava are good for if I can store the actual object I want to
> transfer in the MyTransfer instance. I experimented a bit with your code
> and it seems that those methods have to be called, but I can ignore their
> results:
>
> public void javaToNative(Object object, TransferData transferData) {
> if (!validate(object) || !isSupportedType(transferData)) {
> DND.error(DND.ERROR_INVALID_DATA);
> }
> data = (MyType)object;
> super.javaToNative("whatever".getBytes(), transferData);
> }
>
> @Override
> public Object nativeToJava(TransferData transferData) {
> super.nativeToJava(transferData);
> return data;
> }
>
> I'd really like to understand SWT D&D a bit better, so any explanation
> (e.g. why this works or why it's evil) is welcome.
>
> thx
> Martin

Report message to a moderator

Previous Topic:	GUI update
Next Topic:	FormLayout calculating location of formData.bottom

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Fri Apr 20 02:44:20 GMT 2018

.:: Contact :: Home ::.