Eclipse Community Forums: Standard Widget Toolkit (SWT) » What changed in CTabFolder from M2 to M3?

Home » Eclipse Projects » Standard Widget Toolkit (SWT) » What changed in CTabFolder from M2 to M3?

What changed in CTabFolder from M2 to M3? [message #449757]

Fri, 28 January 2005 15:57

Eclipse User

Something changed in CTabFolder or ScrolledCompositeLayout from SWT
3.1-M2 to 3.1-M3. Because in Azureus the option tab doesn't work anymore
(see stacktrace below). Which is especially annoying because M3 has the
new GTK FileDialog.

There is a bug filed about this:
http://sourceforge.net/tracker/?group_id=84122&atid=5751 54&func=detail&aid=1075272
The statements from the devs is:
"Azureus doesn't support SWT3.1M3 (use M2) - they stuffed
something up."

So my question is basically who's fault is it, SWT or Azureus?
I had a look at the related Azureus Code and it is "interesting". I
looked at ScrolledCompositeLayout and the problem there is that contents
of the ScrolledComposite is null. In ScrolledComposite itself I found a
lot of checks for this case, so my impression is that there went
something wrong.

DEBUG::Fri Jan 28 16:34:32 CET 2005
java.lang.NullPointerException
at
org.eclipse.swt.custom.ScrolledCompositeLayout.computeSize(S crolledCompositeLa
yout.java:27)
at
org.eclipse.swt.widgets.Composite.computeSize(Composite.java :190)
at
org.eclipse.swt.custom.StackLayout.computeSize(StackLayout.j ava:94)
at
org.eclipse.swt.widgets.Composite.computeSize(Composite.java :190)
at org.eclipse.swt.layout.GridData.computeSize(GridData.java:45 0)
at org.eclipse.swt.layout.GridLayout.layout(GridLayout.java:197 )
at
org.eclipse.swt.layout.GridLayout.computeSize(GridLayout.jav a:155)
at
org.eclipse.swt.widgets.Composite.computeSize(Composite.java :190)
at
org.eclipse.swt.custom.SashFormLayout.computeSize(SashFormLa yout.java:46)
at
org.eclipse.swt.widgets.Composite.computeSize(Composite.java :190)
at org.eclipse.swt.layout.GridData.computeSize(GridData.java:45 0)
at org.eclipse.swt.layout.GridLayout.layout(GridLayout.java:197 )
at
org.eclipse.swt.layout.GridLayout.computeSize(GridLayout.jav a:155)
at
org.eclipse.swt.widgets.Composite.computeSize(Composite.java :190)
at org.eclipse.swt.layout.GridData.computeSize(GridData.java:45 0)
at org.eclipse.swt.layout.GridLayout.layout(GridLayout.java:197 )
at org.eclipse.swt.layout.GridLayout.layout(GridLayout.java:186 )
at
org.eclipse.swt.widgets.Composite.updateLayout(Composite.jav a:1097)
at org.eclipse.swt.widgets.Composite.setBounds(Composite.java:9 34)
at org.eclipse.swt.widgets.Control.setBounds(Control.java:466)
at org.eclipse.swt.widgets.Control.setBounds(Control.java:438)
at
org.eclipse.swt.custom.CTabFolder.setSelection(CTabFolder.ja va:3124)
at
org.eclipse.swt.custom.CTabFolder.setSelection(CTabFolder.ja va:3095)
at org.gudy.azureus2.ui.swt.Tab.<init>(Tab.java:134)
at
org.gudy.azureus2.ui.swt.mainwindow.MainWindow.showConfig(Ma inWindow.java:1396
)
at
org.gudy.azureus2.ui.swt.mainwindow.MainMenu$27.handleEvent( MainMenu.java:408)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java :82)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:996)
at
org.eclipse.swt.widgets.Display.runDeferredEvents(Display.ja va:2698)
at
org.eclipse.swt.widgets.Display.readAndDispatch(Display.java :2397)
at
org.gudy.azureus2.ui.swt.mainwindow.SWTThread.<init>(SWTThread.java:98)
at
org.gudy.azureus2.ui.swt.mainwindow.SWTThread.createInstance (SWTThread.java:55
)
at
org.gudy.azureus2.ui.swt.mainwindow.Initializer.<init>(Initializer.java:106)
at org.gudy.azureus2.ui.swt.Main.<init>(Main.java:73)
at org.gudy.azureus2.ui.swt.Main.main(Main.java:100)

Re: What changed in CTabFolder from M2 to M3? [message #449918 is a reply to message #449757]

Mon, 31 January 2005 10:03

Eclipse User

Sorry, in M2 there was a check in computeSize for the case where the content
is null and in M3 when I restructured the code to use a layout I lost the
null check. ScrolledComposite is now fixed in HEAD for 3.1 and the fix will
be included for M5. The fact that the content is null may be a problem for
Azureus but the ScrolledComposite should not have thrown an exception.

"Philippe Marschall" <kustos@gmx.net> wrote in message
news:cte8vd$jss$1@www.eclipse.org...
> Something changed in CTabFolder or ScrolledCompositeLayout from SWT 3.1-M2
> to 3.1-M3. Because in Azureus the option tab doesn't work anymore (see
> stacktrace below). Which is especially annoying because M3 has the new GTK
> FileDialog.
>
> There is a bug filed about this:
> http://sourceforge.net/tracker/?group_id=84122&atid=5751 54&func=detail&aid=1075272
> The statements from the devs is:
> "Azureus doesn't support SWT3.1M3 (use M2) - they stuffed
> something up."
>
> So my question is basically who's fault is it, SWT or Azureus?
> I had a look at the related Azureus Code and it is "interesting". I looked
> at ScrolledCompositeLayout and the problem there is that contents of the
> ScrolledComposite is null. In ScrolledComposite itself I found a lot of
> checks for this case, so my impression is that there went something wrong.
>
>
> DEBUG::Fri Jan 28 16:34:32 CET 2005
> java.lang.NullPointerException
> at
> org.eclipse.swt.custom.ScrolledCompositeLayout.computeSize(S crolledCompositeLa
> yout.java:27)
> at
> org.eclipse.swt.widgets.Composite.computeSize(Composite.java :190)
> at
> org.eclipse.swt.custom.StackLayout.computeSize(StackLayout.j ava:94)
> at
> org.eclipse.swt.widgets.Composite.computeSize(Composite.java :190)
> at org.eclipse.swt.layout.GridData.computeSize(GridData.java:45 0)
> at org.eclipse.swt.layout.GridLayout.layout(GridLayout.java:197 )
> at
> org.eclipse.swt.layout.GridLayout.computeSize(GridLayout.jav a:155)
> at
> org.eclipse.swt.widgets.Composite.computeSize(Composite.java :190)
> at
> org.eclipse.swt.custom.SashFormLayout.computeSize(SashFormLa yout.java:46)
> at
> org.eclipse.swt.widgets.Composite.computeSize(Composite.java :190)
> at org.eclipse.swt.layout.GridData.computeSize(GridData.java:45 0)
> at org.eclipse.swt.layout.GridLayout.layout(GridLayout.java:197 )
> at
> org.eclipse.swt.layout.GridLayout.computeSize(GridLayout.jav a:155)
> at
> org.eclipse.swt.widgets.Composite.computeSize(Composite.java :190)
> at org.eclipse.swt.layout.GridData.computeSize(GridData.java:45 0)
> at org.eclipse.swt.layout.GridLayout.layout(GridLayout.java:197 )
> at org.eclipse.swt.layout.GridLayout.layout(GridLayout.java:186 )
> at
> org.eclipse.swt.widgets.Composite.updateLayout(Composite.jav a:1097)
> at org.eclipse.swt.widgets.Composite.setBounds(Composite.java:9 34)
> at org.eclipse.swt.widgets.Control.setBounds(Control.java:466)
> at org.eclipse.swt.widgets.Control.setBounds(Control.java:438)
> at
> org.eclipse.swt.custom.CTabFolder.setSelection(CTabFolder.ja va:3124)
> at
> org.eclipse.swt.custom.CTabFolder.setSelection(CTabFolder.ja va:3095)
> at org.gudy.azureus2.ui.swt.Tab.<init>(Tab.java:134)
> at
> org.gudy.azureus2.ui.swt.mainwindow.MainWindow.showConfig(Ma inWindow.java:1396
> )
> at
> org.gudy.azureus2.ui.swt.mainwindow.MainMenu$27.handleEvent( MainMenu.java:408)
> at
> org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java :82)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:996)
> at
> org.eclipse.swt.widgets.Display.runDeferredEvents(Display.ja va:2698)
> at
> org.eclipse.swt.widgets.Display.readAndDispatch(Display.java :2397)
> at
> org.gudy.azureus2.ui.swt.mainwindow.SWTThread.<init>(SWTThread.java:98)
> at
> org.gudy.azureus2.ui.swt.mainwindow.SWTThread.createInstance (SWTThread.java:55
> )
> at
> org.gudy.azureus2.ui.swt.mainwindow.Initializer.<init>(Initializer.java:106)
> at org.gudy.azureus2.ui.swt.Main.<init>(Main.java:73)
> at org.gudy.azureus2.ui.swt.Main.main(Main.java:100)

Re: What changed in CTabFolder from M2 to M3? [message #449923 is a reply to message #449918]

Mon, 31 January 2005 10:47

Eclipse User

Thank you. That's good news.

Veronika Irvine wrote:
> Sorry, in M2 there was a check in computeSize for the case where the content
> is null and in M3 when I restructured the code to use a layout I lost the
> null check. ScrolledComposite is now fixed in HEAD for 3.1 and the fix will
> be included for M5. The fact that the content is null may be a problem for
> Azureus but the ScrolledComposite should not have thrown an exception.
>
>
> "Philippe Marschall" <kustos@gmx.net> wrote in message
> news:cte8vd$jss$1@www.eclipse.org...
>
>>Something changed in CTabFolder or ScrolledCompositeLayout from SWT 3.1-M2
>>to 3.1-M3. Because in Azureus the option tab doesn't work anymore (see
>>stacktrace below). Which is especially annoying because M3 has the new GTK
>>FileDialog.
>>
>>There is a bug filed about this:
>> http://sourceforge.net/tracker/?group_id=84122&atid=5751 54&func=detail&aid=1075272
>>The statements from the devs is:
>>"Azureus doesn't support SWT3.1M3 (use M2) - they stuffed
>>something up."
>>
>>So my question is basically who's fault is it, SWT or Azureus?
>>I had a look at the related Azureus Code and it is "interesting". I looked
>>at ScrolledCompositeLayout and the problem there is that contents of the
>>ScrolledComposite is null. In ScrolledComposite itself I found a lot of
>>checks for this case, so my impression is that there went something wrong.
>>
>>
>>DEBUG::Fri Jan 28 16:34:32 CET 2005
>> java.lang.NullPointerException
>> at
>> org.eclipse.swt.custom.ScrolledCompositeLayout.computeSize(S crolledCompositeLa
>>yout.java:27)
>> at
>> org.eclipse.swt.widgets.Composite.computeSize(Composite.java :190)
>> at
>> org.eclipse.swt.custom.StackLayout.computeSize(StackLayout.j ava:94)
>> at
>> org.eclipse.swt.widgets.Composite.computeSize(Composite.java :190)
>> at org.eclipse.swt.layout.GridData.computeSize(GridData.java:45 0)
>> at org.eclipse.swt.layout.GridLayout.layout(GridLayout.java:197 )
>> at
>> org.eclipse.swt.layout.GridLayout.computeSize(GridLayout.jav a:155)
>> at
>> org.eclipse.swt.widgets.Composite.computeSize(Composite.java :190)
>> at
>> org.eclipse.swt.custom.SashFormLayout.computeSize(SashFormLa yout.java:46)
>> at
>> org.eclipse.swt.widgets.Composite.computeSize(Composite.java :190)
>> at org.eclipse.swt.layout.GridData.computeSize(GridData.java:45 0)
>> at org.eclipse.swt.layout.GridLayout.layout(GridLayout.java:197 )
>> at
>> org.eclipse.swt.layout.GridLayout.computeSize(GridLayout.jav a:155)
>> at
>> org.eclipse.swt.widgets.Composite.computeSize(Composite.java :190)
>> at org.eclipse.swt.layout.GridData.computeSize(GridData.java:45 0)
>> at org.eclipse.swt.layout.GridLayout.layout(GridLayout.java:197 )
>> at org.eclipse.swt.layout.GridLayout.layout(GridLayout.java:186 )
>> at
>> org.eclipse.swt.widgets.Composite.updateLayout(Composite.jav a:1097)
>> at org.eclipse.swt.widgets.Composite.setBounds(Composite.java:9 34)
>> at org.eclipse.swt.widgets.Control.setBounds(Control.java:466)
>> at org.eclipse.swt.widgets.Control.setBounds(Control.java:438)
>> at
>> org.eclipse.swt.custom.CTabFolder.setSelection(CTabFolder.ja va:3124)
>> at
>> org.eclipse.swt.custom.CTabFolder.setSelection(CTabFolder.ja va:3095)
>> at org.gudy.azureus2.ui.swt.Tab.<init>(Tab.java:134)
>> at
>> org.gudy.azureus2.ui.swt.mainwindow.MainWindow.showConfig(Ma inWindow.java:1396
>> )
>> at
>> org.gudy.azureus2.ui.swt.mainwindow.MainMenu$27.handleEvent( MainMenu.java:408)
>> at
>> org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java :82)
>> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:996)
>> at
>> org.eclipse.swt.widgets.Display.runDeferredEvents(Display.ja va:2698)
>> at
>> org.eclipse.swt.widgets.Display.readAndDispatch(Display.java :2397)
>> at
>>org.gudy.azureus2.ui.swt.mainwindow.SWTThread.<init>(SWTThread.java:98)
>> at
>> org.gudy.azureus2.ui.swt.mainwindow.SWTThread.createInstance (SWTThread.java:55
>> )
>> at
>>org.gudy.azureus2.ui.swt.mainwindow.Initializer.<init>(Initializer.java:106)
>> at org.gudy.azureus2.ui.swt.Main.<init>(Main.java:73)
>> at org.gudy.azureus2.ui.swt.Main.main(Main.java:100)
>
>
>

Previous Topic:	How can I execute a executable file with SWT?
Next Topic:	SWT GC - Rendering quality, API, etc

Goto Forum:

-=] Back to Top [=-

Current Time: Sun Jul 13 10:42:33 EDT 2025

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter